]> git.sesse.net Git - mlt/blobdiff - src/modules/qimage/qimage_wrapper.cpp
Fix flicker frame appearing at 0 position, small optimisations
[mlt] / src / modules / qimage / qimage_wrapper.cpp
index 2856324b240ca047d0962dd82811d77d5888ea29..ed52681cc8453ebdcf202f8d680a26c0b47989f7 100644 (file)
@@ -39,6 +39,7 @@
 #include <QtGui/QImage>
 #include <QtCore/QSysInfo>
 #include <QtCore/QMutex>
+#include <QtCore/QtEndian>
 #endif
 
 
@@ -47,6 +48,7 @@
 extern "C" {
 
 #include <framework/mlt_pool.h>
+#include <framework/mlt_cache.h>
 
 #ifdef USE_KDE
 static KInstance *instance = 0L;
@@ -63,7 +65,7 @@ static void qimage_delete( void *data )
 #endif
 }
 
-QMutex mutex;
+static QMutex g_mutex;
 
 #ifdef USE_KDE
 void init_qimage()
@@ -75,23 +77,26 @@ void init_qimage()
 }
 #endif
 
-void refresh_qimage( mlt_frame frame, int width, int height )
+void refresh_qimage( producer_qimage self, mlt_frame frame, int width, int height )
 {
-       // Obtain a previous assigned qimage (if it exists) 
-       QImage *qimage = static_cast <QImage *>(mlt_properties_get_data( MLT_FRAME_PROPERTIES( frame ), "qimage", NULL ));
-
        // Obtain properties of frame
        mlt_properties properties = MLT_FRAME_PROPERTIES( frame );
 
-       // Obtain the producer for this frame
-       producer_qimage self = ( producer_qimage )mlt_properties_get_data( properties, "producer_qimage", NULL );
-
        // Obtain the producer 
        mlt_producer producer = &self->parent;
 
        // Obtain properties of producer
        mlt_properties producer_props = MLT_PRODUCER_PROPERTIES( producer );
 
+       // restore QImage
+       pthread_mutex_lock( &self->mutex );
+       mlt_cache_item qimage_cache = mlt_service_cache_get( MLT_PRODUCER_SERVICE( producer ), "qimage.qimage" );
+       QImage *qimage = static_cast<QImage*>( mlt_cache_item_data( qimage_cache, NULL ) );
+
+       // restore scaled image
+       self->image_cache = mlt_service_cache_get( MLT_PRODUCER_SERVICE( producer ), "qimage.image" );
+       self->current_image = static_cast<uint8_t*>( mlt_cache_item_data( self->image_cache, NULL ) );
+
        // Check if user wants us to reload the image
        if ( mlt_properties_get_int( producer_props, "force_reload" ) ) 
        {
@@ -119,7 +124,7 @@ void refresh_qimage( mlt_frame frame, int width, int height )
        char image_key[ 10 ];
        sprintf( image_key, "%d", image_idx );
 
-       mutex.lock();
+       g_mutex.lock();
 
        // Check if the frame is already loaded
        if ( use_cache )
@@ -141,7 +146,7 @@ void refresh_qimage( mlt_frame frame, int width, int height )
                        mlt_properties_set_int( producer_props, "_real_width", mlt_properties_get_int( cached_props, "real_width" ) );
                        mlt_properties_set_int( producer_props, "_real_height", mlt_properties_get_int( cached_props, "real_height" ) );
                        self->current_image = ( uint8_t * )mlt_properties_get_data( cached_props, "image", NULL );
-                       self->current_alpha = ( uint8_t * )mlt_properties_get_data( cached_props, "alpha", NULL );
+                       self->has_alpha = mlt_properties_get_int( cached_props, "alpha" );
 
                        if ( width != 0 && ( width != self->current_width || height != self->current_height ) )
                                self->current_image = NULL;
@@ -149,45 +154,28 @@ void refresh_qimage( mlt_frame frame, int width, int height )
        }
 
     // optimization for subsequent iterations on single picture
-       if ( width != 0 && self->current_image != NULL && image_idx == self->image_idx )
-       {
-               if ( width != self->current_width || height != self->current_height )
-               {
-                       qimage = static_cast<QImage *>(mlt_properties_get_data( producer_props, "_qimage", NULL ));
-                       if ( !use_cache )
-                       {
-                               mlt_pool_release( self->current_image );
-                               mlt_pool_release( self->current_alpha );
-                       }
-                       self->current_image = NULL;
-                       self->current_alpha = NULL;
-               }
-       }
-       else if ( qimage == NULL && ( self->current_image == NULL || image_idx != self->image_idx ) )
+       if ( width != 0 && ( image_idx != self->image_idx || width != self->current_width || height != self->current_height ) )
+               self->current_image = NULL;
+       if ( image_idx != self->qimage_idx )
+               qimage = NULL;
+       if ( !qimage && !self->current_image )
        {
-               if ( !use_cache )
-               {
-                       mlt_pool_release( self->current_image );
-                       mlt_pool_release( self->current_alpha );
-               }
                self->current_image = NULL;
-               self->current_alpha = NULL;
-
-               self->image_idx = image_idx;
                qimage = new QImage( mlt_properties_get_value( self->filenames, image_idx ) );
 
                if ( !qimage->isNull( ) )
                {
-                       QImage *frame_copy = new QImage( *qimage );
-
-                       // Store the width/height of the pixbuf 
+                       // Store the width/height of the qimage
                        self->current_width = qimage->width( );
                        self->current_height = qimage->height( );
 
                        // Register qimage for destruction and reuse
+                       mlt_cache_item_close( qimage_cache );
+                       mlt_service_cache_put( MLT_PRODUCER_SERVICE( producer ), "qimage.qimage", qimage, 0, ( mlt_destructor )qimage_delete );
+                       qimage_cache = mlt_service_cache_get( MLT_PRODUCER_SERVICE( producer ), "qimage.qimage" );
+                       self->qimage_idx = image_idx;
+
                        mlt_events_block( producer_props, NULL );
-                       mlt_properties_set_data( producer_props, "_qimage", qimage, 0, ( mlt_destructor )qimage_delete, NULL );
-                       mlt_properties_set_data( MLT_FRAME_PROPERTIES( frame ), "qimage", frame_copy, 0, ( mlt_destructor )qimage_delete, NULL );
                        mlt_properties_set_int( producer_props, "_real_width", self->current_width );
                        mlt_properties_set_int( producer_props, "_real_height", self->current_height );
                        mlt_events_unblock( producer_props, NULL );
@@ -200,7 +188,7 @@ void refresh_qimage( mlt_frame frame, int width, int height )
        }
 
        // If we have a pixbuf and this request specifies a valid dimension and we haven't already got a cached version...
-       if ( qimage && width > 0 && self->current_image == NULL )
+       if ( qimage && width > 0 && !self->current_image )
        {
                char *interps = mlt_properties_get( properties, "rescale.interp" );
                int interp = 0;
@@ -213,66 +201,70 @@ void refresh_qimage( mlt_frame frame, int width, int height )
 
 #ifdef USE_QT4
                // Note - the original qimage is already safe and ready for destruction
-               QImage scaled = interp == 0 ? qimage->scaled( QSize( width, height)) : qimage->scaled( QSize(width, height), Qt::IgnoreAspectRatio, Qt::SmoothTransformation);
+               QImage scaled = interp == 0 ? qimage->scaled( QSize( width, height ) ) :
+                       qimage->scaled( QSize(width, height), Qt::IgnoreAspectRatio, Qt::SmoothTransformation );
                QImage temp;
-               bool hasAlpha = scaled.hasAlphaChannel();
-               if (hasAlpha)
-                   temp = scaled.convertToFormat(QImage::Format_ARGB32);
-               else 
-                   temp = scaled.convertToFormat(QImage::Format_RGB888);
+               self->has_alpha = scaled.hasAlphaChannel();
 #endif
 
 #ifdef USE_QT3
                // Note - the original qimage is already safe and ready for destruction
-               QImage scaled = interp == 0 ? qimage->scale( width, height, QImage::ScaleFree ) : qimage->smoothScale( width, height, QImage::ScaleFree );
-               QImage temp = scaled.convertDepth( 32 );
-               bool hasAlpha = true;
+               QImage scaled = interp == 0 ? qimage->scale( width, height, QImage::ScaleFree ) :
+                       qimage->smoothScale( width, height, QImage::ScaleFree );
+               self->has_alpha = 1;
 #endif
 
                // Store width and height
                self->current_width = width;
                self->current_height = height;
-               
-               // Allocate/define image
-               self->current_image = ( uint8_t * )mlt_pool_alloc( width * ( height + 1 ) * 2 );
-
 
-               if (!hasAlpha) {
-                       mlt_convert_rgb24_to_yuv422( temp.bits(), self->current_width, self->current_height, temp.bytesPerLine(), self->current_image ); 
+               // Allocate/define image
+               int dst_stride = width * ( self->has_alpha ? 4 : 3 );
+               int image_size = dst_stride * ( height + 1 );
+               self->current_image = ( uint8_t * )mlt_pool_alloc( image_size );
+
+               // Copy the image
+               int y = self->current_height + 1;
+               uint8_t *dst = self->current_image;
+               while ( --y )
+               {
+                       QRgb *src = (QRgb*) scaled.scanLine( self->current_height - y );
+                       int x = self->current_width + 1;
+                       while ( --x )
+                       {
+                               *dst++ = qRed(*src);
+                               *dst++ = qGreen(*src);
+                               *dst++ = qBlue(*src);
+                               if ( self->has_alpha ) *dst++ = qAlpha(*src);
+                               ++src;
+                       }
                }
-               else {
-                       // Allocate the alpha mask
-                       self->current_alpha = ( uint8_t * )mlt_pool_alloc( self->current_width * self->current_height );
-#ifdef USE_QT4
-                       if ( QSysInfo::ByteOrder == QSysInfo::BigEndian )
-                               mlt_convert_argb_to_yuv422( temp.bits( ), self->current_width, self->current_height, temp.bytesPerLine(), self->current_image, self->current_alpha );
-                       else
-                               mlt_convert_bgr24a_to_yuv422( temp.bits( ), self->current_width, self->current_height, temp.bytesPerLine( ), self->current_image, self->current_alpha );
-#endif
 
-#ifdef USE_QT3
-                       // Convert the image
-                       if ( QImage::systemByteOrder( ) == QImage::BigEndian )
-                               mlt_convert_argb_to_yuv422( temp.bits( ), self->current_width, self->current_height, temp.bytesPerLine( ), self->current_image, self->current_alpha );
-                       else
-                               mlt_convert_bgr24a_to_yuv422( temp.bits( ), self->current_width, self->current_height, temp.bytesPerLine( ), self->current_image, self->current_alpha );
-#endif
-               }
+               // Update the cache
+               if ( !use_cache )
+                       mlt_cache_item_close( self->image_cache );
+               mlt_service_cache_put( MLT_PRODUCER_SERVICE( producer ), "qimage.image", self->current_image, image_size, mlt_pool_release );
+               self->image_cache = mlt_service_cache_get( MLT_PRODUCER_SERVICE( producer ), "qimage.image" );
+               self->image_idx = image_idx;
 
                // Ensure we update the cache when we need to
                update_cache = use_cache;
        }
 
+       // release references no longer needed
+       mlt_cache_item_close( qimage_cache );
+       if ( width == 0 )
+       {
+               pthread_mutex_unlock( &self->mutex );
+               mlt_cache_item_close( self->image_cache );
+       }
+
        // Set width/height of frame
        mlt_properties_set_int( properties, "width", self->current_width );
        mlt_properties_set_int( properties, "height", self->current_height );
        mlt_properties_set_int( properties, "real_width", mlt_properties_get_int( producer_props, "_real_width" ) );
        mlt_properties_set_int( properties, "real_height", mlt_properties_get_int( producer_props, "_real_height" ) );
 
-       // pass the image data without destructor
-       mlt_properties_set_data( properties, "image", self->current_image, self->current_width * ( self->current_height + 1 ) * 2, NULL, NULL );
-       mlt_properties_set_data( properties, "alpha", self->current_alpha, self->current_width * self->current_height, NULL, NULL );
-
        if ( update_cache )
        {
                mlt_frame cached = mlt_frame_init( MLT_PRODUCER_SERVICE( producer ) );
@@ -281,11 +273,13 @@ void refresh_qimage( mlt_frame frame, int width, int height )
                mlt_properties_set_int( cached_props, "height", self->current_height );
                mlt_properties_set_int( cached_props, "real_width", mlt_properties_get_int( producer_props, "_real_width" ) );
                mlt_properties_set_int( cached_props, "real_height", mlt_properties_get_int( producer_props, "_real_height" ) );
-               mlt_properties_set_data( cached_props, "image", self->current_image, self->current_width * ( self->current_height + 1 ) * 2, mlt_pool_release, NULL );
-               mlt_properties_set_data( cached_props, "alpha", self->current_alpha, self->current_width * self->current_height, mlt_pool_release, NULL );
+               mlt_properties_set_data( cached_props, "image", self->current_image,
+                       self->current_width * ( self->current_height + 1 ) * ( self->has_alpha ? 4 : 3 ),
+                       mlt_pool_release, NULL );
+               mlt_properties_set_int( cached_props, "alpha", self->has_alpha );
                mlt_properties_set_data( cache, image_key, cached, 0, ( mlt_destructor )mlt_frame_close, NULL );
        }
-       mutex.unlock();
-    }
+       g_mutex.unlock();
 }
 
+} // extern "C"