]> git.sesse.net Git - mlt/blobdiff - src/modules/sdl/consumer_sdl.c
Remove local references to SDL_Surface. (SF-186)
[mlt] / src / modules / sdl / consumer_sdl.c
index 38322370235bbf8aa1b26f4c4c5e8992bba79b7a..0a9926e625a3a875f872f6e4a49d121a3c5ea5cf 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * consumer_sdl.c -- A Simple DirectMedia Layer consumer
- * Copyright (C) 2003-2004 Ushodaya Enterprises Limited
+ * Copyright (C) 2003-2004, 2010 Ushodaya Enterprises Limited
  * Author: Dan Dennedy <dan@dennedy.org>
  *
  * This library is free software; you can redistribute it and/or
 #include <stdlib.h>
 #include <string.h>
 #include <pthread.h>
-#include <SDL/SDL.h>
-#include <SDL/SDL_syswm.h>
+#include <SDL.h>
+#include <SDL_syswm.h>
 #include <sys/time.h>
+#include "consumer_sdl_osx.h"
+
+extern pthread_mutex_t mlt_sdl_mutex;
 
 /** This classes definition.
 */
@@ -59,12 +62,10 @@ struct consumer_sdl_s
        int height;
        int playing;
        int sdl_flags;
-       SDL_Surface *sdl_screen;
        SDL_Overlay *sdl_overlay;
        SDL_Rect rect;
        uint8_t *buffer;
        int bpp;
-       int filtered;
 };
 
 /** Forward references to static functions.
@@ -85,7 +86,7 @@ static void consumer_sdl_event( mlt_listener listener, mlt_properties owner, mlt
 mlt_consumer consumer_sdl_init( mlt_profile profile, mlt_service_type type, const char *id, char *arg )
 {
        // Create the consumer object
-       consumer_sdl this = calloc( sizeof( struct consumer_sdl_s ), 1 );
+       consumer_sdl this = calloc( 1, sizeof( struct consumer_sdl_s ) );
 
        // If no malloc'd and consumer init ok
        if ( this != NULL && mlt_consumer_init( &this->parent, this, profile ) == 0 )
@@ -114,26 +115,34 @@ mlt_consumer consumer_sdl_init( mlt_profile profile, mlt_service_type type, cons
                
                // Default scaler (for now we'll use nearest)
                mlt_properties_set( this->properties, "rescale", "nearest" );
+               mlt_properties_set( this->properties, "deinterlace_method", "onefield" );
+               mlt_properties_set_int( this->properties, "top_field_first", -1 );
 
                // Default buffer for low latency
                mlt_properties_set_int( this->properties, "buffer", 1 );
 
                // Default audio buffer
-               mlt_properties_set_int( this->properties, "audio_buffer", 512 );
+               mlt_properties_set_int( this->properties, "audio_buffer", 2048 );
 
                // Ensure we don't join on a non-running object
                this->joined = 1;
                
                // process actual param
-               if ( arg == NULL || sscanf( arg, "%dx%d", &this->width, &this->height ) != 2 )
+               if ( arg && sscanf( arg, "%dx%d", &this->width, &this->height ) )
+               {
+                       mlt_properties_set_int( this->properties, "_arg_size", 1 );
+               }
+               else
                {
                        this->width = mlt_properties_get_int( this->properties, "width" );
                        this->height = mlt_properties_get_int( this->properties, "height" );
                }
-
+       
                // Set the sdl flags
-               this->sdl_flags = SDL_HWSURFACE | SDL_ASYNCBLIT | SDL_HWACCEL | SDL_RESIZABLE | SDL_DOUBLEBUF;
-
+               this->sdl_flags = SDL_HWSURFACE | SDL_ASYNCBLIT | SDL_HWACCEL | SDL_DOUBLEBUF;
+#if !defined(__DARWIN__)
+               this->sdl_flags |= SDL_RESIZABLE;
+#endif         
                // Allow thread to be started/stopped
                parent->start = consumer_start;
                parent->stop = consumer_stop;
@@ -165,74 +174,96 @@ int consumer_start( mlt_consumer parent )
 
        if ( !this->running )
        {
-               int video_off = mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( parent ), "video_off" );
-               int preview_off = mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( parent ), "preview_off" );
+               mlt_properties properties = MLT_CONSUMER_PROPERTIES( parent );
+               int video_off = mlt_properties_get_int( properties, "video_off" );
+               int preview_off = mlt_properties_get_int( properties, "preview_off" );
                int display_off = video_off | preview_off;
-               int audio_off = mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( parent ), "audio_off" );
-               int sdl_started = mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( parent ), "sdl_started" );
+               int audio_off = mlt_properties_get_int( properties, "audio_off" );
+               int sdl_started = mlt_properties_get_int( properties, "sdl_started" );
+               char *output_display = mlt_properties_get( properties, "output_display" );
+               char *window_id = mlt_properties_get( properties, "window_id" );
+               char *audio_driver = mlt_properties_get( properties, "audio_driver" );
+               char *video_driver = mlt_properties_get( properties, "video_driver" );
+               char *audio_device = mlt_properties_get( properties, "audio_device" );
 
                consumer_stop( parent );
 
                this->running = 1;
                this->joined = 0;
 
-               if ( mlt_properties_get_int( this->properties, "width" ) > 0 )
-                       this->width = mlt_properties_get_int( this->properties, "width" );
-               if ( mlt_properties_get_int( this->properties, "height" ) > 0 )
-                       this->height = mlt_properties_get_int( this->properties, "height" );
+               if ( output_display != NULL )
+                       setenv( "DISPLAY", output_display, 1 );
 
-               this->bpp = mlt_properties_get_int( this->properties, "bpp" );
+               if ( window_id != NULL )
+                       setenv( "SDL_WINDOWID", window_id, 1 );
+
+               if ( video_driver != NULL )
+                       setenv( "SDL_VIDEODRIVER", video_driver, 1 );
+
+               if ( audio_driver != NULL )
+                       setenv( "SDL_AUDIODRIVER", audio_driver, 1 );
 
-               // Attach a colour space converter
-               if ( preview_off && !this->filtered )
+               if ( audio_device != NULL )
+                       setenv( "AUDIODEV", audio_device, 1 );
+
+               if ( ! mlt_properties_get_int( this->properties, "_arg_size" ) )
                {
-                       mlt_profile profile = mlt_service_profile( MLT_CONSUMER_SERVICE( parent ) );
-                       mlt_filter filter = mlt_factory_filter( profile, "avcolour_space", NULL );
-                       if ( filter )
-                       {
-                               mlt_properties_set_int( MLT_FILTER_PROPERTIES( filter ), "forced", mlt_image_yuv422 );
-                               mlt_service_attach( MLT_CONSUMER_SERVICE( parent ), filter );
-                               mlt_filter_close( filter );
-                       }
-                       this->filtered = 1;
+                       if ( mlt_properties_get_int( this->properties, "width" ) > 0 )
+                               this->width = mlt_properties_get_int( this->properties, "width" );
+                       if ( mlt_properties_get_int( this->properties, "height" ) > 0 )
+                               this->height = mlt_properties_get_int( this->properties, "height" );
                }
-       
+
+               this->bpp = mlt_properties_get_int( this->properties, "bpp" );
+
                if ( sdl_started == 0 && display_off == 0 )
                {
-                       if ( SDL_Init( SDL_INIT_VIDEO | SDL_INIT_NOPARACHUTE ) < 0 )
+                       pthread_mutex_lock( &mlt_sdl_mutex );
+                       int ret = SDL_Init( SDL_INIT_VIDEO | SDL_INIT_NOPARACHUTE );
+                       pthread_mutex_unlock( &mlt_sdl_mutex );
+                       if ( ret < 0 )
                        {
-                               fprintf( stderr, "Failed to initialize SDL: %s\n", SDL_GetError() );
+                               mlt_log_error( MLT_CONSUMER_SERVICE(parent), "Failed to initialize SDL: %s\n", SDL_GetError() );
                                return -1;
                        }
 
                        SDL_EnableKeyRepeat( SDL_DEFAULT_REPEAT_DELAY, SDL_DEFAULT_REPEAT_INTERVAL );
                        SDL_EnableUNICODE( 1 );
                }
-               else if ( display_off == 0 )
-               {
-                       this->sdl_screen = SDL_GetVideoSurface( );
-               }
 
                if ( audio_off == 0 )
                        SDL_InitSubSystem( SDL_INIT_AUDIO );
 
                // Default window size
-               double display_ratio = mlt_properties_get_double( this->properties, "display_ratio" );
-               this->window_width = ( double )this->height * display_ratio;
-               this->window_height = this->height;
+               if ( mlt_properties_get_int( this->properties, "_arg_size" ) )
+               {
+                       this->window_width = this->width;
+                       this->window_height = this->height;
+               }
+               else
+               {
+                       double display_ratio = mlt_properties_get_double( this->properties, "display_ratio" );
+                       this->window_width = ( double )this->height * display_ratio + 0.5;
+                       this->window_height = this->height;
+               }
 
-               if ( this->sdl_screen == NULL && display_off == 0 )
+               pthread_mutex_lock( &mlt_sdl_mutex );
+               if ( !SDL_GetVideoSurface() && display_off == 0 )
                {
                        if ( mlt_properties_get_int( this->properties, "fullscreen" ) )
                        {
-                               const SDL_VideoInfo *vi = SDL_GetVideoInfo();
+                               const SDL_VideoInfo *vi;
+                               pthread_mutex_lock( &mlt_sdl_mutex );
+                               vi = SDL_GetVideoInfo();
+                               pthread_mutex_unlock( &mlt_sdl_mutex );
                                this->window_width = vi->current_w;
                                this->window_height = vi->current_h;
                                this->sdl_flags |= SDL_FULLSCREEN;
                                SDL_ShowCursor( SDL_DISABLE );
                        }
-                       this->sdl_screen = SDL_SetVideoMode( this->window_width, this->window_height, 0, this->sdl_flags );
+                       SDL_SetVideoMode( this->window_width, this->window_height, 0, this->sdl_flags );
                }
+               pthread_mutex_unlock( &mlt_sdl_mutex );
 
                pthread_create( &this->thread, NULL, consumer_thread, this );
        }
@@ -250,7 +281,9 @@ int consumer_stop( mlt_consumer parent )
                // Kill the thread and clean up
                this->joined = 1;
                this->running = 0;
+#ifndef WIN32
                if ( this->thread )
+#endif
                        pthread_join( this->thread, NULL );
 
                // internal cleanup
@@ -267,9 +300,11 @@ int consumer_stop( mlt_consumer parent )
                }
 
                if ( mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( parent ), "sdl_started" ) == 0 )
+               {
+                       pthread_mutex_lock( &mlt_sdl_mutex );
                        SDL_Quit( );
-
-               this->sdl_screen = NULL;
+                       pthread_mutex_unlock( &mlt_sdl_mutex );
+               }
        }
 
        return 0;
@@ -283,15 +318,20 @@ int consumer_is_stopped( mlt_consumer parent )
 
 static int sdl_lock_display( )
 {
+       pthread_mutex_lock( &mlt_sdl_mutex );
        SDL_Surface *screen = SDL_GetVideoSurface( );
-       return screen != NULL && ( !SDL_MUSTLOCK( screen ) || SDL_LockSurface( screen ) >= 0 );
+       int result = screen != NULL && ( !SDL_MUSTLOCK( screen ) || SDL_LockSurface( screen ) >= 0 );
+       pthread_mutex_unlock( &mlt_sdl_mutex );
+       return result;
 }
 
 static void sdl_unlock_display( )
 {
+       pthread_mutex_lock( &mlt_sdl_mutex );
        SDL_Surface *screen = SDL_GetVideoSurface( );
        if ( screen != NULL && SDL_MUSTLOCK( screen ) )
                SDL_UnlockSurface( screen );
+       pthread_mutex_unlock( &mlt_sdl_mutex );
 }
 
 static void sdl_fill_audio( void *udata, uint8_t *stream, int len )
@@ -344,10 +384,11 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
 {
        // Get the properties of this consumer
        mlt_properties properties = this->properties;
-       mlt_audio_format afmt = mlt_audio_pcm;
+       mlt_audio_format afmt = mlt_audio_s16;
 
        // Set the preferred params of the test card signal
        int channels = mlt_properties_get_int( properties, "channels" );
+       int dest_channels = channels;
        int frequency = mlt_properties_get_int( properties, "frequency" );
        static int counter = 0;
 
@@ -356,8 +397,9 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
        int16_t *pcm;
        int bytes;
 
-       mlt_frame_get_audio( frame, &pcm, &afmt, &frequency, &channels, &samples );
+       mlt_frame_get_audio( frame, (void**) &pcm, &afmt, &frequency, &channels, &samples );
        *duration = ( ( samples * 1000 ) / frequency );
+       pcm += mlt_properties_get_int( properties, "audio_offset" );
 
        if ( mlt_properties_get_int( properties, "audio_off" ) )
        {
@@ -378,7 +420,7 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
                this->playing = 0;
                request.freq = frequency;
                request.format = AUDIO_S16SYS;
-               request.channels = channels;
+               request.channels = dest_channels;
                request.samples = audio_buffer;
                request.callback = sdl_fill_audio;
                request.userdata = (void *)this;
@@ -397,16 +439,36 @@ static int consumer_play_audio( consumer_sdl this, mlt_frame frame, int init_aud
        if ( init_audio == 0 )
        {
                mlt_properties properties = MLT_FRAME_PROPERTIES( frame );
-               bytes = ( samples * channels * 2 );
+               
+               bytes = samples * dest_channels * sizeof(*pcm);
                pthread_mutex_lock( &this->audio_mutex );
                while ( this->running && bytes > ( sizeof( this->audio_buffer) - this->audio_avail ) )
                        pthread_cond_wait( &this->audio_cond, &this->audio_mutex );
                if ( this->running )
                {
                        if ( mlt_properties_get_double( properties, "_speed" ) == 1 )
-                               memcpy( &this->audio_buffer[ this->audio_avail ], pcm, bytes );
+                       {
+                               if ( channels == dest_channels )
+                               {
+                                       memcpy( &this->audio_buffer[ this->audio_avail ], pcm, bytes );
+                               }
+                               else
+                               {
+                                       int16_t *dest = (int16_t*) &this->audio_buffer[ this->audio_avail ];
+                                       int i = samples + 1;
+                                       
+                                       while ( --i )
+                                       {
+                                               memcpy( dest, pcm, dest_channels * sizeof(*pcm) );
+                                               pcm += channels;
+                                               dest += dest_channels;
+                                       }
+                               }
+                       }
                        else
+                       {
                                memset( &this->audio_buffer[ this->audio_avail ], 0, bytes );
+                       }
                        this->audio_avail += bytes;
                }
                pthread_cond_broadcast( &this->audio_cond );
@@ -439,16 +501,18 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame )
        {
                // Get the image, width and height
                mlt_frame_get_image( frame, &image, &vfmt, &width, &height, 0 );
-               mlt_properties_set_int( MLT_FRAME_PROPERTIES( frame ), "format", vfmt );
-               mlt_events_fire( properties, "consumer-frame-show", frame, NULL );
                
+               void *pool = mlt_cocoa_autorelease_init();
+
                // Handle events
-               if ( this->sdl_screen != NULL )
+               if ( SDL_GetVideoSurface() )
                {
                        SDL_Event event;
        
                        sdl_lock_display( );
+                       pthread_mutex_lock( &mlt_sdl_mutex );
                        changed = consumer_get_dimensions( &this->window_width, &this->window_height );
+                       pthread_mutex_unlock( &mlt_sdl_mutex );
                        sdl_unlock_display( );
 
                        while ( SDL_PollEvent( &event ) )
@@ -490,7 +554,7 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame )
                        this->sdl_overlay = NULL;
                }
 
-               if ( this->running && ( this->sdl_screen == NULL || changed ) )
+               if ( this->running && ( !SDL_GetVideoSurface() || changed ) )
                {
                        // Force an overlay recreation
                        if ( this->sdl_overlay != NULL )
@@ -498,13 +562,17 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame )
                        this->sdl_overlay = NULL;
 
                        // open SDL window with video overlay, if possible
-                       this->sdl_screen = SDL_SetVideoMode( this->window_width, this->window_height, this->bpp, this->sdl_flags );
-                       if ( consumer_get_dimensions( &this->window_width, &this->window_height ) )
-                               this->sdl_screen = SDL_SetVideoMode( this->window_width, this->window_height, this->bpp, this->sdl_flags );
+                       pthread_mutex_lock( &mlt_sdl_mutex );
+                       consumer_get_dimensions( &this->window_width, &this->window_height );
+                       SDL_Surface *screen = SDL_SetVideoMode( this->window_width, this->window_height, this->bpp, this->sdl_flags );
+                       pthread_mutex_unlock( &mlt_sdl_mutex );
 
-                       uint32_t color = mlt_properties_get_int( this->properties, "window_background" );
-                       SDL_FillRect( this->sdl_screen, NULL, color >> 8 );
-                       SDL_Flip( this->sdl_screen );
+                       if ( screen )
+                       {
+                               uint32_t color = mlt_properties_get_int( this->properties, "window_background" );
+                               SDL_FillRect( screen, NULL, color >> 8 );
+                               SDL_Flip( screen );
+                       }
                }
 
                if ( this->running )
@@ -563,16 +631,16 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame )
                        mlt_properties_set_int( this->properties, "rect_w", this->rect.w );
                        mlt_properties_set_int( this->properties, "rect_h", this->rect.h );
 
-                       SDL_SetClipRect( this->sdl_screen, &this->rect );
+                       SDL_SetClipRect( SDL_GetVideoSurface(), &this->rect );
                }
 
-               if ( this->running && this->sdl_screen != NULL && this->sdl_overlay == NULL )
+               if ( this->running && SDL_GetVideoSurface() && this->sdl_overlay == NULL )
                {
-                       SDL_SetClipRect( this->sdl_screen, &this->rect );
-                       this->sdl_overlay = SDL_CreateYUVOverlay( width, height, SDL_YUY2_OVERLAY, this->sdl_screen );
+                       SDL_SetClipRect( SDL_GetVideoSurface(), &this->rect );
+                       this->sdl_overlay = SDL_CreateYUVOverlay( width, height, SDL_YUY2_OVERLAY, SDL_GetVideoSurface() );
                }
 
-               if ( this->running && this->sdl_screen != NULL && this->sdl_overlay != NULL )
+               if ( this->running && SDL_GetVideoSurface() && this->sdl_overlay != NULL )
                {
                        this->buffer = this->sdl_overlay->pixels[ 0 ];
                        if ( SDL_LockYUVOverlay( this->sdl_overlay ) >= 0 )
@@ -580,18 +648,19 @@ static int consumer_play_video( consumer_sdl this, mlt_frame frame )
                                if ( image != NULL )
                                        memcpy( this->buffer, image, width * height * 2 );
                                SDL_UnlockYUVOverlay( this->sdl_overlay );
-                               SDL_DisplayYUVOverlay( this->sdl_overlay, &this->sdl_screen->clip_rect );
+                               SDL_DisplayYUVOverlay( this->sdl_overlay, &SDL_GetVideoSurface()->clip_rect );
                        }
                }
 
                sdl_unlock_display();
+               mlt_cocoa_autorelease_close( pool );
+               mlt_events_fire( properties, "consumer-frame-show", frame, NULL );
        }
        else if ( this->running )
        {
                vfmt = preview_format == mlt_image_none ? mlt_image_rgb24a : preview_format;
                if ( !video_off )
                        mlt_frame_get_image( frame, &image, &vfmt, &width, &height, 0 );
-               mlt_properties_set_int( MLT_FRAME_PROPERTIES( frame ), "format", vfmt );
                mlt_events_fire( properties, "consumer-frame-show", frame, NULL );
        }
 
@@ -675,6 +744,11 @@ static void *video_thread( void *arg )
                                start = ( ( int64_t )now.tv_sec * 1000000 + now.tv_usec ) - scheduled + 20000;
                        }
                }
+               else
+               {
+                       static int dropped = 0;
+                       mlt_log_info( MLT_CONSUMER_SERVICE(&this->parent), "dropped video frame %d\n", ++dropped );
+               }
 
                // This frame can now be closed
                mlt_frame_close( next );
@@ -711,27 +785,23 @@ static void *consumer_thread( void *arg )
        int init_audio = 1;
        int init_video = 1;
        mlt_frame frame = NULL;
-       mlt_properties properties = NULL;
        int duration = 0;
        int64_t playtime = 0;
        struct timespec tm = { 0, 100000 };
 
        // Loop until told not to
-       while( !terminated && this->running )
+       while( this->running )
        {
                // Get a frame from the attached producer
-               frame = mlt_consumer_rt_frame( consumer );
+               frame = !terminated? mlt_consumer_rt_frame( consumer ) : NULL;
 
                // Check for termination
-               if ( terminate_on_pause && frame != NULL )
+               if ( terminate_on_pause && frame )
                        terminated = mlt_properties_get_double( MLT_FRAME_PROPERTIES( frame ), "_speed" ) == 0.0;
 
                // Ensure that we have a frame
-               if ( frame != NULL )
+               if ( frame )
                {
-                       // Get the frame properties
-                       properties =  MLT_FRAME_PROPERTIES( frame );
-
                        // Play audio
                        init_audio = consumer_play_audio( this, frame, init_audio, &duration );
 
@@ -746,7 +816,7 @@ static void *consumer_thread( void *arg )
                        }
 
                        // Set playtime for this frame
-                       mlt_properties_set_int( properties, "playtime", playtime );
+                       mlt_properties_set_int( MLT_FRAME_PROPERTIES( frame ), "playtime", playtime );
 
                        while ( this->running && mlt_deque_count( this->queue ) > 15 )
                                nanosleep( &tm, NULL );
@@ -760,9 +830,25 @@ static void *consumer_thread( void *arg )
                        // Calculate the next playtime
                        playtime += ( duration * 1000 );
                }
+               else if ( terminated )
+               {
+                       if ( init_video || mlt_deque_count( this->queue ) == 0 )
+                               break;
+                       else
+                               nanosleep( &tm, NULL );
+               }
        }
 
        this->running = 0;
+       
+       // Unblock sdl_preview
+       if ( mlt_properties_get_int( MLT_CONSUMER_PROPERTIES( consumer ), "put_mode" ) == 1 )
+       {
+               frame = mlt_consumer_get_frame( consumer );
+               if ( frame )
+                       mlt_frame_close( frame );
+               frame = NULL;
+       }
 
        // Kill the video thread
        if ( init_video == 0 )
@@ -776,7 +862,6 @@ static void *consumer_thread( void *arg )
        while( mlt_deque_count( this->queue ) )
                mlt_frame_close( mlt_deque_pop_back( this->queue ) );
 
-       this->sdl_screen = NULL;
        this->audio_avail = 0;
 
        return NULL;
@@ -799,6 +884,7 @@ static int consumer_get_dimensions( int *width, int *height )
        // Get the wm structure
        if ( SDL_GetWMInfo( &wm ) == 1 )
        {
+#ifndef WIN32
                // Check that we have the X11 wm
                if ( wm.subsystem == SDL_SYSWM_X11 ) 
                {
@@ -819,6 +905,7 @@ static int consumer_get_dimensions( int *width, int *height )
                        *width = attr.width;
                        *height = attr.height;
                }
+#endif
        }
 #endif