]> git.sesse.net Git - vlc/blobdiff - src/playlist/control.c
herm, "attachment://" is 13 characters, not 15
[vlc] / src / playlist / control.c
index c0a89c2a10d9b28b07fb1d65cd598dc8cc269f51..880bdfde79b494524184be300e20b06dff8abcc7 100644 (file)
@@ -2,7 +2,7 @@
  * control.c : Handle control of the playlist & running through it
  *****************************************************************************
  * Copyright (C) 1999-2004 the VideoLAN team
- * $Id: /local/vlc/0.8.6-playlist-vlm/src/playlist/playlist.c 13741 2006-03-21T19:29:39.792444Z zorglub  $
+ * $Id$
  *
  * Authors: Samuel Hocevar <sam@zoy.org>
  *          ClĂ©ment Stenac <zorglub@videolan.org>
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
 #include <vlc/vlc.h>
 #include "vlc_playlist.h"
 #include "playlist_internal.h"
@@ -118,14 +122,6 @@ static int PlaylistVAControl( playlist_t * p_playlist, int i_query, va_list args
         }
         break;
 
-    case PLAYLIST_AUTOPLAY:
-        // AUTOPLAY is an ugly hack for initial status.
-        // Hopefully it will disappear
-        p_playlist->status.i_status = PLAYLIST_RUNNING;
-        p_playlist->request.p_node = p_playlist->status.p_node;
-        p_playlist->request.b_request = VLC_FALSE;
-        break;
-
     case PLAYLIST_PAUSE:
         val.i_int = 0;
         if( p_playlist->p_input )
@@ -184,8 +180,8 @@ int playlist_PreparseEnqueue( playlist_t *p_playlist,
                  p_playlist->p_preparse->i_waiting,
                  p_playlist->p_preparse->i_waiting,
                  p_item );
-    vlc_mutex_unlock( &p_playlist->p_preparse->object_lock );
     vlc_cond_signal( &p_playlist->p_preparse->object_wait );
+    vlc_mutex_unlock( &p_playlist->p_preparse->object_lock );
     return VLC_SUCCESS;
 }
 
@@ -210,7 +206,7 @@ int playlist_AskForArtEnqueue( playlist_t *p_playlist,
     p.p_item = p_item;
     p.b_fetch_art = VLC_TRUE;
 
-    vlc_mutex_lock( &p_playlist->p_fetcher->object_lock );
+    vlc_object_lock( p_playlist->p_fetcher );
     for( i = 0; i < p_playlist->p_fetcher->i_waiting &&
          p_playlist->p_fetcher->p_waiting->b_fetch_art == VLC_TRUE;
          i++ );
@@ -218,8 +214,8 @@ int playlist_AskForArtEnqueue( playlist_t *p_playlist,
     INSERT_ELEM( p_playlist->p_fetcher->p_waiting,
                  p_playlist->p_fetcher->i_waiting,
                  i, p );
-    vlc_mutex_unlock( &p_playlist->p_fetcher->object_lock );
-    vlc_cond_signal( &p_playlist->p_fetcher->object_wait );
+    vlc_object_signal_unlocked( p_playlist->p_fetcher );
+    vlc_obj_unlock( p_playlist->p_fetcher );
     return VLC_SUCCESS;
 }
 
@@ -248,21 +244,29 @@ static void PreparseEnqueueItemSub( playlist_t *p_playlist,
  * Playback logic
  *****************************************************************************/
 
-static void ResyncCurrentIndex(playlist_t *p_playlist, playlist_item_t *p_cur )
+/**
+ * Synchronise the current index of the playlist
+ * to match the index of the current item.
+ *
+ * \param p_playlist the playlist structure
+ * \param p_cur the current playlist item
+ * \return nothing
+ */
+static void ResyncCurrentIndex( playlist_t *p_playlist, playlist_item_t *p_cur )
 {
-     PL_DEBUG("resyncing on %s", PLI_NAME(p_cur) );
+     PL_DEBUG( "resyncing on %s", PLI_NAME( p_cur ) );
      /* Simply resync index */
      int i;
      p_playlist->i_current_index = -1;
      for( i = 0 ; i< p_playlist->current.i_size; i++ )
      {
-          if( ARRAY_VAL(p_playlist->current, i) == p_cur )
+          if( ARRAY_VAL( p_playlist->current, i ) == p_cur )
           {
               p_playlist->i_current_index = i;
               break;
           }
      }
-     PL_DEBUG("%s is at %i", PLI_NAME(p_cur), p_playlist->i_current_index );
+     PL_DEBUG( "%s is at %i", PLI_NAME( p_cur ), p_playlist->i_current_index );
 }
 
 void ResetCurrentlyPlaying( playlist_t *p_playlist, vlc_bool_t b_random,
@@ -271,9 +275,9 @@ void ResetCurrentlyPlaying( playlist_t *p_playlist, vlc_bool_t b_random,
     playlist_item_t *p_next = NULL;
     stats_TimerStart( p_playlist, "Items array build",
                       STATS_TIMER_PLAYLIST_BUILD );
-    PL_DEBUG("rebuilding array of current - root %s",
-              PLI_NAME(p_playlist->status.p_node) );
-    ARRAY_RESET(p_playlist->current);
+    PL_DEBUG( "rebuilding array of current - root %s",
+              PLI_NAME( p_playlist->status.p_node ) );
+    ARRAY_RESET( p_playlist->current );
     p_playlist->i_current_index = -1;
     while( 1 )
     {
@@ -295,13 +299,12 @@ void ResetCurrentlyPlaying( playlist_t *p_playlist, vlc_bool_t b_random,
     {
         /* Shuffle the array */
         srand( (unsigned int)mdate() );
-        int swap = 0;
         int j;
         for( j = p_playlist->current.i_size - 1; j > 0; j-- )
         {
-            swap++;
             int i = rand() % (j+1); /* between 0 and j */
             playlist_item_t *p_tmp;
+            /* swap the two items */
             p_tmp = ARRAY_VAL(p_playlist->current, i);
             ARRAY_VAL(p_playlist->current,i) = ARRAY_VAL(p_playlist->current,j);
             ARRAY_VAL(p_playlist->current,j) = p_tmp;
@@ -311,8 +314,13 @@ void ResetCurrentlyPlaying( playlist_t *p_playlist, vlc_bool_t b_random,
     stats_TimerStop( p_playlist, STATS_TIMER_PLAYLIST_BUILD );
 }
 
-/** This function calculates the next playlist item, depending
- *  on the playlist course mode (forward, backward, random, view,...). */
+/**
+ * Compute the next playlist item depending on
+ * the playlist course mode (forward, backward, random, view,...).
+ *
+ * \param p_playlist the playlist object
+ * \return nothing
+ */
 playlist_item_t * playlist_NextItem( playlist_t *p_playlist )
 {
     playlist_item_t *p_new = NULL;
@@ -340,7 +348,7 @@ playlist_item_t * playlist_NextItem( playlist_t *p_playlist )
     }
     if( !p_playlist->request.b_request && b_playstop == VLC_TRUE )
     {
-        msg_Dbg( p_playlist,"stopping (play and stop)");
+        msg_Dbg( p_playlist,"stopping (play and stop)" );
         return NULL;
     }
 
@@ -374,7 +382,7 @@ playlist_item_t * playlist_NextItem( playlist_t *p_playlist )
             p_playlist->b_reset_currently_playing = VLC_TRUE;
         }
 
-        /* If we are asked for a node, dont take it */
+        /* If we are asked for a node, don't take it */
         if( i_skip == 0 && ( p_new == NULL || p_new->i_children != -1 ) )
             i_skip++;
 
@@ -386,12 +394,14 @@ playlist_item_t * playlist_NextItem( playlist_t *p_playlist )
         else
             p_playlist->i_current_index = -1;
 
-        if( p_playlist->current.i_size && i_skip > 0 )
+        if( p_playlist->current.i_size && (i_skip > 0) )
         {
+            if( p_playlist->i_current_index < -1 )
+                p_playlist->i_current_index = -1;
             for( i = i_skip; i > 0 ; i-- )
             {
                 p_playlist->i_current_index++;
-                if( p_playlist->i_current_index == p_playlist->current.i_size )
+                if( p_playlist->i_current_index >= p_playlist->current.i_size )
                 {
                     PL_DEBUG( "looping - restarting at beginning of node" );
                     p_playlist->i_current_index = 0;
@@ -400,12 +410,12 @@ playlist_item_t * playlist_NextItem( playlist_t *p_playlist )
             p_new = ARRAY_VAL( p_playlist->current,
                                p_playlist->i_current_index );
         }
-        else if( p_playlist->current.i_size && i_skip < 0 )
+        else if( p_playlist->current.i_size && (i_skip < 0) )
         {
             for( i = i_skip; i < 0 ; i++ )
             {
                 p_playlist->i_current_index--;
-                if( p_playlist->i_current_index == -1 )
+                if( p_playlist->i_current_index <= -1 )
                 {
                     PL_DEBUG( "looping - restarting at end of node" );
                     p_playlist->i_current_index = p_playlist->current.i_size-1;
@@ -448,12 +458,18 @@ playlist_item_t * playlist_NextItem( playlist_t *p_playlist )
     return p_new;
 }
 
-/** Start the input for an item */
+/**
+ * Start the input for an item
+ *
+ * \param p_playlist the playlist objetc
+ * \param p_item the item to play
+ * \return nothing
+ */
 int playlist_PlayItem( playlist_t *p_playlist, playlist_item_t *p_item )
 {
     vlc_value_t val;
     input_item_t *p_input = p_item->p_input;
-    int i_activity = var_GetInteger( p_playlist, "activity") ;
+    int i_activity = var_GetInteger( p_playlist, "activity" ) ;
 
     msg_Dbg( p_playlist, "creating new input thread" );
 
@@ -466,7 +482,17 @@ int playlist_PlayItem( playlist_t *p_playlist, playlist_item_t *p_item )
                     DEFAULT_INPUT_ACTIVITY );
     p_playlist->p_input = input_CreateThread( p_playlist, p_input );
 
-    if( p_playlist->p_fetcher->i_art_policy == ALBUM_ART_WHEN_PLAYED )
+    char *psz_uri = input_item_GetURI( p_item->p_input );
+    if( psz_uri && ( !strncmp( psz_uri, "directory:", 10 ) ||
+                     !strncmp( psz_uri, "vlc:", 4 ) ) )
+    {
+        free( psz_uri );
+        return VLC_SUCCESS;
+    }
+    free( psz_uri );
+
+    if( p_playlist->p_fetcher &&
+            p_playlist->p_fetcher->i_art_policy == ALBUM_ART_WHEN_PLAYED )
     {
         vlc_bool_t b_has_art;
 
@@ -474,10 +500,10 @@ int playlist_PlayItem( playlist_t *p_playlist, playlist_item_t *p_item )
         psz_arturl = input_item_GetArtURL( p_input );
         psz_name = input_item_GetName( p_input );
 
-        /* p_input->p_meta should not be null after a successfull CreateThread*/
+        /* p_input->p_meta should not be null after a successfull CreateThread */
         b_has_art = !EMPTY_STR( psz_arturl );
 
-        if( !b_has_art )
+        if( !b_has_art || strncmp( psz_arturl, "attachment://", 13 ) )
         {
             PL_DEBUG( "requesting art for %s", psz_name );
             playlist_AskForArtEnqueue( p_playlist, p_input );
@@ -487,9 +513,9 @@ int playlist_PlayItem( playlist_t *p_playlist, playlist_item_t *p_item )
     }
 
     val.i_int = p_input->i_id;
-    vlc_mutex_unlock( &p_playlist->object_lock);
-    var_Set( p_playlist, "playlist-current", val);
-    vlc_mutex_lock( &p_playlist->object_lock);
+    PL_UNLOCK;
+    var_Set( p_playlist, "playlist-current", val );
+    PL_LOCK;
 
     return VLC_SUCCESS;
 }