]> git.sesse.net Git - vlc/blobdiff - src/playlist/playlist.c
Don't print debug messages and don't do interaction on preparsing
[vlc] / src / playlist / playlist.c
index 5ec7a705dffb4267795255a91a91eb1c3729b27d..bde17ab55b84535e64fa111bea195e1f1b38e67d 100644 (file)
@@ -19,7 +19,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 #include <stdlib.h>                                      /* free(), strtol() */
 #include <stdio.h>                                              /* sprintf() */
@@ -32,6 +32,8 @@
 
 #include "vlc_playlist.h"
 
+#include "vlc_interaction.h"
+
 #define TITLE_CATEGORY N_( "By category" )
 #define TITLE_SIMPLE   N_( "Manually added" )
 #define TITLE_ALL      N_( "All items, unsorted" )
@@ -47,9 +49,6 @@ static void RunPreparse( playlist_preparse_t * );
 static playlist_item_t * NextItem  ( playlist_t * );
 static int PlayItem  ( playlist_t *, playlist_item_t * );
 
-static int ItemChange( vlc_object_t *, const char *,
-                       vlc_value_t, vlc_value_t, void * );
-
 int playlist_vaControl( playlist_t * p_playlist, int i_query, va_list args );
 
 void playlist_PreparseEnqueueItemSub( playlist_t *, playlist_item_t * );
@@ -197,8 +196,12 @@ playlist_t * __playlist_Create ( vlc_object_t *p_parent )
         return NULL;
     }
 
+    // Preparse
     p_playlist->p_preparse->i_waiting = 0;
-    p_playlist->p_preparse->pp_waiting = NULL;
+    p_playlist->p_preparse->pi_waiting = NULL;
+
+    // Interaction
+    p_playlist->p_interaction = NULL;
 
     vlc_object_attach( p_playlist->p_preparse, p_playlist );
     if( vlc_thread_create( p_playlist->p_preparse, "preparser",
@@ -234,6 +237,11 @@ int playlist_Destroy( playlist_t * p_playlist )
                                           p_playlist->pp_sds[0]->psz_module );
     }
 
+    if( p_playlist->p_interaction )
+    {
+        intf_InteractionDestroy( p_playlist->p_interaction );
+    }
+
     vlc_thread_join( p_playlist->p_preparse );
     vlc_thread_join( p_playlist );
 
@@ -364,8 +372,8 @@ int playlist_vaControl( playlist_t * p_playlist, int i_query, va_list args )
         i_view = (int)va_arg( args,int );
         p_node = (playlist_item_t *)va_arg( args, playlist_item_t * );
         p_item = (playlist_item_t *)va_arg( args, playlist_item_t * );
-        if ( p_node == NULL || (p_item != NULL && p_item->input.psz_uri
-                                                         == NULL ))
+        if ( p_node == NULL ) //|| (p_item != NULL && p_item->input.psz_uri
+                                //                         == NULL ))
         {
             p_playlist->status.i_status = PLAYLIST_STOPPED;
             p_playlist->request.b_request = VLC_TRUE;
@@ -378,10 +386,8 @@ int playlist_vaControl( playlist_t * p_playlist, int i_query, va_list args )
         p_playlist->request.p_node = p_node;
         p_playlist->request.p_item = p_item;
 
-        /* If we select a node, play only it.
-         * If we select an item, continue */
-        if( p_playlist->request.p_item == NULL ||
-            ! p_playlist->request.p_node->i_flags & PLAYLIST_SKIP_FLAG )
+        /* Don't go further if the node doesn't want to */
+        if( ! p_playlist->request.p_node->i_flags & PLAYLIST_SKIP_FLAG )
         {
             p_playlist->b_go_next = VLC_FALSE;
         }
@@ -405,13 +411,14 @@ int playlist_vaControl( playlist_t * p_playlist, int i_query, va_list args )
         p_playlist->request.b_request = VLC_TRUE;
         p_playlist->request.i_view = p_playlist->status.i_view;
         p_playlist->request.p_node = p_playlist->status.p_node;
-        p_playlist->request.p_item = p_playlist->status.p_item = NULL;
+        p_playlist->request.p_item = p_playlist->status.p_item;
         p_playlist->request.i_skip = 0;
         p_playlist->request.i_goto = -1;
         break;
 
     case PLAYLIST_AUTOPLAY:
         p_playlist->status.i_status = PLAYLIST_RUNNING;
+        p_playlist->status.p_node = p_playlist->p_general;
 
         p_playlist->request.b_request = VLC_FALSE;
         break;
@@ -442,12 +449,17 @@ int playlist_vaControl( playlist_t * p_playlist, int i_query, va_list args )
         break;
 
     case PLAYLIST_SKIP:
+        p_playlist->request.i_view = p_playlist->status.i_view;
         if( p_playlist->status.i_view > -1 )
         {
-            p_playlist->request.i_view = p_playlist->status.i_view;
             p_playlist->request.p_node = p_playlist->status.p_node;
             p_playlist->request.p_item = p_playlist->status.p_item;
         }
+        else
+        {
+            p_playlist->request.p_node = NULL;
+            p_playlist->request.p_item = NULL;
+        }
         p_playlist->request.i_skip = (int) va_arg( args, int );
         p_playlist->request.b_request = VLC_TRUE;
         break;
@@ -462,7 +474,7 @@ int playlist_vaControl( playlist_t * p_playlist, int i_query, va_list args )
         break;
 
     default:
-        msg_Err( p_playlist, "unimplemented playlist query" );
+        msg_Err( p_playlist, "unknown playlist query" );
         return VLC_EBADVAR;
         break;
     }
@@ -474,10 +486,10 @@ int playlist_PreparseEnqueue( playlist_t *p_playlist,
                               input_item_t *p_item )
 {
     vlc_mutex_lock( &p_playlist->p_preparse->object_lock );
-    INSERT_ELEM( p_playlist->p_preparse->pp_waiting,
+    INSERT_ELEM( p_playlist->p_preparse->pi_waiting,
                  p_playlist->p_preparse->i_waiting,
                  p_playlist->p_preparse->i_waiting,
-                 p_item );
+                 p_item->i_id );
     vlc_mutex_unlock( &p_playlist->p_preparse->object_lock );
     return VLC_SUCCESS;
 }
@@ -489,10 +501,10 @@ void playlist_PreparseEnqueueItemSub( playlist_t *p_playlist,
     int i;
     if( p_item->i_children == -1 )
     {
-        INSERT_ELEM( p_playlist->p_preparse->pp_waiting,
+        INSERT_ELEM( p_playlist->p_preparse->pi_waiting,
                      p_playlist->p_preparse->i_waiting,
                      p_playlist->p_preparse->i_waiting,
-                     &(p_item->input) );
+                     (p_item->input.i_id) );
     }
     else
     {
@@ -569,6 +581,8 @@ static void RunThread ( playlist_t *p_playlist )
     mtime_t    i_vout_destroyed_date = 0;
     mtime_t    i_sout_destroyed_date = 0;
 
+    int i_loops = 0;
+
     playlist_item_t *p_autodelete_item = NULL;
 
     /* Tell above that we're ready */
@@ -576,6 +590,14 @@ static void RunThread ( playlist_t *p_playlist )
 
     while( !p_playlist->b_die )
     {
+        i_loops++;
+        if( p_playlist->p_interaction )
+        {
+            stats_TimerStart( p_playlist, "Interaction thread" );
+            intf_InteractionManage( p_playlist );
+            stats_TimerStop( p_playlist, "Interaction thread" );
+        }
+
         vlc_mutex_lock( &p_playlist->object_lock );
 
         /* First, check if we have something to do */
@@ -601,6 +623,14 @@ static void RunThread ( playlist_t *p_playlist )
         /* If there is an input, check that it doesn't need to die. */
         if( p_playlist->p_input )
         {
+            if( i_loops % 5 == 0 )
+            {
+                stats_ComputeInputStats( p_playlist->p_input,
+                                  p_playlist->p_input->input.p_item->p_stats );
+//                stats_DumpInputStats(
+//                            p_playlist->p_input->input.p_item->p_stats );
+            }
+
             /* This input is dead. Remove it ! */
             if( p_playlist->p_input->b_dead )
             {
@@ -672,8 +702,9 @@ static void RunThread ( playlist_t *p_playlist )
         {
             /* Start another input.
              * Get the next item to play */
+            stats_TimerStart( p_playlist, "Playlist walk" );
             p_item = NextItem( p_playlist );
-
+            stats_TimerStop( p_playlist, "Playlist walk" );
 
             /* We must stop */
             if( p_item == NULL )
@@ -699,6 +730,13 @@ static void RunThread ( playlist_t *p_playlist )
         }
         else if( p_playlist->status.i_status == PLAYLIST_STOPPED )
         {
+            if( p_item && p_playlist->status.p_item &&
+                p_playlist->status.p_item->i_flags & PLAYLIST_REMOVE_FLAG )
+            {
+                 playlist_ItemDelete( p_item );
+                 p_playlist->status.p_item = NULL;
+            }
+
             /* Collect garbage */
             vlc_mutex_unlock( &p_playlist->object_lock );
             i_sout_destroyed_date =
@@ -808,11 +846,39 @@ static void RunPreparse ( playlist_preparse_t *p_obj )
 
         if( p_obj->i_waiting > 0 )
         {
-            input_item_t *p_current = p_obj->pp_waiting[0];
-            REMOVE_ELEM( p_obj->pp_waiting, p_obj->i_waiting, 0 );
+            int i_current_id = p_obj->pi_waiting[0];
+            playlist_item_t *p_current;
+            REMOVE_ELEM( p_obj->pi_waiting, p_obj->i_waiting, 0 );
             vlc_mutex_unlock( &p_obj->object_lock );
-            input_Preparse( p_playlist, p_current );
-            var_SetInteger( p_playlist, "item-change", p_current->i_id );
+            vlc_mutex_lock( &p_playlist->object_lock );
+
+            p_current = playlist_ItemGetById( p_playlist, i_current_id );
+            if( p_current )
+            {
+                vlc_bool_t b_preparsed = VLC_FALSE;
+                if( strncmp( p_current->input.psz_uri, "http:", 5 ) &&
+                    strncmp( p_current->input.psz_uri, "rtsp:", 5 ) &&
+                    strncmp( p_current->input.psz_uri, "udp:", 4 ) &&
+                    strncmp( p_current->input.psz_uri, "mms:", 4 ) &&
+                    strncmp( p_current->input.psz_uri, "cdda:", 4 ) &&
+                    strncmp( p_current->input.psz_uri, "dvd:", 4 ) &&
+                    strncmp( p_current->input.psz_uri, "v4l:", 4 ) &&
+                    strncmp( p_current->input.psz_uri, "dshow:", 6 ) )
+                {
+                    b_preparsed = VLC_TRUE;
+                    stats_TimerStart( p_playlist, "Preparse run" );
+                    input_Preparse( p_playlist, &p_current->input );
+                    stats_TimerStop( p_playlist, "Preparse run" );
+                }
+                vlc_mutex_unlock( &p_playlist->object_lock );
+                if( b_preparsed )
+                {
+                    var_SetInteger( p_playlist, "item-change",
+                                    p_current->input.i_id );
+                }
+            }
+            else
+                vlc_mutex_unlock( &p_playlist->object_lock );
             vlc_mutex_lock( &p_obj->object_lock );
         }
         b_sleep = ( p_obj->i_waiting == 0 );
@@ -847,7 +913,6 @@ static playlist_item_t * NextItem( playlist_t *p_playlist )
     /* Calculate time needed */
     int64_t start = mdate();
 #endif
-
     /* Handle quickly a few special cases */
 
     /* No items to play */
@@ -863,7 +928,8 @@ static playlist_item_t * NextItem( playlist_t *p_playlist )
     }
 
     /* Repeat and play/stop */
-    if( !p_playlist->request.b_request && b_repeat == VLC_TRUE )
+    if( !p_playlist->request.b_request && b_repeat == VLC_TRUE &&
+         p_playlist->status.p_item )
     {
         msg_Dbg( p_playlist,"repeating item" );
         return p_playlist->status.p_item;
@@ -886,31 +952,41 @@ static playlist_item_t * NextItem( playlist_t *p_playlist )
     /* TODO: use the "shuffled view" internally ? */
     /* Random case. This is an exception: if request, but request is skip +- 1
      * we don't go to next item but select a new random one. */
-    if( b_random && (!p_playlist->request.b_request ||
-        p_playlist->request.i_skip == 1 || p_playlist->request.i_skip == -1 ) )
+    if( b_random &&
+        ( !p_playlist->request.b_request ||
+        ( p_playlist->request.b_request && ( p_playlist->request.p_item == NULL ||
+          p_playlist->request.i_skip == 1 || p_playlist->request.i_skip == -1 ) ) ) )
     {
-        srand( (unsigned int)mdate() );
-        i_new = 0;
-        for( i_count = 0; i_count < p_playlist->i_size - 1 ; i_count ++ )
+        /* how many items to choose from ? */
+        i_count = 0;
+        for ( i = 0; i < p_playlist->i_size; i++ )
         {
-            i_new =
-                (int)((float)p_playlist->i_size * rand() / (RAND_MAX+1.0));
-            /* Check if the item has not already been played */
-            if( p_playlist->pp_items[i_new]->i_nb_played == 0 )
-                break;
+            if ( p_playlist->pp_items[i]->i_nb_played == 0 )
+                i_count++;
         }
-        if( i_count == p_playlist->i_size )
+        /* Nothing left? */
+        if ( i_count == 0 )
         {
-            /* The whole playlist has been played: reset the counters */
-            while( i_count > 0 )
-            {
-                p_playlist->pp_items[--i_count]->i_nb_played = 0;
-            }
+            /* Don't loop? Exit! */
             if( !b_loop )
-            {
                 return NULL;
+            /* Otherwise reset the counter */
+            for ( i = 0; i < p_playlist->i_size; i++ )
+            {
+                p_playlist->pp_items[i]->i_nb_played = 0;
             }
+            i_count = p_playlist->i_size;
+        }
+        srand( (unsigned int)mdate() );
+        i = rand() % i_count + 1 ;
+        /* loop thru the list and count down the unplayed items to the selected one */
+        for ( i_new = 0; i_new < p_playlist->i_size && i > 0; i_new++ )
+        {
+            if ( p_playlist->pp_items[i_new]->i_nb_played == 0 )
+                i--;
         }
+        i_new--;
+
         p_playlist->request.i_skip = 0;
         p_playlist->request.b_request = VLC_FALSE;
         return p_playlist->pp_items[i_new];
@@ -954,6 +1030,10 @@ static playlist_item_t * NextItem( playlist_t *p_playlist )
                 }
                 p_playlist->request.i_skip = 0;
             }
+            if( !( p_new->i_flags & PLAYLIST_SKIP_FLAG ) )
+            {
+                return NULL;
+            }
         }
         else
         {
@@ -1106,6 +1186,7 @@ static playlist_item_t * NextItem( playlist_t *p_playlist )
     {
         msg_Info( p_playlist, "nothing to play" );
     }
+
     return p_new;
 }
 
@@ -1134,9 +1215,6 @@ static int PlayItem( playlist_t *p_playlist, playlist_item_t *p_item )
 
     p_playlist->p_input = input_CreateThread( p_playlist, &p_item->input );
 
-    var_AddCallback( p_playlist->p_input, "item-change",
-                         ItemChange, p_playlist );
-
     val.i_int = p_item->input.i_id;
     /* unlock the playlist to set the var...mmm */
     vlc_mutex_unlock( &p_playlist->object_lock);
@@ -1146,19 +1224,3 @@ static int PlayItem( playlist_t *p_playlist, playlist_item_t *p_item )
     return VLC_SUCCESS;
 
 }
-
-/* Forward item change from input */
-static int ItemChange( vlc_object_t *p_obj, const char *psz_var,
-                       vlc_value_t oldval, vlc_value_t newval, void *param )
-{
-    playlist_t *p_playlist = (playlist_t *)param;
-
-    //p_playlist->b_need_update = VLC_TRUE;
-    var_SetInteger( p_playlist, "item-change", newval.i_int );
-
-    /* Update view */
-    /* FIXME: Make that automatic */
-//    playlist_ViewUpdate( p_playlist, VIEW_S_AUTHOR );
-
-    return VLC_SUCCESS;
-}