return true;
Color us = side_to_move();
- Color them = opposite_color(us);
Square from = move_from(m);
Square ksq = king_square(us);
// after the move is made
if (move_is_ep(m))
{
+ Color them = opposite_color(us);
Square to = move_to(m);
Square capsq = make_square(square_file(to), square_rank(from));
Bitboard b = occupied_squares();
// If the moving piece is a king, check whether the destination
// square is attacked by the opponent.
if (from == ksq)
- return !(square_is_attacked(move_to(m), them));
+ return !(square_is_attacked(move_to(m), opposite_color(us)));
// A non-king move is legal if and only if it is not pinned or it
// is moving along the ray towards or away from the king.
- return ( !bit_is_set(pinned, from)
+ return ( !pinned
+ || !bit_is_set(pinned, from)
|| (direction_between_squares(from, ksq) == direction_between_squares(move_to(m), ksq)));
}
if (bit_is_set(pawn_attacks(them, ksq), to)) // Normal check?
return true;
- if ( bit_is_set(dcCandidates, from) // Discovered check?
+ if ( dcCandidates // Discovered check?
+ && bit_is_set(dcCandidates, from)
&& (direction_between_squares(from, ksq) != direction_between_squares(to, ksq)))
return true;
}
return false;
+ // Test discovered check and normal check according to piece type
case KNIGHT:
- return bit_is_set(dcCandidates, from) // Discovered check?
- || bit_is_set(piece_attacks<KNIGHT>(ksq), to); // Normal check?
+ return (dcCandidates && bit_is_set(dcCandidates, from))
+ || bit_is_set(piece_attacks<KNIGHT>(ksq), to);
case BISHOP:
- return bit_is_set(dcCandidates, from) // Discovered check?
- || bit_is_set(piece_attacks<BISHOP>(ksq), to); // Normal check?
+ return (dcCandidates && bit_is_set(dcCandidates, from))
+ || ( direction_between_squares(ksq, to) != DIR_NONE
+ && bit_is_set(piece_attacks<BISHOP>(ksq), to));
case ROOK:
- return bit_is_set(dcCandidates, from) // Discovered check?
- || bit_is_set(piece_attacks<ROOK>(ksq), to); // Normal check?
+ return (dcCandidates && bit_is_set(dcCandidates, from))
+ || ( direction_between_squares(ksq, to) != DIR_NONE
+ && bit_is_set(piece_attacks<ROOK>(ksq), to));
case QUEEN:
// Discovered checks are impossible!
assert(!bit_is_set(dcCandidates, from));
- return bit_is_set(piece_attacks<QUEEN>(ksq), to); // Normal check?
+ return ( direction_between_squares(ksq, to) != DIR_NONE
+ && bit_is_set(piece_attacks<QUEEN>(ksq), to));
case KING:
// Discovered check?