improve document checker

[kdenlive] / src / profilesdialog.cpp

diff --git a/src/profilesdialog.cpp b/src/profilesdialog.cpp
index 2b7af87d4daafbda8c88e01660043ba89e25662e..69da96089d2bf32f08fe566ec62f7566c93bf594 100644 (file)
--- a/src/profilesdialog.cpp
+++ b/src/profilesdialog.cpp
@@ -17,18 +17,22 @@
  *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA          *
  ***************************************************************************/
 
-#include <QDir>
-#include <QCloseEvent>
+#include "profilesdialog.h"
+#include "kdenlivesettings.h"
 
 #include <KStandardDirs>
 #include <KDebug>
 #include <KMessageBox>
 #include <KIO/NetAccess>
 
-#include "kdenlivesettings.h"
-#include "profilesdialog.h"
+#include <QDir>
+#include <QCloseEvent>
 
-ProfilesDialog::ProfilesDialog(QWidget * parent): QDialog(parent), m_isCustomProfile(false), m_profileIsModified(false) {
+ProfilesDialog::ProfilesDialog(QWidget * parent) :
+        QDialog(parent),
+        m_profileIsModified(false),
+        m_isCustomProfile(false)
+{
     m_view.setupUi(this);
 
     QStringList profilesFilter;
@@ -61,11 +65,13 @@ ProfilesDialog::ProfilesDialog(QWidget * parent): QDialog(parent), m_isCustomPro
     connect(m_view.size_w, SIGNAL(valueChanged(int)), this, SLOT(slotProfileEdited()));
 }
 
-void ProfilesDialog::slotProfileEdited() {
+void ProfilesDialog::slotProfileEdited()
+{
     m_profileIsModified = true;
 }
 
-void ProfilesDialog::fillList(const QString selectedProfile) {
+void ProfilesDialog::fillList(const QString selectedProfile)
+{
     // List the Mlt profiles
     m_view.profiles_list->clear();
     QMap <QString, QString> profilesInfo = ProfilesDialog::getProfilesInfo();
@@ -88,11 +94,13 @@ void ProfilesDialog::fillList(const QString selectedProfile) {
     m_selectedProfileIndex = m_view.profiles_list->currentIndex();
 }
 
-void ProfilesDialog::accept() {
+void ProfilesDialog::accept()
+{
     if (askForSave()) QDialog::accept();
 }
 
-void ProfilesDialog::closeEvent(QCloseEvent *event) {
+void ProfilesDialog::closeEvent(QCloseEvent *event)
+{
     if (askForSave()) {
         event->accept();
     } else {
@@ -100,32 +108,36 @@ void ProfilesDialog::closeEvent(QCloseEvent *event) {
     }
 }
 
-bool ProfilesDialog::askForSave() {
+bool ProfilesDialog::askForSave()
+{
     if (!m_profileIsModified) return true;
-    if (KMessageBox::questionYesNo(this, i18n("The custom profile was modified, do you want to save it ?")) != KMessageBox::Yes) return true;
+    if (KMessageBox::questionYesNo(this, i18n("The custom profile was modified, do you want to save it?")) != KMessageBox::Yes) return true;
     return slotSaveProfile();
 }
 
-void ProfilesDialog::slotCreateProfile() {
+void ProfilesDialog::slotCreateProfile()
+{
     m_view.button_delete->setEnabled(false);
     m_view.button_create->setEnabled(false);
     m_view.button_save->setEnabled(true);
     m_view.properties->setEnabled(true);
 }
 
-void ProfilesDialog::slotSetDefaultProfile() {
+void ProfilesDialog::slotSetDefaultProfile()
+{
     int ix = m_view.profiles_list->currentIndex();
     QString path = m_view.profiles_list->itemData(ix).toString();
     if (!path.isEmpty()) KdenliveSettings::setDefault_profile(path);
 }
 
-bool ProfilesDialog::slotSaveProfile() {
+bool ProfilesDialog::slotSaveProfile()
+{
     const QString profileDesc = m_view.description->text();
     int ix = m_view.profiles_list->findText(profileDesc);
     if (ix != -1) {
         // this profile name already exists
         const QString path = m_view.profiles_list->itemData(ix).toString();
-        if (!path.contains("/")) {
+        if (!path.contains('/')) {
             KMessageBox::sorry(this, i18n("A profile with same name already exists in MLT's default profiles, please choose another description for your custom profile."));
             return false;
         }
@@ -147,7 +159,8 @@ bool ProfilesDialog::slotSaveProfile() {
     return true;
 }
 
-void ProfilesDialog::saveProfile(const QString path) {
+void ProfilesDialog::saveProfile(const QString path)
+{
     QFile file(path);
     if (!file.open(QIODevice::WriteOnly)) {
         KMessageBox::sorry(this, i18n("Cannot write to file %1", path));
@@ -155,19 +168,24 @@ void ProfilesDialog::saveProfile(const QString path) {
     }
     QTextStream out(&file);
     out << "description=" << m_view.description->text() << "\n" << "frame_rate_num=" << m_view.frame_num->value() << "\n" << "frame_rate_den=" << m_view.frame_den->value() << "\n" << "width=" << m_view.size_w->value() << "\n" << "height=" << m_view.size_h->value() << "\n" << "progressive=" << m_view.progressive->isChecked() << "\n" << "sample_aspect_num=" << m_view.aspect_num->value() << "\n" << "sample_aspect_den=" << m_view.aspect_den->value() << "\n" << "display_aspect_num=" << m_view.display_num->value() << "\n" << "display_aspect_den=" << m_view.display_den->value() << "\n";
+    if (file.error() != QFile::NoError) {
+        KMessageBox::error(this, i18n("Cannot write to file %1", path));
+    }
     file.close();
 }
 
-void ProfilesDialog::slotDeleteProfile() {
+void ProfilesDialog::slotDeleteProfile()
+{
     const QString path = m_view.profiles_list->itemData(m_view.profiles_list->currentIndex()).toString();
-    if (path.contains("/")) {
+    if (path.contains('/')) {
         KIO::NetAccess::del(KUrl(path), this);
         fillList();
     } else kDebug() << "//// Cannot delete profile " << path << ", does not seem to be custom one";
 }
 
 // static
-MltVideoProfile ProfilesDialog::getVideoProfile(QString name) {
+MltVideoProfile ProfilesDialog::getVideoProfile(QString name)
+{
     MltVideoProfile result;
     QStringList profilesNames;
     QStringList profilesFiles;
@@ -180,7 +198,7 @@ MltVideoProfile ProfilesDialog::getVideoProfile(QString name) {
     if (!isCustom) {
         // List the Mlt profiles
         profilesFiles = QDir(KdenliveSettings::mltpath()).entryList(profilesFilter, QDir::Files);
-        if (profilesFiles.contains(name)) path = KdenliveSettings::mltpath() + "/" + name;
+        if (profilesFiles.contains(name)) path = KdenliveSettings::mltpath() + '/' + name;
     }
     if (isCustom  || path.isEmpty()) {
         path = name;
@@ -211,7 +229,8 @@ MltVideoProfile ProfilesDialog::getVideoProfile(QString name) {
 }
 
 // static
-QString ProfilesDialog::getProfileDescription(QString name) {
+QString ProfilesDialog::getProfileDescription(QString name)
+{
     QStringList profilesNames;
     QStringList profilesFiles;
     QStringList profilesFilter;
@@ -220,7 +239,7 @@ QString ProfilesDialog::getProfileDescription(QString name) {
     // List the Mlt profiles
     profilesFiles = QDir(KdenliveSettings::mltpath()).entryList(profilesFilter, QDir::Files);
     if (profilesFiles.contains(name)) {
-        KConfig confFile(KdenliveSettings::mltpath() + "/" + name, KConfig::SimpleConfig);
+        KConfig confFile(KdenliveSettings::mltpath() + '/' + name, KConfig::SimpleConfig);
         return confFile.entryMap().value("description");
     }
 
@@ -229,7 +248,7 @@ QString ProfilesDialog::getProfileDescription(QString name) {
     for (int i = 0; i < customProfiles.size(); ++i) {
         profilesFiles = QDir(customProfiles.at(i)).entryList(profilesFilter, QDir::Files);
         if (profilesFiles.contains(name)) {
-            KConfig confFile(customProfiles.at(i) + "/" + name, KConfig::SimpleConfig);
+            KConfig confFile(customProfiles.at(i) + '/' + name, KConfig::SimpleConfig);
             return confFile.entryMap().value("description");
         }
     }
@@ -238,7 +257,8 @@ QString ProfilesDialog::getProfileDescription(QString name) {
 }
 
 // static
-QMap <QString, QString> ProfilesDialog::getProfilesInfo() {
+QMap <QString, QString> ProfilesDialog::getProfilesInfo()
+{
     QMap <QString, QString> result;
     QStringList profilesFilter;
     profilesFilter << "*";
@@ -246,7 +266,7 @@ QMap <QString, QString> ProfilesDialog::getProfilesInfo() {
     // List the Mlt profiles
     QStringList profilesFiles = QDir(KdenliveSettings::mltpath()).entryList(profilesFilter, QDir::Files);
     for (int i = 0; i < profilesFiles.size(); ++i) {
-        KConfig confFile(KdenliveSettings::mltpath() + "/" + profilesFiles.at(i), KConfig::SimpleConfig);
+        KConfig confFile(KdenliveSettings::mltpath() + '/' + profilesFiles.at(i), KConfig::SimpleConfig);
         QString desc = confFile.entryMap().value("description");
         if (!desc.isEmpty()) result.insert(desc, profilesFiles.at(i));
     }
@@ -256,24 +276,25 @@ QMap <QString, QString> ProfilesDialog::getProfilesInfo() {
     for (int i = 0; i < customProfiles.size(); ++i) {
         profilesFiles = QDir(customProfiles.at(i)).entryList(profilesFilter, QDir::Files);
         for (int j = 0; j < profilesFiles.size(); ++j) {
-            KConfig confFile(customProfiles.at(i) + "/" + profilesFiles.at(j), KConfig::SimpleConfig);
+            KConfig confFile(customProfiles.at(i) + '/' + profilesFiles.at(j), KConfig::SimpleConfig);
             QString desc = confFile.entryMap().value("description");
-            if (!desc.isEmpty()) result.insert(desc, customProfiles.at(i) + "/" + profilesFiles.at(j));
+            if (!desc.isEmpty()) result.insert(desc, customProfiles.at(i) + '/' + profilesFiles.at(j));
         }
     }
     return result;
 }
 
 // static
-QMap< QString, QString > ProfilesDialog::getSettingsFromFile(const QString path) {
+QMap< QString, QString > ProfilesDialog::getSettingsFromFile(const QString path)
+{
     QStringList profilesNames;
     QStringList profilesFiles;
     QStringList profilesFilter;
     profilesFilter << "*";
 
-    if (!path.contains("/")) {
+    if (!path.contains('/')) {
         // This is an MLT profile
-        KConfig confFile(KdenliveSettings::mltpath() + "/" + path, KConfig::SimpleConfig);
+        KConfig confFile(KdenliveSettings::mltpath() + '/' + path, KConfig::SimpleConfig);
         return confFile.entryMap();
     } else {
         // This is a custom profile
@@ -283,7 +304,8 @@ QMap< QString, QString > ProfilesDialog::getSettingsFromFile(const QString path)
 }
 
 // static
-QMap< QString, QString > ProfilesDialog::getSettingsForProfile(const QString profileName) {
+QMap< QString, QString > ProfilesDialog::getSettingsForProfile(const QString profileName)
+{
     QStringList profilesNames;
     QStringList profilesFiles;
     QStringList profilesFilter;
@@ -292,7 +314,7 @@ QMap< QString, QString > ProfilesDialog::getSettingsForProfile(const QString pro
     // List the Mlt profiles
     profilesFiles = QDir(KdenliveSettings::mltpath()).entryList(profilesFilter, QDir::Files);
     for (int i = 0; i < profilesFiles.size(); ++i) {
-        KConfig confFile(KdenliveSettings::mltpath() + "/" + profilesFiles.at(i), KConfig::SimpleConfig);
+        KConfig confFile(KdenliveSettings::mltpath() + '/' + profilesFiles.at(i), KConfig::SimpleConfig);
         QMap< QString, QString > values = confFile.entryMap();
         if (values.value("description") == profileName) {
             values.insert("path", profilesFiles.at(i));
@@ -305,10 +327,10 @@ QMap< QString, QString > ProfilesDialog::getSettingsForProfile(const QString pro
     for (int i = 0; i < customProfiles.size(); ++i) {
         QStringList profiles = QDir(customProfiles.at(i)).entryList(profilesFilter, QDir::Files);
         for (int i = 0; i < profiles.size(); ++i) {
-            KConfig confFile(customProfiles.at(i) + "/" + profiles.at(i), KConfig::SimpleConfig);
+            KConfig confFile(customProfiles.at(i) + '/' + profiles.at(i), KConfig::SimpleConfig);
             QMap< QString, QString > values = confFile.entryMap();
             if (values.value("description") == profileName) {
-                values.insert("path", customProfiles.at(i) + "/" + profiles.at(i));
+                values.insert("path", customProfiles.at(i) + '/' + profiles.at(i));
                 return values;
             }
         }
@@ -317,7 +339,8 @@ QMap< QString, QString > ProfilesDialog::getSettingsForProfile(const QString pro
 }
 
 // static
-QString ProfilesDialog::getPathFromDescription(const QString profileDesc) {
+QString ProfilesDialog::getPathFromDescription(const QString profileDesc)
+{
     QStringList profilesNames;
     QStringList profilesFiles;
     QStringList profilesFilter;
@@ -326,7 +349,7 @@ QString ProfilesDialog::getPathFromDescription(const QString profileDesc) {
     // List the Mlt profiles
     profilesFiles = QDir(KdenliveSettings::mltpath()).entryList(profilesFilter, QDir::Files);
     for (int i = 0; i < profilesFiles.size(); ++i) {
-        KConfig confFile(KdenliveSettings::mltpath() + "/" + profilesFiles.at(i), KConfig::SimpleConfig);
+        KConfig confFile(KdenliveSettings::mltpath() + '/' + profilesFiles.at(i), KConfig::SimpleConfig);
         QMap< QString, QString > values = confFile.entryMap();
         if (values.value("description") == profileDesc) return profilesFiles.at(i);
     }
@@ -336,16 +359,17 @@ QString ProfilesDialog::getPathFromDescription(const QString profileDesc) {
     for (int i = 0; i < customProfiles.size(); ++i) {
         QStringList profiles = QDir(customProfiles.at(i)).entryList(profilesFilter, QDir::Files);
         for (int i = 0; i < profiles.size(); ++i) {
-            KConfig confFile(customProfiles.at(i) + "/" + profiles.at(i), KConfig::SimpleConfig);
+            KConfig confFile(customProfiles.at(i) + '/' + profiles.at(i), KConfig::SimpleConfig);
             QMap< QString, QString > values = confFile.entryMap();
-            if (values.value("description") == profileDesc) return customProfiles.at(i) + "/" + profiles.at(i);
+            if (values.value("description") == profileDesc) return customProfiles.at(i) + '/' + profiles.at(i);
         }
     }
     return QString();
 }
 
 
-void ProfilesDialog::slotUpdateDisplay() {
+void ProfilesDialog::slotUpdateDisplay()
+{
     if (askForSave() == false) {
         m_view.profiles_list->blockSignals(true);
         m_view.profiles_list->setCurrentIndex(m_selectedProfileIndex);
@@ -355,7 +379,7 @@ void ProfilesDialog::slotUpdateDisplay() {
 
     m_selectedProfileIndex = m_view.profiles_list->currentIndex();
     QString currentProfile = m_view.profiles_list->itemData(m_view.profiles_list->currentIndex()).toString();
-    m_isCustomProfile = currentProfile.contains("/");
+    m_isCustomProfile = currentProfile.contains('/');
     m_view.button_delete->setEnabled(m_isCustomProfile);
     m_view.properties->setEnabled(m_isCustomProfile);
     m_view.button_save->setEnabled(m_isCustomProfile);