Fix LADSPA effects, should work now:

[kdenlive] / src / renderwidget.cpp

diff --git a/src/renderwidget.cpp b/src/renderwidget.cpp
index d6c9474c26c56c9485a5ebdb965c5fb5c2ec0f34..01069f5e8182a69ca50a216801c8275c6d8d0036 100644 (file)
--- a/src/renderwidget.cpp
+++ b/src/renderwidget.cpp
@@ -55,6 +55,10 @@ RenderWidget::RenderWidget(QWidget * parent): QDialog(parent) {
         m_view.buttonInfo->setDown(true);
     } else m_view.advanced_params->hide();
 
+    m_view.experimentalrender->setChecked(KdenliveSettings::experimentalrender());
+
+    m_view.experimentalrender->setToolTip(i18n("Changing the size of video when rendering\nis not fully supported, you may have problems\nwith some effects or title clips, so the export\nprofiles that resize your video are marked as\nexperimental"));
+
     connect(m_view.buttonInfo, SIGNAL(clicked()), this, SLOT(showInfoPanel()));
 
     connect(m_view.buttonSave, SIGNAL(clicked()), this, SLOT(slotSaveProfile()));
@@ -73,6 +77,7 @@ RenderWidget::RenderWidget(QWidget * parent): QDialog(parent) {
     connect(m_view.guide_start, SIGNAL(activated(int)), this, SLOT(slotCheckEndGuidePosition()));
 
     connect(m_view.format_selection, SIGNAL(activated(int)), this, SLOT(refreshView()));
+    connect(m_view.experimentalrender, SIGNAL(stateChanged(int)), this, SLOT(slotUpdateExperimentalRendering()));
 
     m_view.buttonStart->setEnabled(false);
     m_view.guides_box->setVisible(false);
@@ -83,6 +88,12 @@ RenderWidget::RenderWidget(QWidget * parent): QDialog(parent) {
     focusFirstVisibleItem();
 }
 
+void RenderWidget::slotUpdateExperimentalRendering() {
+    KdenliveSettings::setExperimentalrender(m_view.experimentalrender->isChecked());
+    refreshView();
+}
+
+
 void RenderWidget::showInfoPanel() {
     if (m_view.advanced_params->isVisible()) {
         m_view.advanced_params->setVisible(false);
@@ -328,8 +339,29 @@ void RenderWidget::slotDeleteProfile() {
     focusFirstVisibleItem();
 }
 
+void RenderWidget::updateButtons() {
+    if (!m_view.size_list->currentItem() || m_view.size_list->currentItem()->isHidden()) {
+        m_view.buttonSave->setEnabled(false);
+        m_view.buttonDelete->setEnabled(false);
+        m_view.buttonEdit->setEnabled(false);
+    } else {
+        m_view.buttonSave->setEnabled(true);
+        if (m_view.size_list->currentItem()->data(EditableRole).toString().isEmpty()) {
+            m_view.buttonDelete->setEnabled(false);
+            m_view.buttonEdit->setEnabled(false);
+        } else {
+            m_view.buttonDelete->setEnabled(true);
+            m_view.buttonEdit->setEnabled(true);
+        }
+    }
+}
+
+
 void RenderWidget::focusFirstVisibleItem() {
-    if (m_view.size_list->currentItem() && !m_view.size_list->currentItem()->isHidden()) return;
+    if (m_view.size_list->currentItem() && !m_view.size_list->currentItem()->isHidden()) {
+        updateButtons();
+        return;
+    }
     for (uint ix = 0; ix < m_view.size_list->count(); ix++) {
         QListWidgetItem *item = m_view.size_list->item(ix);
         if (item && !item->isHidden()) {
@@ -338,6 +370,7 @@ void RenderWidget::focusFirstVisibleItem() {
         }
     }
     if (!m_view.size_list->currentItem()) m_view.size_list->setCurrentRow(0);
+    updateButtons();
 }
 
 void RenderWidget::slotExport() {
@@ -361,17 +394,26 @@ void RenderWidget::slotExport() {
         startPos = m_view.guide_start->itemData(m_view.guide_start->currentIndex()).toDouble();
         endPos = m_view.guide_end->itemData(m_view.guide_end->currentIndex()).toDouble();
     }
-    emit doRender(m_view.out_file->url().path(), item->data(RenderRole).toString(), overlayargs, m_view.advanced_params->toPlainText().split(' '), m_view.render_zone->isChecked(), m_view.play_after->isChecked(), startPos, endPos);
+    QString renderArgs = m_view.advanced_params->toPlainText();
+    renderArgs.replace("%width", QString::number(m_profile.width));
+    renderArgs.replace("%height", QString::number(m_profile.height));
+    renderArgs.replace("%dar", "@" + QString::number(m_profile.display_aspect_num) + "/" + QString::number(m_profile.display_aspect_den));
+    if (m_view.force_progressive->checkState() == Qt::Checked) renderArgs.append(" progressive=1");
+    else if (m_view.force_progressive->checkState() == Qt::Unchecked) renderArgs.append(" progressive=0");
+    emit doRender(m_view.out_file->url().path(), item->data(RenderRole).toString(), overlayargs, renderArgs.simplified().split(' '), m_view.render_zone->isChecked(), m_view.play_after->isChecked(), startPos, endPos);
 }
 
-void RenderWidget::setDocumentStandard(QString std) {
-    if (std == "PAL") m_view.format_selection->setCurrentIndex(0);
+void RenderWidget::setProfile(MltVideoProfile profile) {
+    m_profile = profile;
+    //WARNING: this way to tell the video standard is a bit hackish...
+    if (m_profile.description.contains("pal", Qt::CaseInsensitive) || m_profile.description.contains("25", Qt::CaseInsensitive) || m_profile.description.contains("50", Qt::CaseInsensitive)) m_view.format_selection->setCurrentIndex(0);
     else m_view.format_selection->setCurrentIndex(1);
-
+    m_view.force_progressive->setCheckState(Qt::PartiallyChecked);
     refreshView();
 }
 
 void RenderWidget::refreshView() {
+    m_view.size_list->blockSignals(true);
     QListWidgetItem *item = m_view.format_list->currentItem();
     if (!item) {
         m_view.format_list->setCurrentRow(0);
@@ -384,8 +426,8 @@ void RenderWidget::refreshView() {
     bool firstSelected = false;
     for (int i = 0; i < m_view.size_list->count(); i++) {
         sizeItem = m_view.size_list->item(i);
-        std = sizeItem->data(StandardRole).toString();
         if (sizeItem->data(GroupRole) == group) {
+            std = sizeItem->data(StandardRole).toString();
             if (!std.isEmpty()) {
                 if (std.contains("PAL", Qt::CaseInsensitive)) sizeItem->setHidden(m_view.format_selection->currentIndex() != 0);
                 else if (std.contains("NTSC", Qt::CaseInsensitive)) sizeItem->setHidden(m_view.format_selection->currentIndex() != 1);
@@ -394,15 +436,32 @@ void RenderWidget::refreshView() {
                 if (!firstSelected) m_view.size_list->setCurrentItem(sizeItem);
                 firstSelected = true;
             }
+            if (!KdenliveSettings::experimentalrender() && !sizeItem->isHidden()) {
+                // hide experimental codecs (which do resize the video)
+                std = sizeItem->data(ParamsRole).toString();
+                if (std.contains(" s=")) {
+                    QString subsize = std.section(" s=", 1, 1);
+                    subsize = subsize.section(' ', 0, 0).toLower();
+                    if (subsize != "%widthx%height") {
+                        const QString currentSize = QString::number(m_profile.width) + 'x' + QString::number(m_profile.height);
+                        if (subsize != currentSize) sizeItem->setHidden(true);
+                    }
+                }
+            }
         } else sizeItem->setHidden(true);
     }
     focusFirstVisibleItem();
-
+    m_view.size_list->blockSignals(false);
+    refreshParams();
 }
 
 void RenderWidget::refreshParams() {
     QListWidgetItem *item = m_view.size_list->currentItem();
-    if (!item) return;
+    if (!item || item->isHidden()) {
+        m_view.advanced_params->clear();
+        m_view.buttonStart->setEnabled(false);
+        return;
+    }
     QString params = item->data(ParamsRole).toString();
     QString extension = item->data(ExtensionRole).toString();
     m_view.advanced_params->setPlainText(params);
@@ -425,6 +484,7 @@ void RenderWidget::refreshParams() {
         m_view.buttonDelete->setEnabled(true);
         m_view.buttonEdit->setEnabled(true);
     }
+    m_view.buttonStart->setEnabled(true);
 }
 
 void RenderWidget::parseProfiles(QString group, QString profile) {