return alpha;
// Transposition table lookup. At PV nodes, we don't use the TT for
- // pruning, but only for move ordering.
+ // pruning, but only for move ordering. This is to avoid problems in
+ // the following areas:
+ //
+ // * Repetition draw detection
+ // * Fifty move rule detection
+ // * Searching for a mate
+ // * Printing of full PV line
+ //
tte = TT.retrieve(pos.get_key());
ttMove = (tte ? tte->move() : MOVE_NONE);
{
search_pv(pos, ss, alpha, beta, depth-2*OnePly, ply, threadID);
ttMove = ss[ply].pv[ply];
+ tte = TT.retrieve(pos.get_key());
+
+ // Following assert could fail, for instance when we have
+ // moveCount == 0 we return without saving a TT entry.
+ /* assert(tte); */
}
// Initialize a MovePicker object for the current position, and prepare
// To verify this we do a reduced search on all the other moves but the ttMove,
// if result is lower then TT value minus a margin then we assume ttMove is the
// only one playable. It is a kind of relaxed single reply extension.
- if ( depth >= 4 * OnePly
- && move == ttMove
+ // Note that could be ttMove != tte->move() due to IID, so we always use tte->move()
+ // to avoid aliases when we probe tte->depth() and tte->type()
+ if ( depth >= 8 * OnePly
+ && tte
+ && move == tte->move()
&& ext < OnePly
&& is_lower_bound(tte->type())
&& tte->depth() >= depth - 3 * OnePly)
if (abs(ttValue) < VALUE_KNOWN_WIN)
{
- Depth d = Max(Min(depth / 2, depth - 4 * OnePly), OnePly);
- Value excValue = search(pos, ss, ttValue - SingleReplyMargin, d, ply, false, threadID, ttMove);
+ Value excValue = search(pos, ss, ttValue - SingleReplyMargin, depth / 2, ply, false, threadID, ttMove);
// If search result is well below the foreseen score of the ttMove then we
// assume ttMove is the only one realistically playable and we extend it.
{
search(pos, ss, beta, Min(depth/2, depth-2*OnePly), ply, false, threadID);
ttMove = ss[ply].pv[ply];
+ tte = TT.retrieve(pos.get_key());
}
// Initialize a MovePicker object for the current position, and prepare
// To verify this we do a reduced search on all the other moves but the ttMove,
// if result is lower then TT value minus a margin then we assume ttMove is the
// only one playable. It is a kind of relaxed single reply extension.
- if ( depth >= 4 * OnePly
- && !excludedMove // do not allow recursive single-reply search
- && move == ttMove
+ // Note that could be ttMove != tte->move() due to IID, so we always use tte->move()
+ // to avoid aliases when we probe tte->depth() and tte->type()
+ if ( depth >= 8 * OnePly
+ && tte
+ && move == tte->move()
+ && !excludedMove // Do not allow recursive single-reply search
&& ext < OnePly
&& is_lower_bound(tte->type())
&& tte->depth() >= depth - 3 * OnePly)
if (abs(ttValue) < VALUE_KNOWN_WIN)
{
- Depth d = Max(Min(depth / 2, depth - 4 * OnePly), OnePly);
- Value excValue = search(pos, ss, ttValue - SingleReplyMargin, d, ply, false, threadID, ttMove);
+ Value excValue = search(pos, ss, ttValue - SingleReplyMargin, depth / 2, ply, false, threadID, ttMove);
// If search result is well below the foreseen score of the ttMove then we
// assume ttMove is the only one realistically playable and we extend it.
if (excValue < ttValue - SingleReplyMargin)
- ext = (depth >= 8 * OnePly) ? OnePly : ext + OnePly / 2;
+ ext = OnePly;
}
}