#include <stdio.h>
#include <limits.h> /* NAME_MAX */
-#if !defined(NAME_MAX) && defined(_POSIX_NAME_MAX)
-# define NAME_MAX _POSIX_NAME_MAX
-#endif
#include <errno.h>
#include <sys/types.h>
-#ifdef HAVE_DIRENT_H
-# include <dirent.h>
-#endif
+#include <dirent.h>
#ifdef HAVE_SYS_STAT_H
# include <sys/stat.h>
#endif
*
* @param dir The directory that is being read
*
- * @return a UTF-8 string of the directory entry.
- * Use free() to free this memory.
+ * @return a UTF-8 string of the directory entry. Use free() to release it.
+ * If there are no more entries in the directory, NULL is returned.
+ * If an error occurs, errno is set and NULL is returned.
*/
char *vlc_readdir( DIR *dir )
{
return FromWide (ent->d_name);
#else
+ /* Beware that readdir_r() assumes <buf> is large enough to hold the result
+ * dirent including the file name. A buffer overflow could occur otherwise.
+ * In particular, pathconf() and _POSIX_NAME_MAX cannot be used here. */
struct dirent *ent;
- struct
- {
- struct dirent ent;
- char buf[NAME_MAX + 1];
- } buf;
- int val = readdir_r (dir, &buf.ent, &ent);
- if (val)
+ char *path = NULL;
+
+ long len = fpathconf (dirfd (dir), _PC_NAME_MAX);
+ if (len == -1)
{
- errno = val;
- return NULL;
+#ifdef NAME_MAX
+ len = NAME_MAX;
+#else
+ errno = ENOMEM;
+ return NULL; // OS is broken. There is no sane way to fix this.
+#endif
}
- return ent ? vlc_fix_readdir( ent->d_name ) : NULL;
+ len += offsetof (struct dirent, d_name) + 1;
+
+ struct dirent *buf = malloc (len);
+ if (unlikely(buf == NULL))
+ return NULL;
+
+ int val = readdir_r (dir, buf, &ent);
+ if (val != 0)
+ errno = val;
+ else if (ent != NULL)
+ path = vlc_fix_readdir (ent->d_name);
+ free (buf);
+ return path;
#endif
}
int (*select)( const char * ),
int (*compar)( const char **, const char ** ) )
{
- if( select == NULL )
+ assert (dir);
+
+ if (select == NULL)
select = dummy_select;
- if( dir == NULL )
- return -1;
- else
- {
- char **tab = NULL;
- char *entry;
- unsigned num = 0;
+ char **tab = NULL;
+ unsigned num = 0;
- rewinddir( dir );
+ rewinddir (dir);
- while( ( entry = vlc_readdir( dir ) ) != NULL )
+ for (unsigned size = 0;;)
+ {
+ errno = 0;
+ char *entry = vlc_readdir (dir);
+ if (entry == NULL)
{
- char **newtab;
+ if (errno)
+ goto error;
+ break;
+ }
- if( !select( entry ) )
- {
- free( entry );
- continue;
- }
+ if (!select (entry))
+ {
+ free (entry);
+ continue;
+ }
- newtab = realloc( tab, sizeof( char * ) * (num + 1) );
- if( newtab == NULL )
+ if (num >= size)
+ {
+ size = size ? (2 * size) : 16;
+ char **newtab = realloc (tab, sizeof (*tab) * (size));
+
+ if (unlikely(newtab == NULL))
{
- free( entry );
+ free (entry);
goto error;
}
tab = newtab;
- tab[num++] = entry;
}
- if( compar != NULL )
- qsort( tab, num, sizeof( tab[0] ),
- (int (*)( const void *, const void *))compar );
-
- *namelist = tab;
- return num;
+ tab[num++] = entry;
+ }
- error:{
- unsigned i;
+ if (compar != NULL)
+ qsort (tab, num, sizeof (*tab),
+ (int (*)( const void *, const void *))compar);
+ *namelist = tab;
+ return num;
- for( i = 0; i < num; i++ )
- free( tab[i] );
- free( tab );
- }
- }
+error:
+ for (unsigned i = 0; i < num; i++)
+ free (tab[i]);
+ free (tab);
return -1;
}
}
/**
- * Finds file/inode informations, as stat().
+ * Finds file/inode information, as stat().
* Consider using fstat() instead, if possible.
*
* @param filename UTF-8 file path
}
/**
- * Finds file/inode informations, as lstat().
+ * Finds file/inode information, as lstat().
* Consider using fstat() instead, if possible.
*
* @param filename UTF-8 file path