]> git.sesse.net Git - kdenlive/blobdiff - src/trackview.cpp
small cleanup
[kdenlive] / src / trackview.cpp
index 6a53e1908b417c0e5ced113ea09a797da6103993..59ddbea1eb18f74c0e35ea177d0aa43ca8ddb49a 100644 (file)
@@ -43,8 +43,7 @@ TrackView::TrackView(KdenliveDoc *doc, QWidget *parent) :
         m_doc(doc)
 {
 
-    view = new Ui::TimeLine_UI();
-    view->setupUi(this);
+    m_view.setupUi(this);
 
     m_scene = new CustomTrackScene(doc);
     m_trackview = new CustomTrackView(doc, m_scene, parent);
@@ -55,30 +54,29 @@ TrackView::TrackView(KdenliveDoc *doc, QWidget *parent) :
     m_ruler = new CustomRuler(doc->timecode(), m_trackview);
     connect(m_ruler, SIGNAL(zoneMoved(int, int)), this, SIGNAL(zoneMoved(int, int)));
     QHBoxLayout *layout = new QHBoxLayout;
-    view->ruler_frame->setLayout(layout);
-    int left_margin;
-    int right_margin;
-    layout->getContentsMargins(&left_margin, 0, &right_margin, 0);
-    layout->setContentsMargins(left_margin, 0, right_margin, 0);
+    layout->setContentsMargins(m_trackview->frameWidth(), 0, 0, 0);
+    layout->setSpacing(0);
+    m_view.ruler_frame->setLayout(layout);
     layout->addWidget(m_ruler);
 
     QHBoxLayout *tracksLayout = new QHBoxLayout;
     tracksLayout->setContentsMargins(0, 0, 0, 0);
-    view->tracks_frame->setLayout(tracksLayout);
+    tracksLayout->setSpacing(0);
+    m_view.tracks_frame->setLayout(tracksLayout);
 
-    view->headers_area->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
-    view->headers_area->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+    m_view.headers_area->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+    m_view.headers_area->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
 
     m_headersLayout = new QVBoxLayout;
-    m_headersLayout->setContentsMargins(0, 0, 0, 0);
+    m_headersLayout->setContentsMargins(0, m_trackview->frameWidth(), 0, 0);
     m_headersLayout->setSpacing(0);
-    view->headers_container->setLayout(m_headersLayout);
+    m_view.headers_container->setLayout(m_headersLayout);
 
-    connect(view->headers_area->verticalScrollBar(), SIGNAL(valueChanged(int)), m_trackview->verticalScrollBar(), SLOT(setValue(int)));
+    connect(m_view.headers_area->verticalScrollBar(), SIGNAL(valueChanged(int)), m_trackview->verticalScrollBar(), SLOT(setValue(int)));
 
     tracksLayout->addWidget(m_trackview);
 
-    connect(m_trackview->verticalScrollBar(), SIGNAL(valueChanged(int)), view->headers_area->verticalScrollBar(), SLOT(setValue(int)));
+    connect(m_trackview->verticalScrollBar(), SIGNAL(valueChanged(int)), m_view.headers_area->verticalScrollBar(), SLOT(setValue(int)));
     connect(m_trackview, SIGNAL(trackHeightChanged()), this, SLOT(slotRebuildTrackHeaders()));
 
     parseDocument(m_doc->toXml());
@@ -405,8 +403,7 @@ void TrackView::slotRebuildTrackHeaders()
 {
     QList <TrackInfo> list = m_doc->tracksList();
     QList<HeaderTrack *> widgets = findChildren<HeaderTrack *>();
-    for (int i = 0; i < widgets.count(); i++)
-        delete widgets.at(i);
+    qDeleteAll(widgets);
     int max = list.count();
     for (int i = 0; i < max; i++) {
         HeaderTrack *header = new HeaderTrack(i, list.at(max - i - 1), this);
@@ -419,7 +416,7 @@ void TrackView::slotRebuildTrackHeaders()
         connect(header, SIGNAL(changeTrack(int)), this, SIGNAL(changeTrack(int)));
         m_headersLayout->addWidget(header);
     }
-    view->headers_container->adjustSize();
+    m_view.headers_container->adjustSize();
 }
 
 
@@ -453,6 +450,37 @@ int TrackView::slotAddProjectTrack(int ix, QDomElement xml, bool locked)
                 speed = idString.section(':', 2, 2).toDouble();
             } else id = id.section('_', 0, 0);
             DocClipBase *clip = m_doc->clipManager()->getClipById(id);
+            if (clip == NULL) {
+                // The clip in playlist was not listed in the kdenlive producers,
+                // something went wrong, repair required.
+                kWarning() << "CANNOT INSERT CLIP " << id;
+
+                clip = getMissingProducer(id);
+                if (!clip) {
+                    // We cannot find the producer, something is really wrong, add
+                    // placeholder color clip
+                    QDomDocument doc;
+                    QDomElement producerXml = doc.createElement("producer");
+                    doc.appendChild(producerXml);
+                    producerXml.setAttribute("colour", "0xff0000ff");
+                    producerXml.setAttribute("mlt_service", "colour");
+                    producerXml.setAttribute("length", "15000");
+                    producerXml.setAttribute("name", "INVALID");
+                    producerXml.setAttribute("type", COLOR);
+                    producerXml.setAttribute("id", id);
+                    clip = new DocClipBase(m_doc->clipManager(), doc.documentElement(), id);
+                    xml.insertBefore(producerXml, QDomNode());
+                    m_doc->clipManager()->addClip(clip);
+
+                    m_documentErrors.append(i18n("Broken clip producer %1", id) + '\n');
+                } else {
+                    // Found correct producer
+                    m_documentErrors.append(i18n("Replaced wrong clip producer %1 with %2", id, clip->getId()) + '\n');
+                    elem.setAttribute("producer", clip->getId());
+                }
+                m_doc->setModified(true);
+            }
+
             if (clip != NULL) {
                 ItemInfo clipinfo;
                 clipinfo.startPos = GenTime(position, m_doc->fps());
@@ -627,38 +655,6 @@ int TrackView::slotAddProjectTrack(int ix, QDomElement xml, bool locked)
                         }
                     }
                 }
-            } else {
-                // The clip in playlist was not listed in the kdenlive producers,
-                // something went wrong, repair required.
-                kWarning() << "CANNOT INSERT CLIP " << id;
-                int out = elem.attribute("out").toInt();
-
-                ItemInfo clipinfo;
-                clipinfo.startPos = GenTime(position, m_doc->fps());
-                clipinfo.endPos = clipinfo.startPos + GenTime(out - in + 1, m_doc->fps());
-                clipinfo.cropStart = GenTime(in, m_doc->fps());
-                clipinfo.track = ix;
-                //kDebug() << "// INSERTING CLIP: " << in << "x" << out << ", track: " << ix << ", ID: " << id << ", SCALE: " << m_scale << ", FPS: " << m_doc->fps();
-
-                DocClipBase *missingClip = getMissingProducer(id);
-                if (!missingClip) {
-                    // We cannot find the producer, something is really wrong, add
-                    // placeholder color clip
-                    QDomElement producerXml;
-                    producerXml.setTagName("producer");
-                    producerXml.setAttribute("resource", "0xff0000ff");
-                    producerXml.setAttribute("mlt_service", "colour");
-                    producerXml.setAttribute("length", "15000");
-                    producerXml.setAttribute("id", id);
-                    missingClip = new DocClipBase(m_doc->clipManager(), producerXml, id);
-                    m_documentErrors.append(i18n("Broken clip producer %1", id) + '\n');
-                } else m_documentErrors.append(i18n("Replaced wrong clip producer %1 with %2", id, missingClip->getId()) + '\n');
-                ClipItem *item = new ClipItem(missingClip, clipinfo, m_doc->fps(), 1.0, false);
-                m_scene->addItem(item);
-                missingClip->addReference();
-                position += (out - in + 1);
-
-                m_doc->setModified(true);
             }
             //m_clipList.append(clip);
         }