}
static void vout_display_Manage(vout_display_t *vd)
{
- vd->manage(vd);
+ if (vd->manage)
+ vd->manage(vd);
}
/* */
bool is_wrapper; /* Is the current display a wrapper */
vout_display_t *wrapper; /* Vout display wrapper */
- /* mouse state */
- struct {
- vlc_mouse_t state;
-
- mtime_t last_pressed;
- mtime_t last_moved;
- bool is_hidden;
-
- /* */
- mtime_t double_click_timeout;
- mtime_t hide_timeout;
- } mouse;
-
/* */
vout_display_cfg_t cfg;
bool is_on_top_initial;
} crop_saved;
/* */
- bool reset_pictures;
-
- bool ch_fullscreen;
- bool is_fullscreen;
-
- bool ch_display_size;
- int display_width;
- int display_height;
-
bool ch_display_filled;
bool is_display_filled;
/* */
video_format_t source;
filter_chain_t *filters;
+
+ /* Lock protecting the variables used by
+ * VoutDisplayEvent(ie vout_display_SendEvent) */
+ vlc_mutex_t lock;
+
+ /* mouse state */
+ struct {
+ vlc_mouse_t state;
+
+ mtime_t last_pressed;
+ mtime_t last_moved;
+ bool is_hidden;
+ bool ch_activity;
+
+ /* */
+ mtime_t double_click_timeout;
+ mtime_t hide_timeout;
+ } mouse;
+
+ bool reset_pictures;
+
+ bool ch_fullscreen;
+ bool is_fullscreen;
+
+ bool ch_display_size;
+ int display_width;
+ int display_height;
+ bool display_is_fullscreen;
+ bool display_is_forced;
};
static void VoutDisplayCreateRender(vout_display_t *vd)
{
vout_display_owner_sys_t *osys = vd->owner.sys;
+ vlc_mutex_lock(&osys->lock);
+
/* */
vlc_mouse_t m = osys->mouse.state;
bool is_ignored = false;
assert(0);
}
- if (is_ignored)
+ if (is_ignored) {
+ vlc_mutex_unlock(&osys->lock);
return;
+ }
/* Emulate double-click if needed */
if (!vd->info.has_double_click &&
osys->mouse.state = m;
/* */
- osys->mouse.is_hidden = false;
+ osys->mouse.ch_activity = true;
if (!vd->info.has_hide_mouse)
osys->mouse.last_moved = mdate();
+ /* */
+ vlc_mutex_unlock(&osys->lock);
+
/* */
vout_SendEventMouseVisible(osys->vout);
vout_SendDisplayEventMouse(osys->vout, &m);
msg_Dbg(vd, "VoutDisplayEvent 'fullscreen' %d", is_fullscreen);
- if (!is_fullscreen == !osys->is_fullscreen)
- break;
- osys->ch_fullscreen = true;
- osys->is_fullscreen = is_fullscreen;
+ vlc_mutex_lock(&osys->lock);
+ if (!is_fullscreen != !osys->is_fullscreen) {
+ osys->ch_fullscreen = true;
+ osys->is_fullscreen = is_fullscreen;
+ }
+ vlc_mutex_unlock(&osys->lock);
break;
}
case VOUT_DISPLAY_EVENT_DISPLAY_SIZE: {
const int width = (int)va_arg(args, int);
const int height = (int)va_arg(args, int);
- msg_Dbg(vd, "VoutDisplayEvent 'resize' %dx%d", width, height);
+ const bool is_fullscreen = (bool)va_arg(args, int);
+ msg_Dbg(vd, "VoutDisplayEvent 'resize' %dx%d %s",
+ width, height, is_fullscreen ? "fullscreen" : "window");
/* */
- osys->ch_display_size = true;
- osys->display_width = width;
- osys->display_height = height;
+ vlc_mutex_lock(&osys->lock);
+
+ osys->ch_display_size = true;
+ osys->display_width = width;
+ osys->display_height = height;
+ osys->display_is_fullscreen = is_fullscreen;
+ osys->display_is_forced = false;
+
+ vlc_mutex_unlock(&osys->lock);
break;
}
/* */
assert(vd->info.has_pictures_invalid);
+
+ vlc_mutex_lock(&osys->lock);
osys->reset_pictures = true;
+ vlc_mutex_unlock(&osys->lock);
break;
}
default:
/* Handle mouse timeout */
const mtime_t date = mdate();
+ bool hide_mouse = false;
+
+ vlc_mutex_lock(&osys->lock);
+
if (!osys->mouse.is_hidden &&
osys->mouse.last_moved + osys->mouse.hide_timeout < date) {
+ osys->mouse.is_hidden = hide_mouse = true;
+ } else if (osys->mouse.ch_activity) {
+ osys->mouse.is_hidden = false;
+ }
+ osys->mouse.ch_activity = false;
+ vlc_mutex_unlock(&osys->lock);
+
+ if (hide_mouse) {
if (!vd->info.has_hide_mouse) {
msg_Dbg(vd, "auto hidding mouse");
vout_display_Control(vd, VOUT_DISPLAY_HIDE_MOUSE);
}
- osys->mouse.is_hidden = true;
-
vout_SendEventMouseHidden(osys->vout);
}
- bool reset_pictures = false;
+ bool reset_render = false;
for (;;) {
- if (!osys->ch_fullscreen &&
- !osys->ch_display_size &&
- !osys->reset_pictures &&
+
+ vlc_mutex_lock(&osys->lock);
+
+ bool ch_fullscreen = osys->ch_fullscreen;
+ bool is_fullscreen = osys->is_fullscreen;
+ osys->ch_fullscreen = false;
+
+ bool ch_display_size = osys->ch_display_size;
+ int display_width = osys->display_width;
+ int display_height = osys->display_height;
+ bool display_is_fullscreen = osys->display_is_fullscreen;
+ bool display_is_forced = osys->display_is_forced;
+ osys->ch_display_size = false;
+
+ bool reset_pictures = osys->reset_pictures;
+ osys->reset_pictures = false;
+
+ vlc_mutex_unlock(&osys->lock);
+
+ if (!ch_fullscreen &&
+ !ch_display_size &&
+ !reset_pictures &&
!osys->ch_display_filled &&
!osys->ch_zoom &&
!osys->ch_on_top &&
break;
/* */
- if (osys->ch_fullscreen) {
+ if (ch_fullscreen) {
vout_display_cfg_t cfg = osys->cfg;
- cfg.is_fullscreen = osys->is_fullscreen;
+ cfg.is_fullscreen = is_fullscreen;
cfg.display.width = cfg.is_fullscreen ? 0 : osys->width_saved;
cfg.display.height = cfg.is_fullscreen ? 0 : osys->height_saved;
if (vout_display_Control(vd, VOUT_DISPLAY_CHANGE_FULLSCREEN, &cfg)) {
msg_Err(vd, "Failed to set fullscreen");
- osys->is_fullscreen = osys->cfg.is_fullscreen;
+ is_fullscreen = osys->cfg.is_fullscreen;
}
- osys->cfg.is_fullscreen = osys->is_fullscreen;
- osys->ch_fullscreen = false;
+ osys->cfg.is_fullscreen = is_fullscreen;
/* */
vout_SendEventFullscreen(osys->vout, osys->cfg.is_fullscreen);
}
/* */
- if (osys->ch_display_size) {
+ if (ch_display_size) {
vout_display_cfg_t cfg = osys->cfg;
- cfg.display.width = osys->display_width;
- cfg.display.height = osys->display_height;
+ cfg.display.width = display_width;
+ cfg.display.height = display_height;
- if (vout_display_Control(vd, VOUT_DISPLAY_CHANGE_DISPLAY_SIZE, &cfg)) {
- msg_Err(vd, "Failed to resize display");
+ if (!cfg.is_fullscreen != !display_is_fullscreen ||
+ vout_display_Control(vd, VOUT_DISPLAY_CHANGE_DISPLAY_SIZE, &cfg, display_is_forced)) {
+ if (!cfg.is_fullscreen == !display_is_fullscreen)
+ msg_Err(vd, "Failed to resize display");
/* We ignore the resized */
- osys->display_width = osys->cfg.display.width;
- osys->display_height = osys->cfg.display.height;
+ display_width = osys->cfg.display.width;
+ display_height = osys->cfg.display.height;
}
- osys->cfg.display.width = osys->display_width;
- osys->cfg.display.height = osys->display_height;
+ osys->cfg.display.width = display_width;
+ osys->cfg.display.height = display_height;
- if (!osys->is_fullscreen) {
- osys->width_saved = osys->display_width;
- osys->height_saved = osys->display_height;
+ if (!display_is_fullscreen) {
+ osys->width_saved = display_width;
+ osys->height_saved = display_height;
}
- osys->ch_display_size = false;
}
/* */
if (osys->ch_display_filled) {
osys->zoom.num = osys->cfg.zoom.num;
osys->zoom.den = osys->cfg.zoom.den;
} else if (cfg.is_display_filled) {
- osys->ch_display_size = true;
- osys->display_width = (int64_t)vd->source.i_width * osys->zoom.num / osys->zoom.den;
- osys->display_height = (int64_t)vd->source.i_height * osys->zoom.num / osys->zoom.den;
+ const int display_width = (int64_t)vd->source.i_width * osys->zoom.num / osys->zoom.den;
+ const int display_height = (int64_t)vd->source.i_height * osys->zoom.num / osys->zoom.den;
+
+ vlc_mutex_lock(&osys->lock);
+
+ osys->ch_display_size = true;
+ osys->display_width = display_width;
+ osys->display_height = display_height;
+ osys->display_is_fullscreen = osys->cfg.is_fullscreen;
+ osys->display_is_forced = true;
+
+ vlc_mutex_unlock(&osys->lock);
}
osys->cfg.zoom.num = osys->zoom.num;
}
/* */
- if (osys->reset_pictures) {
+ if (reset_pictures) {
if (vout_display_Control(vd, VOUT_DISPLAY_RESET_PICTURES)) {
/* FIXME what to do here ? */
msg_Err(vd, "Failed to reset pictures (probably fatal)");
}
- reset_pictures = true;
-
- osys->reset_pictures = false;
+ reset_render = true;
}
}
- if (reset_pictures)
+ if (reset_render)
VoutDisplayResetRender(vd);
}
{
vout_display_owner_sys_t *osys = vd->owner.sys;
- return osys->reset_pictures;
+ vlc_mutex_lock(&osys->lock);
+ const bool reset_pictures = osys->reset_pictures;
+ vlc_mutex_unlock(&osys->lock);
+
+ return reset_pictures;
}
bool vout_IsDisplayFiltered(vout_display_t *vd)
{
vout_display_owner_sys_t *osys = vd->owner.sys;
+ vlc_mutex_lock(&osys->lock);
if (!osys->is_fullscreen != !is_fullscreen) {
osys->ch_fullscreen = true;
osys->is_fullscreen = is_fullscreen;
}
+ vlc_mutex_unlock(&osys->lock);
}
void vout_SetDisplayFilled(vout_display_t *vd, bool is_filled)
osys->is_wrapper = is_wrapper;
osys->wrapper = wrapper;
+ vlc_mutex_init(&osys->lock);
+
vlc_mouse_Init(&osys->mouse.state);
osys->mouse.last_moved = mdate();
osys->mouse.double_click_timeout = double_click_timeout;
if (osys->is_wrapper)
SplitterClose(vd);
vout_display_Delete(vd);
+ vlc_mutex_destroy(&osys->lock);
free(osys);
}
projects / vlc / blobdiff