]> git.sesse.net Git - vlc/blobdiff - src/video_output/vout_intf.c
vout: separate scale and autoscale callbacks
[vlc] / src / video_output / vout_intf.c
index 5f58542f9ce0e7ff828cdad67c410143567fa177..6caf19bc87a2de67ab1fc5eb9ddae37f8cfc657c 100644 (file)
 /*****************************************************************************
  * vout_intf.c : video output interface
  *****************************************************************************
- * Copyright (C) 2000-2006 the VideoLAN team
- * $Id$
+ * Copyright (C) 2000-2007 VLC authors and VideoLAN
  *
  * Authors: Gildas Bazin <gbazin@videolan.org>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; either version 2.1 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
 /*****************************************************************************
  * Preamble
  *****************************************************************************/
 
-#include <vlc/vlc.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
+#include <vlc_common.h>
 
 #include <stdio.h>
 #include <stdlib.h>                                                /* free() */
-#include <sys/types.h>                                          /* opendir() */
-#include <dirent.h>                                             /* opendir() */
+#include <assert.h>
 
-#include <vlc_interface.h>
 #include <vlc_block.h>
-#include <vlc_playlist.h>
+#include <vlc_modules.h>
 
 #include <vlc_vout.h>
-#include <vlc_image.h>
-#include <vlc_osd.h>
-#include <vlc_charset.h>
-
+#include <vlc_vout_osd.h>
 #include <vlc_strings.h>
 #include <vlc_charset.h>
+#include "vout_internal.h"
 
 /*****************************************************************************
  * Local prototypes
  *****************************************************************************/
-static void InitWindowSize( vout_thread_t *, unsigned *, unsigned * );
-
 /* Object variables callbacks */
-static int ZoomCallback( vlc_object_t *, char const *,
-                         vlc_value_t, vlc_value_t, void * );
 static int CropCallback( vlc_object_t *, char const *,
                          vlc_value_t, vlc_value_t, void * );
+static int CropBorderCallback( vlc_object_t *, char const *,
+                               vlc_value_t, vlc_value_t, void * );
 static int AspectCallback( vlc_object_t *, char const *,
                            vlc_value_t, vlc_value_t, void * );
+static int AutoScaleCallback( vlc_object_t *, char const *,
+                              vlc_value_t, vlc_value_t, void * );
+static int ScaleCallback( vlc_object_t *, char const *,
+                          vlc_value_t, vlc_value_t, void * );
+static int ZoomCallback( vlc_object_t *, char const *,
+                         vlc_value_t, vlc_value_t, void * );
 static int OnTopCallback( vlc_object_t *, char const *,
                           vlc_value_t, vlc_value_t, void * );
 static int FullscreenCallback( vlc_object_t *, char const *,
                                vlc_value_t, vlc_value_t, void * );
 static int SnapshotCallback( vlc_object_t *, char const *,
                              vlc_value_t, vlc_value_t, void * );
+static int VideoFilterCallback( vlc_object_t *, char const *,
+                                vlc_value_t, vlc_value_t, void * );
+static int SubSourceCallback( vlc_object_t *, char const *,
+                              vlc_value_t, vlc_value_t, void * );
+static int SubFilterCallback( vlc_object_t *, char const *,
+                              vlc_value_t, vlc_value_t, void * );
+static int SubMarginCallback( vlc_object_t *, char const *,
+                              vlc_value_t, vlc_value_t, void * );
 
 /*****************************************************************************
- * vout_RequestWindow: Create/Get a video window if possible.
- *****************************************************************************
- * This function looks for the main interface and tries to request
- * a new video window. If it fails then the vout will still need to create the
- * window by itself.
+ * vout_IntfInit: called during the vout creation to initialise misc things.
  *****************************************************************************/
-void *vout_RequestWindow( vout_thread_t *p_vout,
-                          int *pi_x_hint, int *pi_y_hint,
-                          unsigned int *pi_width_hint,
-                          unsigned int *pi_height_hint )
+static const struct
 {
-    intf_thread_t *p_intf = NULL;
-    vlc_list_t *p_list;
-    void *p_window;
-    vlc_value_t val;
-    int i;
-
-    /* Small kludge */
-    if( !var_Type( p_vout, "aspect-ratio" ) ) vout_IntfInit( p_vout );
-
-    /* Get requested coordinates */
-    var_Get( p_vout, "video-x", &val );
-    *pi_x_hint = val.i_int ;
-    var_Get( p_vout, "video-y", &val );
-    *pi_y_hint = val.i_int;
-
-    *pi_width_hint = p_vout->i_window_width;
-    *pi_height_hint = p_vout->i_window_height;
-
-    /* Check whether someone provided us with a window ID */
-    var_Get( p_vout->p_libvlc, "drawable", &val );
-    if( val.i_int ) return (void *)val.i_int;
-
-    /* Find if the main interface supports embedding */
-    p_list = vlc_list_find( p_vout, VLC_OBJECT_INTF, FIND_ANYWHERE );
-    if( !p_list ) return NULL;
-
-    for( i = 0; i < p_list->i_count; i++ )
-    {
-        p_intf = (intf_thread_t *)p_list->p_values[i].p_object;
-        if( p_intf->b_block && p_intf->pf_request_window ) break;
-        p_intf = NULL;
-    }
-
-    if( !p_intf )
-    {
-        vlc_list_release( p_list );
-        return NULL;
-    }
-
-    vlc_object_yield( p_intf );
-    vlc_list_release( p_list );
-
-    p_window = p_intf->pf_request_window( p_intf, p_vout, pi_x_hint, pi_y_hint,
-                                          pi_width_hint, pi_height_hint );
-
-    if( !p_window ) vlc_object_release( p_intf );
-    else p_vout->p_parent_intf = p_intf;
-
-    return p_window;
-}
-
-void vout_ReleaseWindow( vout_thread_t *p_vout, void *p_window )
+    double f_value;
+    char psz_label[13];
+} p_zoom_values[] = {
+    { 0.25, N_("1:4 Quarter") },
+    { 0.5, N_("1:2 Half") },
+    { 1, N_("1:1 Original") },
+    { 2, N_("2:1 Double") },
+};
+
+static const struct
 {
-    intf_thread_t *p_intf = p_vout->p_parent_intf;
-
-    if( !p_intf ) return;
-
-    vlc_mutex_lock( &p_intf->object_lock );
-    if( p_intf->b_dead )
-    {
-        vlc_mutex_unlock( &p_intf->object_lock );
-        return;
-    }
-
-    if( !p_intf->pf_release_window )
-    {
-        msg_Err( p_vout, "no pf_release_window");
-        vlc_mutex_unlock( &p_intf->object_lock );
-        vlc_object_release( p_intf );
-        return;
-    }
-
-    p_intf->pf_release_window( p_intf, p_window );
-
-    p_vout->p_parent_intf = NULL;
-    vlc_mutex_unlock( &p_intf->object_lock );
-    vlc_object_release( p_intf );
-}
-
-int vout_ControlWindow( vout_thread_t *p_vout, void *p_window,
-                        int i_query, va_list args )
+    char psz_value[8];
+    char psz_label[8];
+} p_crop_values[] = {
+    { "", N_("Default") },
+    { "16:10", "16:10" },
+    { "16:9", "16:9" },
+    { "185:100", "1.85:1" },
+    { "221:100", "2.21:1" },
+    { "235:100", "2.35:1" },
+    { "239:100", "2.39:1" },
+    { "5:3", "5:3" },
+    { "4:3", "4:3" },
+    { "5:4", "5:4" },
+    { "1:1", "1:1" },
+};
+
+static const struct
 {
-    intf_thread_t *p_intf = p_vout->p_parent_intf;
-    int i_ret;
-
-    if( !p_intf ) return VLC_EGENERIC;
-
-    vlc_mutex_lock( &p_intf->object_lock );
-    if( p_intf->b_dead )
-    {
-        vlc_mutex_unlock( &p_intf->object_lock );
-        return VLC_EGENERIC;
-    }
+    char psz_value[8];
+    char psz_label[8];
+} p_aspect_ratio_values[] = {
+    { "", N_("Default") },
+    { "1:1", "1:1" },
+    { "4:3", "4:3" },
+    { "16:9", "16:9" },
+    { "16:10", "16:10" },
+    { "221:100", "2.21:1" },
+    { "235:100", "2.35:1" },
+    { "239:100", "2.39:1" },
+    { "5:4", "5:4" },
+};
+
+static void AddCustomRatios( vout_thread_t *p_vout, const char *psz_var,
+                             char *psz_list )
+{
+    assert( psz_list );
 
-    if( !p_intf->pf_control_window )
+    char *psz_cur = psz_list;
+    char *psz_next;
+    while( psz_cur && *psz_cur )
     {
-        msg_Err( p_vout, "no pf_control_window");
-        vlc_mutex_unlock( &p_intf->object_lock );
-        return VLC_EGENERIC;
+        vlc_value_t val, text;
+        psz_next = strchr( psz_cur, ',' );
+        if( psz_next )
+        {
+            *psz_next = '\0';
+            psz_next++;
+        }
+        val.psz_string = psz_cur;
+        text.psz_string = psz_cur;
+        var_Change( p_vout, psz_var, VLC_VAR_ADDCHOICE, &val, &text);
+        psz_cur = psz_next;
     }
-
-    i_ret = p_intf->pf_control_window( p_intf, p_window, i_query, args );
-    vlc_mutex_unlock( &p_intf->object_lock );
-    return i_ret;
 }
 
-/*****************************************************************************
- * vout_IntfInit: called during the vout creation to initialise misc things.
- *****************************************************************************/
 void vout_IntfInit( vout_thread_t *p_vout )
 {
     vlc_value_t val, text, old_val;
-    vlc_bool_t b_force_par = VLC_FALSE;
     char *psz_buf;
 
     /* Create a few object variables we'll need later on */
-    var_Create( p_vout, "snapshot-path", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
-    var_Create( p_vout, "snapshot-prefix", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
-    var_Create( p_vout, "snapshot-format", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
-    var_Create( p_vout, "snapshot-preview", VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
-    var_Create( p_vout, "snapshot-sequential",
-                VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
     var_Create( p_vout, "snapshot-num", VLC_VAR_INTEGER );
     var_SetInteger( p_vout, "snapshot-num", 1 );
 
     var_Create( p_vout, "width", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
     var_Create( p_vout, "height", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
     var_Create( p_vout, "align", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
-    var_Get( p_vout, "align", &val );
-    p_vout->i_alignment = val.i_int;
 
     var_Create( p_vout, "video-x", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
     var_Create( p_vout, "video-y", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
 
+    var_Create( p_vout, "mouse-hide-timeout",
+                VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
+
+    /* Add variables to manage scaling video */
+    var_Create( p_vout, "autoscale", VLC_VAR_BOOL | VLC_VAR_DOINHERIT
+                | VLC_VAR_ISCOMMAND );
+    text.psz_string = _("Autoscale video");
+    var_Change( p_vout, "autoscale", VLC_VAR_SETTEXT, &text, NULL );
+    var_AddCallback( p_vout, "autoscale", AutoScaleCallback, NULL );
+
+    var_Create( p_vout, "scale", VLC_VAR_FLOAT | VLC_VAR_DOINHERIT
+                | VLC_VAR_ISCOMMAND );
+    text.psz_string = _("Scale factor");
+    var_Change( p_vout, "scale", VLC_VAR_SETTEXT, &text, NULL );
+    var_AddCallback( p_vout, "scale", ScaleCallback, NULL );
+
     /* Zoom object var */
     var_Create( p_vout, "zoom", VLC_VAR_FLOAT | VLC_VAR_ISCOMMAND |
                 VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT );
 
     text.psz_string = _("Zoom");
     var_Change( p_vout, "zoom", VLC_VAR_SETTEXT, &text, NULL );
+    old_val.f_float = var_GetFloat( p_vout, "zoom" );
 
-    var_Get( p_vout, "zoom", &old_val );
-    if( old_val.f_float == 0.25 ||
-        old_val.f_float == 0.5 ||
-        old_val.f_float == 1 ||
-        old_val.f_float == 2 )
+    for( size_t i = 0; i < ARRAY_SIZE(p_zoom_values); i++ )
     {
-        var_Change( p_vout, "zoom", VLC_VAR_DELCHOICE, &old_val, NULL );
+        val.f_float = p_zoom_values[i].f_value;
+        text.psz_string = vlc_gettext( p_zoom_values[i].psz_label );
+        /* FIXME: This DELCHOICE hack corrupts the the "zoom" variable value
+         * for a short time window. Same for "crop" and "aspect-ratio". */
+        if( old_val.f_float == val.f_float )
+            var_Change( p_vout, "zoom", VLC_VAR_DELCHOICE, &old_val, NULL );
+        var_Change( p_vout, "zoom", VLC_VAR_ADDCHOICE, &val, &text );
+        if( old_val.f_float == val.f_float )
+            var_Change( p_vout, "zoom", VLC_VAR_SETVALUE, &old_val, NULL );
     }
 
-    val.f_float = 0.25; text.psz_string = _("1:4 Quarter");
-    var_Change( p_vout, "zoom", VLC_VAR_ADDCHOICE, &val, &text );
-    val.f_float = 0.5; text.psz_string = _("1:2 Half");
-    var_Change( p_vout, "zoom", VLC_VAR_ADDCHOICE, &val, &text );
-    val.f_float = 1; text.psz_string = _("1:1 Original");
-    var_Change( p_vout, "zoom", VLC_VAR_ADDCHOICE, &val, &text );
-    val.f_float = 2; text.psz_string = _("2:1 Double");
-    var_Change( p_vout, "zoom", VLC_VAR_ADDCHOICE, &val, &text );
-
-    var_Set( p_vout, "zoom", old_val );
-
     var_AddCallback( p_vout, "zoom", ZoomCallback, NULL );
 
     /* Crop offset vars */
-    var_Create( p_vout, "crop-left", VLC_VAR_INTEGER );
-    var_Create( p_vout, "crop-top", VLC_VAR_INTEGER );
-    var_Create( p_vout, "crop-right", VLC_VAR_INTEGER );
-    var_Create( p_vout, "crop-bottom", VLC_VAR_INTEGER );
-
-    var_SetInteger( p_vout, "crop-left", 0 );
-    var_SetInteger( p_vout, "crop-top", 0 );
-    var_SetInteger( p_vout, "crop-right", 0 );
-    var_SetInteger( p_vout, "crop-bottom", 0 );
+    var_Create( p_vout, "crop-left", VLC_VAR_INTEGER | VLC_VAR_ISCOMMAND );
+    var_Create( p_vout, "crop-top", VLC_VAR_INTEGER | VLC_VAR_ISCOMMAND );
+    var_Create( p_vout, "crop-right", VLC_VAR_INTEGER | VLC_VAR_ISCOMMAND );
+    var_Create( p_vout, "crop-bottom", VLC_VAR_INTEGER | VLC_VAR_ISCOMMAND );
 
-    var_AddCallback( p_vout, "crop-left", CropCallback, NULL );
-    var_AddCallback( p_vout, "crop-top", CropCallback, NULL );
-    var_AddCallback( p_vout, "crop-right", CropCallback, NULL );
-    var_AddCallback( p_vout, "crop-bottom", CropCallback, NULL );
+    var_AddCallback( p_vout, "crop-left", CropBorderCallback, NULL );
+    var_AddCallback( p_vout, "crop-top", CropBorderCallback, NULL );
+    var_AddCallback( p_vout, "crop-right", CropBorderCallback, NULL );
+    var_AddCallback( p_vout, "crop-bottom", CropBorderCallback, NULL );
 
     /* Crop object var */
-    var_Create( p_vout, "crop", VLC_VAR_STRING |
+    var_Create( p_vout, "crop", VLC_VAR_STRING | VLC_VAR_ISCOMMAND |
                 VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT );
 
     text.psz_string = _("Crop");
     var_Change( p_vout, "crop", VLC_VAR_SETTEXT, &text, NULL );
 
-    val.psz_string = "";
+    val.psz_string = (char*)"";
     var_Change( p_vout, "crop", VLC_VAR_DELCHOICE, &val, 0 );
-    val.psz_string = ""; text.psz_string = _("Default");
-    var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "1:1"; text.psz_string = "1:1";
-    var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "4:3"; text.psz_string = "4:3";
-    var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "16:9"; text.psz_string = "16:9";
-    var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "16:10"; text.psz_string = "16:10";
-    var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "221:100"; text.psz_string = "221:100";
-    var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "5:4"; text.psz_string = "5:4";
-    var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
+
+    for( size_t i = 0; i < ARRAY_SIZE(p_crop_values); i++ )
+    {
+        val.psz_string = (char*)p_crop_values[i].psz_value;
+        text.psz_string = _( p_crop_values[i].psz_label );
+        var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
+    }
 
     /* Add custom crop ratios */
-    psz_buf = config_GetPsz( p_vout, "custom-crop-ratios" );
-    if( psz_buf && *psz_buf )
+    psz_buf = var_CreateGetNonEmptyString( p_vout, "custom-crop-ratios" );
+    if( psz_buf )
     {
-        char *psz_cur = psz_buf;
-        char *psz_next;
-        while( psz_cur && *psz_cur )
-        {
-            psz_next = strchr( psz_cur, ',' );
-            if( psz_next )
-            {
-                *psz_next = '\0';
-                psz_next++;
-            }
-            val.psz_string = strdup( psz_cur );
-            text.psz_string = strdup( psz_cur );
-            var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text);
-            free( val.psz_string );
-            free( text.psz_string );
-            psz_cur = psz_next;
-        }
+        AddCustomRatios( p_vout, "crop", psz_buf );
+        free( psz_buf );
     }
-    if( psz_buf ) free( psz_buf );
 
     var_AddCallback( p_vout, "crop", CropCallback, NULL );
-    var_Get( p_vout, "crop", &old_val );
-    if( old_val.psz_string && *old_val.psz_string )
-        var_Change( p_vout, "crop", VLC_VAR_TRIGGER_CALLBACKS, 0, 0 );
-    if( old_val.psz_string ) free( old_val.psz_string );
 
     /* Monitor pixel aspect-ratio */
     var_Create( p_vout, "monitor-par", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
-    var_Get( p_vout, "monitor-par", &val );
-    if( val.psz_string && *val.psz_string )
-    {
-        char *psz_parser = strchr( val.psz_string, ':' );
-        unsigned int i_aspect_num = 0, i_aspect_den = 0;
-        float i_aspect = 0;
-        if( psz_parser )
-        {
-            i_aspect_num = strtol( val.psz_string, 0, 10 );
-            i_aspect_den = strtol( ++psz_parser, 0, 10 );
-        }
-        else
-        {
-            i_aspect = atof( val.psz_string );
-            vlc_ureduce( &i_aspect_num, &i_aspect_den,
-                         i_aspect *VOUT_ASPECT_FACTOR, VOUT_ASPECT_FACTOR, 0 );
-        }
-        if( !i_aspect_num || !i_aspect_den ) i_aspect_num = i_aspect_den = 1;
-
-        p_vout->i_par_num = i_aspect_num;
-        p_vout->i_par_den = i_aspect_den;
-
-        vlc_ureduce( &p_vout->i_par_num, &p_vout->i_par_den,
-                     p_vout->i_par_num, p_vout->i_par_den, 0 );
-
-        msg_Dbg( p_vout, "overriding monitor pixel aspect-ratio: %i:%i",
-                 p_vout->i_par_num, p_vout->i_par_den );
-        b_force_par = VLC_TRUE;
-    }
-    if( val.psz_string ) free( val.psz_string );
 
     /* Aspect-ratio object var */
-    var_Create( p_vout, "aspect-ratio", VLC_VAR_STRING |
+    var_Create( p_vout, "aspect-ratio", VLC_VAR_STRING | VLC_VAR_ISCOMMAND |
                 VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT );
 
-    text.psz_string = _("Aspect-ratio");
+    text.psz_string = _("Aspect ratio");
     var_Change( p_vout, "aspect-ratio", VLC_VAR_SETTEXT, &text, NULL );
 
-    val.psz_string = "";
+    val.psz_string = (char*)"";
     var_Change( p_vout, "aspect-ratio", VLC_VAR_DELCHOICE, &val, 0 );
-    val.psz_string = ""; text.psz_string = _("Default");
-    var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "1:1"; text.psz_string = "1:1";
-    var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "4:3"; text.psz_string = "4:3";
-    var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "16:9"; text.psz_string = "16:9";
-    var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "16:10"; text.psz_string = "16:10";
-    var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "221:100"; text.psz_string = "221:100";
-    var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
-    val.psz_string = "5:4"; text.psz_string = "5:4";
-    var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
+
+    for( size_t i = 0; i < ARRAY_SIZE(p_aspect_ratio_values); i++ )
+    {
+        val.psz_string = (char*)p_aspect_ratio_values[i].psz_value;
+        text.psz_string = _( p_aspect_ratio_values[i].psz_label );
+        var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text );
+    }
 
     /* Add custom aspect ratios */
-    psz_buf = config_GetPsz( p_vout, "custom-aspect-ratios" );
-    if( psz_buf && *psz_buf )
+    psz_buf = var_CreateGetNonEmptyString( p_vout, "custom-aspect-ratios" );
+    if( psz_buf )
     {
-        char *psz_cur = psz_buf;
-        char *psz_next;
-        while( psz_cur && *psz_cur )
-        {
-            psz_next = strchr( psz_cur, ',' );
-            if( psz_next )
-            {
-                *psz_next = '\0';
-                psz_next++;
-            }
-            val.psz_string = strdup( psz_cur );
-            text.psz_string = strdup( psz_cur );
-            var_Change( p_vout, "aspect-ratio", VLC_VAR_ADDCHOICE, &val, &text);
-            free( val.psz_string );
-            free( text.psz_string );
-            psz_cur = psz_next;
-        }
+        AddCustomRatios( p_vout, "aspect-ratio", psz_buf );
+        free( psz_buf );
     }
-    if( psz_buf ) free( psz_buf );
 
     var_AddCallback( p_vout, "aspect-ratio", AspectCallback, NULL );
-    var_Get( p_vout, "aspect-ratio", &old_val );
-    if( (old_val.psz_string && *old_val.psz_string) || b_force_par )
-        var_Change( p_vout, "aspect-ratio", VLC_VAR_TRIGGER_CALLBACKS, 0, 0 );
-    if( old_val.psz_string ) free( old_val.psz_string );
-
-    /* Initialize the dimensions of the video window */
-    InitWindowSize( p_vout, &p_vout->i_window_width,
-                    &p_vout->i_window_height );
 
     /* Add a variable to indicate if the window should be on top of others */
-    var_Create( p_vout, "video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
+    var_Create( p_vout, "video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT
+                | VLC_VAR_ISCOMMAND );
     text.psz_string = _("Always on top");
     var_Change( p_vout, "video-on-top", VLC_VAR_SETTEXT, &text, NULL );
     var_AddCallback( p_vout, "video-on-top", OnTopCallback, NULL );
@@ -409,15 +279,10 @@ void vout_IntfInit( vout_thread_t *p_vout )
     var_Create( p_vout, "video-deco", VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
 
     /* Add a fullscreen variable */
-    var_Create( p_vout, "fullscreen", VLC_VAR_BOOL );
+    var_Create( p_vout, "fullscreen",
+                VLC_VAR_BOOL | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
     text.psz_string = _("Fullscreen");
     var_Change( p_vout, "fullscreen", VLC_VAR_SETTEXT, &text, NULL );
-    var_Change( p_vout, "fullscreen", VLC_VAR_INHERITVALUE, &val, NULL );
-    if( val.b_bool )
-    {
-        /* user requested fullscreen */
-        p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
-    }
     var_AddCallback( p_vout, "fullscreen", FullscreenCallback, NULL );
 
     /* Add a snapshot variable */
@@ -426,321 +291,197 @@ void vout_IntfInit( vout_thread_t *p_vout )
     var_Change( p_vout, "video-snapshot", VLC_VAR_SETTEXT, &text, NULL );
     var_AddCallback( p_vout, "video-snapshot", SnapshotCallback, NULL );
 
+    /* Add a video-filter variable */
+    var_Create( p_vout, "video-filter",
+                VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+    var_AddCallback( p_vout, "video-filter", VideoFilterCallback, NULL );
+
+    /* Add a sub-source variable */
+    var_Create( p_vout, "sub-source",
+                VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+    var_AddCallback( p_vout, "sub-source", SubSourceCallback, NULL );
+
+    /* Add a sub-filter variable */
+    var_Create( p_vout, "sub-filter",
+                VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+    var_AddCallback( p_vout, "sub-filter", SubFilterCallback, NULL );
+
+    /* Add sub-margin variable */
+    var_Create( p_vout, "sub-margin",
+                VLC_VAR_INTEGER | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+    var_AddCallback( p_vout, "sub-margin", SubMarginCallback, NULL );
+
     /* Mouse coordinates */
-    var_Create( p_vout, "mouse-x", VLC_VAR_INTEGER );
-    var_Create( p_vout, "mouse-y", VLC_VAR_INTEGER );
     var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
-    var_Create( p_vout, "mouse-moved", VLC_VAR_BOOL );
-    var_Create( p_vout, "mouse-clicked", VLC_VAR_INTEGER );
+    var_Create( p_vout, "mouse-moved", VLC_VAR_COORDS );
+    var_Create( p_vout, "mouse-clicked", VLC_VAR_COORDS );
+    var_Create( p_vout, "mouse-object", VLC_VAR_BOOL );
 
-    var_Create( p_vout, "intf-change", VLC_VAR_BOOL );
-    val.b_bool = VLC_TRUE;
-    var_Set( p_vout, "intf-change", val );
+    vout_IntfReinit( p_vout );
 }
 
-/*****************************************************************************
- * vout_Snapshot: generates a snapshot.
- *****************************************************************************/
-int vout_Snapshot( vout_thread_t *p_vout, picture_t *p_pic )
+void vout_IntfReinit( vout_thread_t *p_vout )
 {
-    image_handler_t *p_image = image_HandlerCreate( p_vout );
-    video_format_t fmt_in = {0}, fmt_out = {0};
-    char *psz_filename = NULL;
-    subpicture_t *p_subpic;
-    picture_t *p_pif;
-    vlc_value_t val, format;
-    DIR *path;
-
-    int i_ret;
-
-    var_Get( p_vout, "snapshot-path", &val );
-    if( val.psz_string && !*val.psz_string )
-    {
-        free( val.psz_string );
-        val.psz_string = 0;
-    }
+    var_TriggerCallback( p_vout, "zoom" );
+    var_TriggerCallback( p_vout, "crop" );
+    var_TriggerCallback( p_vout, "aspect-ratio" );
 
-    /* Embedded snapshot : if snapshot-path == object:object-id, then
-       create a snapshot_t* and store it in
-       object(object-id)->p_private, then unlock and signal the
-       waiting object.
-     */
-    if( val.psz_string && !strncmp( val.psz_string, "object:", 7 ) )
-    {
-        int i_id;
-        vlc_object_t* p_dest;
-        block_t *p_block;
-        snapshot_t *p_snapshot;
-        int i_size;
-
-        /* Destination object-id is following object: */
-        i_id = atoi( &val.psz_string[7] );
-        p_dest = ( vlc_object_t* )vlc_current_object( i_id );
-        if( !p_dest )
-        {
-            msg_Err( p_vout, "Cannot find calling object" );
-            image_HandlerDelete( p_image );
-            return VLC_EGENERIC;
-        }
-        /* Object must be locked. We will unlock it once we get the
-           snapshot and written it to p_private */
-        p_dest->p_private = NULL;
-
-        /* Save the snapshot to a memory zone */
-        fmt_in = p_vout->fmt_in;
-        fmt_out.i_sar_num = fmt_out.i_sar_den = 1;
-        /* FIXME: should not be hardcoded. We should be able to
-        specify the snapshot size (snapshot-width and snapshot-height). */
-        fmt_out.i_width = 320;
-        fmt_out.i_height = 200;
-        fmt_out.i_chroma = VLC_FOURCC( 'p','n','g',' ' );
-        p_block = ( block_t* ) image_Write( p_image, p_pic, &fmt_in, &fmt_out );
-        if( !p_block )
-        {
-            msg_Err( p_vout, "Could not get snapshot" );
-            image_HandlerDelete( p_image );
-            vlc_cond_signal( &p_dest->object_wait );
-            vlc_mutex_unlock( &p_dest->object_lock );
-            vlc_object_release( p_dest );
-            return VLC_EGENERIC;
-        }
+    var_TriggerCallback( p_vout, "video-on-top" );
 
-        /* Copy the p_block data to a snapshot structure */
-        /* FIXME: get the timestamp */
-        p_snapshot = ( snapshot_t* ) malloc( sizeof( snapshot_t ) );
-        if( !p_snapshot )
-        {
-            block_Release( p_block );
-            image_HandlerDelete( p_image );
-            vlc_cond_signal( &p_dest->object_wait );
-            vlc_mutex_unlock( &p_dest->object_lock );
-            vlc_object_release( p_dest );
-            return VLC_ENOMEM;
-        }
+    var_TriggerCallback( p_vout, "video-filter" );
+    var_TriggerCallback( p_vout, "sub-source" );
+    var_TriggerCallback( p_vout, "sub-filter" );
+    var_TriggerCallback( p_vout, "sub-margin" );
+}
 
-        i_size = p_block->i_buffer;
+/*****************************************************************************
+ * vout_Snapshot: generates a snapshot.
+ *****************************************************************************/
+/**
+ * This function will inject a subpicture into the vout with the provided
+ * picture
+ */
+static int VoutSnapshotPip( vout_thread_t *p_vout, picture_t *p_pic )
+{
+    subpicture_t *p_subpic = subpicture_NewFromPicture( VLC_OBJECT(p_vout),
+                                                        p_pic, VLC_CODEC_YUVA );
+    if( !p_subpic )
+        return VLC_EGENERIC;
 
-        p_snapshot->i_width = fmt_out.i_width;
-        p_snapshot->i_height = fmt_out.i_height;
-        p_snapshot->i_datasize = i_size;
-        p_snapshot->date = p_block->i_pts; /* FIXME ?? */
-        p_snapshot->p_data = ( char* ) malloc( i_size );
-        if( !p_snapshot->p_data )
-        {
-            block_Release( p_block );
-            free( p_snapshot );
-            image_HandlerDelete( p_image );
-            vlc_cond_signal( &p_dest->object_wait );
-            vlc_mutex_unlock( &p_dest->object_lock );
-            vlc_object_release( p_dest );
-            return VLC_ENOMEM;
-        }
-        memcpy( p_snapshot->p_data, p_block->p_buffer, p_block->i_buffer );
+    /* FIXME SPU_DEFAULT_CHANNEL is not good (used by the text) but
+     * hardcoded 0 doesn't seem right */
+    p_subpic->i_channel = 0;
+    p_subpic->i_start = mdate();
+    p_subpic->i_stop  = p_subpic->i_start + 4000000;
+    p_subpic->b_ephemer = true;
+    p_subpic->b_fade = true;
 
-        p_dest->p_private = p_snapshot;
+    /* Reduce the picture to 1/4^2 of the screen */
+    p_subpic->i_original_picture_width  *= 4;
+    p_subpic->i_original_picture_height *= 4;
 
-        block_Release( p_block );
+    vout_PutSubpicture( p_vout, p_subpic );
+    return VLC_SUCCESS;
+}
 
-        /* Unlock the object */
-        vlc_cond_signal( &p_dest->object_wait );
-        vlc_mutex_unlock( &p_dest->object_lock );
-        vlc_object_release( p_dest );
+/**
+ * This function will display the name and a PIP of the provided snapshot
+ */
+static void VoutOsdSnapshot( vout_thread_t *p_vout, picture_t *p_pic, const char *psz_filename )
+{
+    msg_Dbg( p_vout, "snapshot taken (%s)", psz_filename );
+    vout_OSDMessage( p_vout, SPU_DEFAULT_CHANNEL, "%s", psz_filename );
 
-        image_HandlerDelete( p_image );
-        return VLC_SUCCESS;
+    if( var_InheritBool( p_vout, "snapshot-preview" ) )
+    {
+        if( VoutSnapshotPip( p_vout, p_pic ) )
+            msg_Warn( p_vout, "Failed to display snapshot" );
     }
+}
+
+/**
+ * This function will handle a snapshot request
+ */
+static void VoutSaveSnapshot( vout_thread_t *p_vout )
+{
+    char *psz_path = var_InheritString( p_vout, "snapshot-path" );
+    char *psz_format = var_InheritString( p_vout, "snapshot-format" );
+    char *psz_prefix = var_InheritString( p_vout, "snapshot-prefix" );
 
+    /* */
+    picture_t *p_picture;
+    block_t *p_image;
+    video_format_t fmt;
 
-#if defined(__APPLE__) || defined(SYS_BEOS)
-    if( !val.psz_string && p_vout->p_libvlc->psz_homedir )
+    /* 500ms timeout
+     * XXX it will cause trouble with low fps video (< 2fps) */
+    if( vout_GetSnapshot( p_vout, &p_image, &p_picture, &fmt, psz_format, 500*1000 ) )
     {
-        asprintf( &val.psz_string, "%s/Desktop",
-                  p_vout->p_libvlc->psz_homedir );
+        p_picture = NULL;
+        p_image = NULL;
+        goto exit;
     }
 
-#elif defined(WIN32) && !defined(UNDER_CE)
-    if( !val.psz_string && p_vout->p_libvlc->psz_homedir )
+    if( !psz_path )
     {
-        /* Get the My Pictures folder path */
-
-        char *p_mypicturesdir = NULL;
-        typedef HRESULT (WINAPI *SHGETFOLDERPATH)( HWND, int, HANDLE, DWORD,
-                                                   LPWSTR );
-        #ifndef CSIDL_FLAG_CREATE
-        #   define CSIDL_FLAG_CREATE 0x8000
-        #endif
-        #ifndef CSIDL_MYPICTURES
-        #   define CSIDL_MYPICTURES 0x27
-        #endif
-        #ifndef SHGFP_TYPE_CURRENT
-        #   define SHGFP_TYPE_CURRENT 0
-        #endif
-
-        HINSTANCE shfolder_dll;
-        SHGETFOLDERPATH SHGetFolderPath ;
-
-        /* load the shfolder dll to retrieve SHGetFolderPath */
-        if( ( shfolder_dll = LoadLibrary( _T("SHFolder.dll") ) ) != NULL )
+        psz_path = vout_snapshot_GetDirectory();
+        if( !psz_path )
         {
-           wchar_t wdir[PATH_MAX];
-           SHGetFolderPath = (void *)GetProcAddress( shfolder_dll,
-                                                      _T("SHGetFolderPathW") );
-            if ((SHGetFolderPath != NULL )
-             && SUCCEEDED (SHGetFolderPath (NULL,
-                                           CSIDL_MYPICTURES | CSIDL_FLAG_CREATE,
-                                           NULL, SHGFP_TYPE_CURRENT,
-                                           wdir)))
-                p_mypicturesdir = FromWide (wdir);
-
-            FreeLibrary( shfolder_dll );
-        }
-
-        if( p_mypicturesdir == NULL )
-        {
-            asprintf( &val.psz_string, "%s\\" CONFIG_DIR,
-                      p_vout->p_libvlc->psz_homedir );
-        }
-        else
-        {
-            asprintf( &val.psz_string, p_mypicturesdir );
-            free( p_mypicturesdir );
+            msg_Err( p_vout, "no path specified for snapshots" );
+            goto exit;
         }
     }
 
-#else
-    if( !val.psz_string && p_vout->p_libvlc->psz_homedir )
-    {
-        asprintf( &val.psz_string, "%s/" CONFIG_DIR,
-                  p_vout->p_libvlc->psz_homedir );
-    }
-#endif
+    vout_snapshot_save_cfg_t cfg;
+    memset( &cfg, 0, sizeof(cfg) );
+    cfg.is_sequential = var_InheritBool( p_vout, "snapshot-sequential" );
+    cfg.sequence = var_GetInteger( p_vout, "snapshot-num" );
+    cfg.path = psz_path;
+    cfg.format = psz_format;
+    cfg.prefix_fmt = psz_prefix;
 
-    if( !val.psz_string )
-    {
-        msg_Err( p_vout, "no path specified for snapshots" );
-        return VLC_EGENERIC;
-    }
-    var_Get( p_vout, "snapshot-format", &format );
-    if( !format.psz_string || !*format.psz_string )
-    {
-        if( format.psz_string ) free( format.psz_string );
-        format.psz_string = strdup( "png" );
-    }
+    char *psz_filename;
+    int  i_sequence;
+    if (vout_snapshot_SaveImage( &psz_filename, &i_sequence,
+                                 p_image, VLC_OBJECT(p_vout), &cfg ) )
+        goto exit;
+    if( cfg.is_sequential )
+        var_SetInteger( p_vout, "snapshot-num", i_sequence + 1 );
 
-    /*
-     * Did the user specify a directory? If not, path = NULL.
-     */
-    path = utf8_opendir ( (const char *)val.psz_string  );
+    VoutOsdSnapshot( p_vout, p_picture, psz_filename );
 
-    if ( path != NULL )
-    {
-        char *psz_prefix = var_GetString( p_vout, "snapshot-prefix" );
-        if( !psz_prefix ) psz_prefix = strdup( "vlcsnap-" );
-        else
-        {
-            char *psz_tmp = str_format( p_vout, psz_prefix );
-            filename_sanitize( psz_tmp );
-            free( psz_prefix );
-            psz_prefix = psz_tmp;
-        }
+    /* signal creation of a new snapshot file */
+    var_SetString( p_vout->p_libvlc, "snapshot-file", psz_filename );
 
-        closedir( path );
-        if( var_GetBool( p_vout, "snapshot-sequential" ) == VLC_TRUE )
-        {
-            int i_num = var_GetInteger( p_vout, "snapshot-num" );
-            FILE *p_file;
-            do
-            {
-                asprintf( &psz_filename, "%s" DIR_SEP "%s%05d.%s", val.psz_string,
-                          psz_prefix, i_num++, format.psz_string );
-            }
-            while( ( p_file = utf8_fopen( psz_filename, "r" ) ) && !fclose( p_file ) );
-            var_SetInteger( p_vout, "snapshot-num", i_num );
-        }
-        else
-        {
-            asprintf( &psz_filename, "%s" DIR_SEP "%s%u.%s", val.psz_string,
-                      psz_prefix,
-                      (unsigned int)(p_pic->date / 100000) & 0xFFFFFF,
-                      format.psz_string );
-        }
+    free( psz_filename );
 
-        free( psz_prefix );
-    }
-    else // The user specified a full path name (including file name)
-    {
-        psz_filename = str_format( p_vout, val.psz_string );
-        path_sanitize( psz_filename );
-    }
+exit:
+    if( p_image )
+        block_Release( p_image );
+    if( p_picture )
+        picture_Release( p_picture );
+    free( psz_prefix );
+    free( psz_format );
+    free( psz_path );
+}
 
-    free( val.psz_string );
-    free( format.psz_string );
+/*****************************************************************************
+ * Handle filters
+ *****************************************************************************/
+
+void vout_EnableFilter( vout_thread_t *p_vout, const char *psz_name,
+                        bool b_add, bool b_setconfig )
+{
+    char *psz_parser;
+    char *psz_string;
+    const char *psz_filter_type;
 
-    /* Save the snapshot */
-    fmt_in = p_vout->fmt_in;
-    fmt_out.i_sar_num = fmt_out.i_sar_den = 1;
-    i_ret = image_WriteUrl( p_image, p_pic, &fmt_in, &fmt_out, psz_filename );
-    if( i_ret != VLC_SUCCESS )
+    module_t *p_obj = module_find( psz_name );
+    if( !p_obj )
     {
-        msg_Err( p_vout, "could not create snapshot %s", psz_filename );
-        free( psz_filename );
-        image_HandlerDelete( p_image );
-        return VLC_EGENERIC;
+        msg_Err( p_vout, "Unable to find filter module \"%s\".", psz_name );
+        return;
     }
 
-    msg_Dbg( p_vout, "snapshot taken (%s)", psz_filename );
-    vout_OSDMessage( VLC_OBJECT( p_vout ), DEFAULT_CHAN,
-                     "%s", psz_filename );
-    free( psz_filename );
-
-    if( var_GetBool( p_vout, "snapshot-preview" ) )
+    if( module_provides( p_obj, "video filter2" ) )
     {
-        /* Inject a subpicture with the snapshot */
-        memset( &fmt_out, 0, sizeof(fmt_out) );
-        fmt_out.i_chroma = VLC_FOURCC('Y','U','V','A');
-        p_pif = image_Convert( p_image, p_pic, &fmt_in, &fmt_out );
-        image_HandlerDelete( p_image );
-        if( !p_pif ) return VLC_EGENERIC;
-
-        p_subpic = spu_CreateSubpicture( p_vout->p_spu );
-        if( p_subpic == NULL )
-        {
-             p_pif->pf_release( p_pif );
-             return VLC_EGENERIC;
-        }
-
-        p_subpic->i_channel = 0;
-        p_subpic->i_start = mdate();
-        p_subpic->i_stop = mdate() + 4000000;
-        p_subpic->b_ephemer = VLC_TRUE;
-        p_subpic->b_fade = VLC_TRUE;
-        p_subpic->i_original_picture_width = p_vout->render.i_width * 4;
-        p_subpic->i_original_picture_height = p_vout->render.i_height * 4;
-
-        p_subpic->p_region = spu_CreateRegion( p_vout->p_spu, &fmt_out );
-        vout_CopyPicture( p_image->p_parent, &p_subpic->p_region->picture,
-                          p_pif );
-        p_pif->pf_release( p_pif );
-
-        spu_DisplaySubpicture( p_vout->p_spu, p_subpic );
+        psz_filter_type = "video-filter";
+    }
+    else if( module_provides( p_obj, "sub source" ) )
+    {
+        psz_filter_type = "sub-source";
+    }
+    else if( module_provides( p_obj, "sub filter" ) )
+    {
+        psz_filter_type = "sub-filter";
     }
     else
     {
-        image_HandlerDelete( p_image );
+        msg_Err( p_vout, "Unknown video filter type." );
+        return;
     }
 
-    return VLC_SUCCESS;
-}
-
-/*****************************************************************************
- * Handle filters
- *****************************************************************************/
-
-void vout_EnableFilter( vout_thread_t *p_vout, char *psz_name,
-                        vlc_bool_t b_add, vlc_bool_t b_setconfig )
-{
-    char *psz_parser;
-    char *psz_string = config_GetPsz( p_vout, "vout-filter" );
+    psz_string = var_GetString( p_vout, psz_filter_type );
 
     /* Todo : Use some generic chain manipulation functions */
     if( !psz_string ) psz_string = strdup("");
@@ -751,8 +492,12 @@ void vout_EnableFilter( vout_thread_t *p_vout, char *psz_name,
         if( !psz_parser )
         {
             psz_parser = psz_string;
-            asprintf( &psz_string, (*psz_string) ? "%s:%s" : "%s%s",
-                            psz_string, psz_name );
+            if( asprintf( &psz_string, (*psz_string) ? "%s:%s" : "%s%s",
+                          psz_string, psz_name ) == -1 )
+            {
+                free( psz_parser );
+                return;
+            }
             free( psz_parser );
         }
         else
@@ -778,369 +523,171 @@ void vout_EnableFilter( vout_thread_t *p_vout, char *psz_name,
              return;
          }
     }
+
     if( b_setconfig )
-        config_PutPsz( p_vout, "vout-filter", psz_string );
+    {
+        config_PutPsz( p_vout, psz_filter_type, psz_string );
+    }
+
+    var_SetString( p_vout, psz_filter_type, psz_string );
 
-    var_SetString( p_vout, "vout-filter", psz_string );
     free( psz_string );
 }
 
 /*****************************************************************************
- * vout_ControlDefault: default methods for video output control.
+ * Object variables callbacks
  *****************************************************************************/
-int vout_vaControlDefault( vout_thread_t *p_vout, int i_query, va_list args )
+static int CropCallback( vlc_object_t *object, char const *cmd,
+                         vlc_value_t oldval, vlc_value_t newval, void *data )
 {
-    switch( i_query )
-    {
-    case VOUT_REPARENT:
-    case VOUT_CLOSE:
-        if( p_vout->p_parent_intf )
-        {
-            vlc_object_release( p_vout->p_parent_intf );
-            p_vout->p_parent_intf = NULL;
-        }
-        return VLC_SUCCESS;
-        break;
-
-    case VOUT_SNAPSHOT:
-        p_vout->b_snapshot = VLC_TRUE;
-        return VLC_SUCCESS;
-        break;
-
-    default:
-        msg_Dbg( p_vout, "control query not supported" );
-        return VLC_EGENERIC;
+    vout_thread_t *vout = (vout_thread_t *)object;
+    VLC_UNUSED(cmd); VLC_UNUSED(oldval); VLC_UNUSED(data);
+    unsigned num, den;
+    unsigned y, x;
+    unsigned width, height;
+    unsigned left, top, right, bottom;
+
+    if (sscanf(newval.psz_string, "%u:%u", &num, &den) == 2) {
+        vout_ControlChangeCropRatio(vout, num, den);
+    } else if (sscanf(newval.psz_string, "%ux%u+%u+%u",
+                      &width, &height, &x, &y) == 4) {
+        vout_ControlChangeCropWindow(vout, x, y, width, height);
+    } else if (sscanf(newval.psz_string, "%u+%u+%u+%u",
+                    &left, &top, &right, &bottom) == 4) {
+        vout_ControlChangeCropBorder(vout, left, top, right, bottom);
+    } else if (*newval.psz_string == '\0') {
+        vout_ControlChangeCropRatio(vout, 0, 0);
+    } else {
+        msg_Err(object, "Unknown crop format (%s)", newval.psz_string);
     }
+    return VLC_SUCCESS;
 }
 
-/*****************************************************************************
- * InitWindowSize: find the initial dimensions the video window should have.
- *****************************************************************************
- * This function will check the "width", "height" and "zoom" config options and
- * will calculate the size that the video window should have.
- *****************************************************************************/
-static void InitWindowSize( vout_thread_t *p_vout, unsigned *pi_width,
-                            unsigned *pi_height )
+static int CropBorderCallback(vlc_object_t *object, char const *cmd,
+                              vlc_value_t oldval, vlc_value_t newval, void *data)
 {
-    vlc_value_t val;
-    int i_width, i_height;
-    uint64_t ll_zoom;
+    vout_thread_t *vout = (vout_thread_t *)object;
+    VLC_UNUSED(cmd); VLC_UNUSED(oldval); VLC_UNUSED(data); VLC_UNUSED(newval);
+
+    vout_ControlChangeCropBorder(vout,
+                                 var_GetInteger(object, "crop-left"),
+                                 var_GetInteger(object, "crop-top"),
+                                 var_GetInteger(object, "crop-right"),
+                                 var_GetInteger(object, "crop-bottom"));
+    return VLC_SUCCESS;
+}
 
-#define FP_FACTOR 1000                             /* our fixed point factor */
+static int AspectCallback( vlc_object_t *object, char const *cmd,
+                         vlc_value_t oldval, vlc_value_t newval, void *data )
+{
+    vout_thread_t *vout = (vout_thread_t *)object;
+    VLC_UNUSED(cmd); VLC_UNUSED(oldval); VLC_UNUSED(data);
+    unsigned num, den;
+
+    if (sscanf(newval.psz_string, "%u:%u", &num, &den) == 2 &&
+        (num > 0) == (den > 0))
+        vout_ControlChangeSampleAspectRatio(vout, num, den);
+    else if (*newval.psz_string == '\0')
+        vout_ControlChangeSampleAspectRatio(vout, 0, 0);
+    return VLC_SUCCESS;
+}
 
-    var_Get( p_vout, "width", &val );
-    i_width = val.i_int;
-    var_Get( p_vout, "height", &val );
-    i_height = val.i_int;
-    var_Get( p_vout, "zoom", &val );
-    ll_zoom = (uint64_t)( FP_FACTOR * val.f_float );
+static int AutoScaleCallback( vlc_object_t *obj, char const *name,
+                              vlc_value_t prev, vlc_value_t cur, void *data )
+{
+    vout_thread_t *p_vout = (vout_thread_t *)obj;
 
-    if( i_width > 0 && i_height > 0)
-    {
-        *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
-        *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
-        goto initwsize_end;
-    }
-    else if( i_width > 0 )
-    {
-        *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
-        *pi_height = (int)( p_vout->fmt_in.i_visible_height * ll_zoom *
-            p_vout->fmt_in.i_sar_den * i_width / p_vout->fmt_in.i_sar_num /
-            FP_FACTOR / p_vout->fmt_in.i_visible_width );
-        goto initwsize_end;
-    }
-    else if( i_height > 0 )
-    {
-        *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
-        *pi_width = (int)( p_vout->fmt_in.i_visible_width * ll_zoom *
-            p_vout->fmt_in.i_sar_num * i_height / p_vout->fmt_in.i_sar_den /
-            FP_FACTOR / p_vout->fmt_in.i_visible_height );
-        goto initwsize_end;
-    }
+    (void) name; (void) prev; (void) data;
+    vout_ControlChangeDisplayFilled( p_vout, cur.b_bool );
+    return VLC_SUCCESS;
+}
 
-    if( p_vout->fmt_in.i_sar_num >= p_vout->fmt_in.i_sar_den )
-    {
-        *pi_width = (int)( p_vout->fmt_in.i_visible_width * ll_zoom *
-            p_vout->fmt_in.i_sar_num / p_vout->fmt_in.i_sar_den / FP_FACTOR );
-        *pi_height = (int)( p_vout->fmt_in.i_visible_height * ll_zoom 
-            / FP_FACTOR );
-    }
-    else
-    {
-        *pi_width = (int)( p_vout->fmt_in.i_visible_width * ll_zoom 
-            / FP_FACTOR );
-        *pi_height = (int)( p_vout->fmt_in.i_visible_height * ll_zoom *
-            p_vout->fmt_in.i_sar_den / p_vout->fmt_in.i_sar_num / FP_FACTOR );
-    }
+static int ScaleCallback( vlc_object_t *obj, char const *name,
+                          vlc_value_t prev, vlc_value_t cur, void *data )
+{
+    vout_thread_t *p_vout = (vout_thread_t *)obj;
 
-initwsize_end:
-    msg_Dbg( p_vout, "window size: %dx%d", p_vout->i_window_width, 
-             p_vout->i_window_height );
+    (void) name; (void) prev; (void) data;
+    vout_ControlChangeZoom( p_vout, 1000 * cur.f_float, 1000 );
+    return VLC_SUCCESS;
+}
 
-#undef FP_FACTOR
+static int ZoomCallback( vlc_object_t *obj, char const *name,
+                         vlc_value_t prev, vlc_value_t cur, void *data )
+{
+    (void) name; (void) prev; (void) data;
+    return var_SetFloat( obj, "scale", cur.f_float );
 }
 
-/*****************************************************************************
- * Object variables callbacks
- *****************************************************************************/
-static int ZoomCallback( vlc_object_t *p_this, char const *psz_cmd,
+static int OnTopCallback( vlc_object_t *p_this, char const *psz_cmd,
                          vlc_value_t oldval, vlc_value_t newval, void *p_data )
 {
     vout_thread_t *p_vout = (vout_thread_t *)p_this;
-    InitWindowSize( p_vout, &p_vout->i_window_width,
-                    &p_vout->i_window_height );
-    vout_Control( p_vout, VOUT_SET_SIZE, p_vout->i_window_width,
-                  p_vout->i_window_height );
+    (void)psz_cmd; (void)oldval; (void)p_data;
+
+    vout_ControlChangeOnTop( p_vout, newval.b_bool );
     return VLC_SUCCESS;
 }
 
-static int CropCallback( vlc_object_t *p_this, char const *psz_cmd,
-                         vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int FullscreenCallback( vlc_object_t *p_this, char const *psz_cmd,
+                       vlc_value_t oldval, vlc_value_t newval, void *p_data )
 {
     vout_thread_t *p_vout = (vout_thread_t *)p_this;
-    int64_t i_aspect_num, i_aspect_den;
-    unsigned int i_width, i_height;
-
-    /* Restore defaults */
-    p_vout->fmt_in.i_x_offset = p_vout->fmt_render.i_x_offset;
-    p_vout->fmt_in.i_visible_width = p_vout->fmt_render.i_visible_width;
-    p_vout->fmt_in.i_y_offset = p_vout->fmt_render.i_y_offset;
-    p_vout->fmt_in.i_visible_height = p_vout->fmt_render.i_visible_height;
-
-    if( !strcmp( psz_cmd, "crop" ) )
-    {
-        char *psz_end = NULL, *psz_parser = strchr( newval.psz_string, ':' );
-        if( psz_parser )
-        {
-            /* We're using the 3:4 syntax */
-            i_aspect_num = strtol( newval.psz_string, &psz_end, 10 );
-            if( psz_end == newval.psz_string || !i_aspect_num ) goto crop_end;
-
-            i_aspect_den = strtol( ++psz_parser, &psz_end, 10 );
-            if( psz_end == psz_parser || !i_aspect_den ) goto crop_end;
-
-            i_width = p_vout->fmt_in.i_sar_den*p_vout->fmt_render.i_visible_height *
-                i_aspect_num / i_aspect_den / p_vout->fmt_in.i_sar_num;
-            i_height = p_vout->fmt_render.i_visible_width*p_vout->fmt_in.i_sar_num *
-                i_aspect_den / i_aspect_num / p_vout->fmt_in.i_sar_den;
-
-            if( i_width < p_vout->fmt_render.i_visible_width )
-            {
-                p_vout->fmt_in.i_x_offset = p_vout->fmt_render.i_x_offset +
-                    (p_vout->fmt_render.i_visible_width - i_width) / 2;
-                p_vout->fmt_in.i_visible_width = i_width;
-            }
-            else
-            {
-                p_vout->fmt_in.i_y_offset = p_vout->fmt_render.i_y_offset +
-                    (p_vout->fmt_render.i_visible_height - i_height) / 2;
-                p_vout->fmt_in.i_visible_height = i_height;
-            }
-        }
-        else
-        {
-            psz_parser = strchr( newval.psz_string, 'x' );
-            if( psz_parser )
-            {
-                /* Maybe we're using the <width>x<height>+<left>+<top> syntax */
-                unsigned int i_crop_width, i_crop_height, i_crop_top, i_crop_left;
-
-                i_crop_width = strtol( newval.psz_string, &psz_end, 10 );
-                if( psz_end != psz_parser ) goto crop_end;
-
-                psz_parser = strchr( ++psz_end, '+' );
-                i_crop_height = strtol( psz_end, &psz_end, 10 );
-                if( psz_end != psz_parser ) goto crop_end;
-
-                psz_parser = strchr( ++psz_end, '+' );
-                i_crop_left = strtol( psz_end, &psz_end, 10 );
-                if( psz_end != psz_parser ) goto crop_end;
-
-                psz_end++;
-                i_crop_top = strtol( psz_end, &psz_end, 10 );
-                if( *psz_end != '\0' ) goto crop_end;
-
-                i_width = i_crop_width;
-                p_vout->fmt_in.i_visible_width = i_width;
-
-                i_height = i_crop_height;
-                p_vout->fmt_in.i_visible_height = i_height;
-
-                p_vout->fmt_in.i_x_offset = i_crop_left;
-                p_vout->fmt_in.i_y_offset = i_crop_top;
-            }
-            else
-            {
-                /* Maybe we're using the <left>+<top>+<right>+<bottom> syntax */
-                unsigned int i_crop_top, i_crop_left, i_crop_bottom, i_crop_right;
-
-                psz_parser = strchr( newval.psz_string, '+' );
-                i_crop_left = strtol( newval.psz_string, &psz_end, 10 );
-                if( psz_end != psz_parser ) goto crop_end;
-
-                psz_parser = strchr( ++psz_end, '+' );
-                i_crop_top = strtol( psz_end, &psz_end, 10 );
-                if( psz_end != psz_parser ) goto crop_end;
-
-                psz_parser = strchr( ++psz_end, '+' );
-                i_crop_right = strtol( psz_end, &psz_end, 10 );
-                if( psz_end != psz_parser ) goto crop_end;
-
-                psz_end++;
-                i_crop_bottom = strtol( psz_end, &psz_end, 10 );
-                if( *psz_end != '\0' ) goto crop_end;
-
-                i_width = p_vout->fmt_render.i_visible_width
-                          - i_crop_left - i_crop_right;
-                p_vout->fmt_in.i_visible_width = i_width;
-
-                i_height = p_vout->fmt_render.i_visible_height
-                           - i_crop_top - i_crop_bottom;
-                p_vout->fmt_in.i_visible_height = i_height;
-
-                p_vout->fmt_in.i_x_offset = i_crop_left;
-                p_vout->fmt_in.i_y_offset = i_crop_top;
-            }
-        }
-    }
-    else if( !strcmp( psz_cmd, "crop-top" )
-          || !strcmp( psz_cmd, "crop-left" )
-          || !strcmp( psz_cmd, "crop-bottom" )
-          || !strcmp( psz_cmd, "crop-right" ) )
-    {
-        unsigned int i_crop_top, i_crop_left, i_crop_bottom, i_crop_right;
-
-        i_crop_top = var_GetInteger( p_vout, "crop-top" );
-        i_crop_left = var_GetInteger( p_vout, "crop-left" );
-        i_crop_right = var_GetInteger( p_vout, "crop-right" );
-        i_crop_bottom = var_GetInteger( p_vout, "crop-bottom" );
-
-        i_width = p_vout->fmt_render.i_visible_width
-                  - i_crop_left - i_crop_right;
-        p_vout->fmt_in.i_visible_width = i_width;
-
-        i_height = p_vout->fmt_render.i_visible_height
-                   - i_crop_top - i_crop_bottom;
-        p_vout->fmt_in.i_visible_height = i_height;
-
-        p_vout->fmt_in.i_x_offset = i_crop_left;
-        p_vout->fmt_in.i_y_offset = i_crop_top;
-    }
-
- crop_end:
-    InitWindowSize( p_vout, &p_vout->i_window_width,
-                    &p_vout->i_window_height );
-
-    p_vout->i_changes |= VOUT_CROP_CHANGE;
-
-    msg_Dbg( p_vout, "cropping picture %ix%i to %i,%i,%ix%i",
-             p_vout->fmt_in.i_width, p_vout->fmt_in.i_height,
-             p_vout->fmt_in.i_x_offset, p_vout->fmt_in.i_y_offset,
-             p_vout->fmt_in.i_visible_width,
-             p_vout->fmt_in.i_visible_height );
+    (void)psz_cmd; (void)p_data;
 
+    if( oldval.b_bool != newval.b_bool )
+        vout_ControlChangeFullscreen( p_vout, newval.b_bool );
     return VLC_SUCCESS;
 }
 
-static int AspectCallback( vlc_object_t *p_this, char const *psz_cmd,
-                         vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int SnapshotCallback( vlc_object_t *p_this, char const *psz_cmd,
+                       vlc_value_t oldval, vlc_value_t newval, void *p_data )
 {
     vout_thread_t *p_vout = (vout_thread_t *)p_this;
-    unsigned int i_aspect_num, i_aspect_den, i_sar_num, i_sar_den;
-    vlc_value_t val;
-
-    char *psz_end, *psz_parser = strchr( newval.psz_string, ':' );
-
-    /* Restore defaults */
-    p_vout->fmt_in.i_sar_num = p_vout->fmt_render.i_sar_num;
-    p_vout->fmt_in.i_sar_den = p_vout->fmt_render.i_sar_den;
-    p_vout->fmt_in.i_aspect = p_vout->fmt_render.i_aspect;
-    p_vout->render.i_aspect = p_vout->fmt_render.i_aspect;
-
-    if( !psz_parser ) goto aspect_end;
-
-    i_aspect_num = strtol( newval.psz_string, &psz_end, 10 );
-    if( psz_end == newval.psz_string || !i_aspect_num ) goto aspect_end;
-
-    i_aspect_den = strtol( ++psz_parser, &psz_end, 10 );
-    if( psz_end == psz_parser || !i_aspect_den ) goto aspect_end;
-
-    i_sar_num = i_aspect_num * p_vout->fmt_render.i_visible_height;
-    i_sar_den = i_aspect_den * p_vout->fmt_render.i_visible_width;
-    vlc_ureduce( &i_sar_num, &i_sar_den, i_sar_num, i_sar_den, 0 );
-    p_vout->fmt_in.i_sar_num = i_sar_num;
-    p_vout->fmt_in.i_sar_den = i_sar_den;
-    p_vout->fmt_in.i_aspect = i_aspect_num * VOUT_ASPECT_FACTOR / i_aspect_den;
-    p_vout->render.i_aspect = p_vout->fmt_in.i_aspect;
-
- aspect_end:
-    if( p_vout->i_par_num && p_vout->i_par_den )
-    {
-        p_vout->fmt_in.i_sar_num *= p_vout->i_par_den;
-        p_vout->fmt_in.i_sar_den *= p_vout->i_par_num;
-        p_vout->fmt_in.i_aspect = p_vout->fmt_in.i_aspect *
-            p_vout->i_par_den / p_vout->i_par_num;
-        p_vout->render.i_aspect = p_vout->fmt_in.i_aspect;
-    }
-
-    p_vout->i_changes |= VOUT_ASPECT_CHANGE;
-
-    vlc_ureduce( &i_aspect_num, &i_aspect_den,
-                 p_vout->fmt_in.i_aspect, VOUT_ASPECT_FACTOR, 0 );
-    msg_Dbg( p_vout, "new aspect-ratio %i:%i, sample aspect-ratio %i:%i",
-             i_aspect_num, i_aspect_den,
-             p_vout->fmt_in.i_sar_num, p_vout->fmt_in.i_sar_den );
-
-    var_Get( p_vout, "crop", &val );
-    return CropCallback( p_this, "crop", val, val, 0 );
+    VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval);
+    VLC_UNUSED(newval); VLC_UNUSED(p_data);
 
+    VoutSaveSnapshot( p_vout );
     return VLC_SUCCESS;
 }
 
-static int OnTopCallback( vlc_object_t *p_this, char const *psz_cmd,
-                         vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int VideoFilterCallback( vlc_object_t *p_this, char const *psz_cmd,
+                                vlc_value_t oldval, vlc_value_t newval, void *p_data)
 {
     vout_thread_t *p_vout = (vout_thread_t *)p_this;
-    playlist_t *p_playlist = pl_Yield( p_this );
-    vout_Control( p_vout, VOUT_SET_STAY_ON_TOP, newval.b_bool );
-
-    /* Modify playlist as well because the vout might have to be restarted */
-    var_Create( p_playlist, "video-on-top", VLC_VAR_BOOL );
-    var_Set( p_playlist, "video-on-top", newval );
+    VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
 
-    pl_Release( p_this );
+    vout_ControlChangeFilters( p_vout, newval.psz_string );
     return VLC_SUCCESS;
 }
 
-static int FullscreenCallback( vlc_object_t *p_this, char const *psz_cmd,
-                       vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int SubSourceCallback( vlc_object_t *p_this, char const *psz_cmd,
+                              vlc_value_t oldval, vlc_value_t newval, void *p_data)
 {
     vout_thread_t *p_vout = (vout_thread_t *)p_this;
-    vlc_value_t val;
-    playlist_t *p_playlist = pl_Yield( p_this );
+    VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
 
-    p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
-
-    /* Modify playlist as well because the vout might have to be restarted */
-    var_Create( p_playlist, "fullscreen", VLC_VAR_BOOL );
-    var_Set( p_playlist, "fullscreen", newval );
-    pl_Release( p_playlist );
+    vout_ControlChangeSubSources( p_vout, newval.psz_string );
+    return VLC_SUCCESS;
+}
 
-    /* Disable "always on top" in fullscreen mode */
-    var_Get( p_vout, "video-on-top", &val );
-    if( val.b_bool )
-        vout_Control( p_vout, VOUT_SET_STAY_ON_TOP,
-                      (vlc_bool_t)!newval.b_bool );
+static int SubFilterCallback( vlc_object_t *p_this, char const *psz_cmd,
+                              vlc_value_t oldval, vlc_value_t newval, void *p_data)
+{
+    vout_thread_t *p_vout = (vout_thread_t *)p_this;
+    VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
 
-    val.b_bool = VLC_TRUE;
-    var_Set( p_vout, "intf-change", val );
+    vout_ControlChangeSubFilters( p_vout, newval.psz_string );
     return VLC_SUCCESS;
 }
 
-static int SnapshotCallback( vlc_object_t *p_this, char const *psz_cmd,
-                       vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int SubMarginCallback( vlc_object_t *p_this, char const *psz_cmd,
+                              vlc_value_t oldval, vlc_value_t newval, void *p_data)
 {
     vout_thread_t *p_vout = (vout_thread_t *)p_this;
-    vout_Control( p_vout, VOUT_SNAPSHOT );
+    VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
+
+    vout_ControlChangeSubMargin( p_vout, newval.i_int );
     return VLC_SUCCESS;
 }
+