/*****************************************************************************
* vout_intf.c : video output interface
*****************************************************************************
- * Copyright (C) 2000-2007 the VideoLAN team
+ * Copyright (C) 2000-2007 VLC authors and VideoLAN
*
* Authors: Gildas Bazin <gbazin@videolan.org>
*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; either version 2.1 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
*****************************************************************************/
/*****************************************************************************
#include <stdio.h>
#include <stdlib.h> /* free() */
-#include <sys/types.h> /* opendir() */
-#include <dirent.h> /* opendir() */
#include <assert.h>
-#include <time.h> /* strftime */
-#include <vlc_interface.h>
#include <vlc_block.h>
-#include <vlc_playlist.h>
+#include <vlc_modules.h>
#include <vlc_vout.h>
-#include <vlc_image.h>
-#include <vlc_osd.h>
+#include <vlc_vout_osd.h>
#include <vlc_strings.h>
#include <vlc_charset.h>
-#include "../libvlc.h"
#include "vout_internal.h"
/*****************************************************************************
* Local prototypes
*****************************************************************************/
-static void InitWindowSize( vout_thread_t *, unsigned *, unsigned * );
-
/* Object variables callbacks */
-static int ZoomCallback( vlc_object_t *, char const *,
- vlc_value_t, vlc_value_t, void * );
static int CropCallback( vlc_object_t *, char const *,
vlc_value_t, vlc_value_t, void * );
+static int CropBorderCallback( vlc_object_t *, char const *,
+ vlc_value_t, vlc_value_t, void * );
static int AspectCallback( vlc_object_t *, char const *,
vlc_value_t, vlc_value_t, void * );
-static int ScalingCallback( vlc_object_t *, char const *,
- vlc_value_t, vlc_value_t, void * );
-static int OnTopCallback( vlc_object_t *, char const *,
+static int AutoScaleCallback( vlc_object_t *, char const *,
+ vlc_value_t, vlc_value_t, void * );
+static int ZoomCallback( vlc_object_t *, char const *,
+ vlc_value_t, vlc_value_t, void * );
+static int AboveCallback( vlc_object_t *, char const *,
vlc_value_t, vlc_value_t, void * );
+static int WallPaperCallback( vlc_object_t *, char const *,
+ vlc_value_t, vlc_value_t, void * );
static int FullscreenCallback( vlc_object_t *, char const *,
vlc_value_t, vlc_value_t, void * );
static int SnapshotCallback( vlc_object_t *, char const *,
vlc_value_t, vlc_value_t, void * );
-
-static int TitleShowCallback( vlc_object_t *, char const *,
+static int VideoFilterCallback( vlc_object_t *, char const *,
+ vlc_value_t, vlc_value_t, void * );
+static int SubSourceCallback( vlc_object_t *, char const *,
+ vlc_value_t, vlc_value_t, void * );
+static int SubFilterCallback( vlc_object_t *, char const *,
+ vlc_value_t, vlc_value_t, void * );
+static int SubMarginCallback( vlc_object_t *, char const *,
vlc_value_t, vlc_value_t, void * );
-static int TitleTimeoutCallback( vlc_object_t *, char const *,
- vlc_value_t, vlc_value_t, void * );
-static int TitlePositionCallback( vlc_object_t *, char const *,
- vlc_value_t, vlc_value_t, void * );
/*****************************************************************************
* vout_IntfInit: called during the vout creation to initialise misc things.
static const struct
{
double f_value;
- const char *psz_label;
+ char psz_label[13];
} p_zoom_values[] = {
{ 0.25, N_("1:4 Quarter") },
{ 0.5, N_("1:2 Half") },
{ 1, N_("1:1 Original") },
{ 2, N_("2:1 Double") },
- { 0, NULL } };
+};
static const struct
{
- const char *psz_value;
- const char *psz_label;
+ char psz_value[8];
+ char psz_label[8];
} p_crop_values[] = {
{ "", N_("Default") },
{ "16:10", "16:10" },
{ "16:9", "16:9" },
+ { "4:3", "4:3" },
{ "185:100", "1.85:1" },
{ "221:100", "2.21:1" },
{ "235:100", "2.35:1" },
{ "239:100", "2.39:1" },
{ "5:3", "5:3" },
- { "4:3", "4:3" },
{ "5:4", "5:4" },
{ "1:1", "1:1" },
- { NULL, NULL } };
+};
static const struct
{
- const char *psz_value;
- const char *psz_label;
+ char psz_value[8];
+ char psz_label[8];
} p_aspect_ratio_values[] = {
{ "", N_("Default") },
- { "1:1", "1:1" },
- { "4:3", "4:3" },
{ "16:9", "16:9" },
+ { "4:3", "4:3" },
+ { "1:1", "1:1" },
{ "16:10", "16:10" },
{ "221:100", "2.21:1" },
{ "235:100", "2.35:1" },
{ "239:100", "2.39:1" },
{ "5:4", "5:4" },
- { NULL, NULL } };
+};
static void AddCustomRatios( vout_thread_t *p_vout, const char *psz_var,
char *psz_list )
void vout_IntfInit( vout_thread_t *p_vout )
{
- vlc_value_t val, text, old_val;
- bool b_force_par = false;
+ vlc_value_t val, text;
char *psz_buf;
- int i;
/* Create a few object variables we'll need later on */
- var_Create( p_vout, "snapshot-path", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-prefix", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-format", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-preview", VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-sequential",
- VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
var_Create( p_vout, "snapshot-num", VLC_VAR_INTEGER );
var_SetInteger( p_vout, "snapshot-num", 1 );
- var_Create( p_vout, "snapshot-width", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-height", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
var_Create( p_vout, "width", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
var_Create( p_vout, "height", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
- p_vout->i_alignment = var_CreateGetInteger( p_vout, "align" );
-
- var_Create( p_vout, "video-x", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "video-y", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
+ var_Create( p_vout, "align", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
var_Create( p_vout, "mouse-hide-timeout",
VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
- p_vout->p->b_title_show = var_CreateGetBool( p_vout, "video-title-show" );
- p_vout->p->i_title_timeout =
- (mtime_t)var_CreateGetInteger( p_vout, "video-title-timeout" );
- p_vout->p->i_title_position =
- var_CreateGetInteger( p_vout, "video-title-position" );
- p_vout->p->psz_title = NULL;
-
- var_AddCallback( p_vout, "video-title-show", TitleShowCallback, NULL );
- var_AddCallback( p_vout, "video-title-timeout", TitleTimeoutCallback, NULL );
- var_AddCallback( p_vout, "video-title-position", TitlePositionCallback, NULL );
+ /* Add variables to manage scaling video */
+ var_Create( p_vout, "autoscale", VLC_VAR_BOOL | VLC_VAR_DOINHERIT
+ | VLC_VAR_ISCOMMAND );
+ text.psz_string = _("Autoscale video");
+ var_Change( p_vout, "autoscale", VLC_VAR_SETTEXT, &text, NULL );
+ var_AddCallback( p_vout, "autoscale", AutoScaleCallback, NULL );
- /* Zoom object var */
var_Create( p_vout, "zoom", VLC_VAR_FLOAT | VLC_VAR_ISCOMMAND |
- VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT );
+ VLC_VAR_DOINHERIT );
text.psz_string = _("Zoom");
var_Change( p_vout, "zoom", VLC_VAR_SETTEXT, &text, NULL );
- var_Get( p_vout, "zoom", &old_val );
-
- for( i = 0; p_zoom_values[i].f_value; i++ )
+ for( size_t i = 0; i < ARRAY_SIZE(p_zoom_values); i++ )
{
- if( old_val.f_float == p_zoom_values[i].f_value )
- var_Change( p_vout, "zoom", VLC_VAR_DELCHOICE, &old_val, NULL );
val.f_float = p_zoom_values[i].f_value;
- text.psz_string = _( p_zoom_values[i].psz_label );
+ text.psz_string = vlc_gettext( p_zoom_values[i].psz_label );
var_Change( p_vout, "zoom", VLC_VAR_ADDCHOICE, &val, &text );
}
- var_Set( p_vout, "zoom", old_val ); /* Is this really needed? */
-
var_AddCallback( p_vout, "zoom", ZoomCallback, NULL );
/* Crop offset vars */
var_Create( p_vout, "crop-right", VLC_VAR_INTEGER | VLC_VAR_ISCOMMAND );
var_Create( p_vout, "crop-bottom", VLC_VAR_INTEGER | VLC_VAR_ISCOMMAND );
- var_AddCallback( p_vout, "crop-left", CropCallback, NULL );
- var_AddCallback( p_vout, "crop-top", CropCallback, NULL );
- var_AddCallback( p_vout, "crop-right", CropCallback, NULL );
- var_AddCallback( p_vout, "crop-bottom", CropCallback, NULL );
+ var_AddCallback( p_vout, "crop-left", CropBorderCallback, NULL );
+ var_AddCallback( p_vout, "crop-top", CropBorderCallback, NULL );
+ var_AddCallback( p_vout, "crop-right", CropBorderCallback, NULL );
+ var_AddCallback( p_vout, "crop-bottom", CropBorderCallback, NULL );
/* Crop object var */
var_Create( p_vout, "crop", VLC_VAR_STRING | VLC_VAR_ISCOMMAND |
- VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT );
+ VLC_VAR_DOINHERIT );
text.psz_string = _("Crop");
var_Change( p_vout, "crop", VLC_VAR_SETTEXT, &text, NULL );
- val.psz_string = (char*)"";
- var_Change( p_vout, "crop", VLC_VAR_DELCHOICE, &val, 0 );
-
- for( i = 0; p_crop_values[i].psz_value; i++ )
+ for( size_t i = 0; i < ARRAY_SIZE(p_crop_values); i++ )
{
val.psz_string = (char*)p_crop_values[i].psz_value;
text.psz_string = _( p_crop_values[i].psz_label );
var_Change( p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &text );
}
- /* update triggered every time the vout's crop parameters are changed */
- var_Create( p_vout, "crop-update", VLC_VAR_VOID );
-
/* Add custom crop ratios */
psz_buf = var_CreateGetNonEmptyString( p_vout, "custom-crop-ratios" );
if( psz_buf )
}
var_AddCallback( p_vout, "crop", CropCallback, NULL );
- var_Get( p_vout, "crop", &old_val );
- if( old_val.psz_string && *old_val.psz_string )
- var_TriggerCallback( p_vout, "crop" );
- free( old_val.psz_string );
/* Monitor pixel aspect-ratio */
var_Create( p_vout, "monitor-par", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
- var_Get( p_vout, "monitor-par", &val );
- if( val.psz_string && *val.psz_string )
- {
- char *psz_parser = strchr( val.psz_string, ':' );
- unsigned int i_aspect_num = 0, i_aspect_den = 0;
- float i_aspect = 0;
- if( psz_parser )
- {
- i_aspect_num = strtol( val.psz_string, 0, 10 );
- i_aspect_den = strtol( ++psz_parser, 0, 10 );
- }
- else
- {
- i_aspect = us_atof( val.psz_string );
- vlc_ureduce( &i_aspect_num, &i_aspect_den,
- i_aspect *VOUT_ASPECT_FACTOR, VOUT_ASPECT_FACTOR, 0 );
- }
- if( !i_aspect_num || !i_aspect_den ) i_aspect_num = i_aspect_den = 1;
-
- p_vout->p->i_par_num = i_aspect_num;
- p_vout->p->i_par_den = i_aspect_den;
-
- vlc_ureduce( &p_vout->p->i_par_num, &p_vout->p->i_par_den,
- p_vout->p->i_par_num, p_vout->p->i_par_den, 0 );
-
- msg_Dbg( p_vout, "overriding monitor pixel aspect-ratio: %i:%i",
- p_vout->p->i_par_num, p_vout->p->i_par_den );
- b_force_par = true;
- }
- free( val.psz_string );
/* Aspect-ratio object var */
var_Create( p_vout, "aspect-ratio", VLC_VAR_STRING | VLC_VAR_ISCOMMAND |
- VLC_VAR_HASCHOICE | VLC_VAR_DOINHERIT );
+ VLC_VAR_DOINHERIT );
- text.psz_string = _("Aspect-ratio");
+ text.psz_string = _("Aspect ratio");
var_Change( p_vout, "aspect-ratio", VLC_VAR_SETTEXT, &text, NULL );
- val.psz_string = (char*)"";
- var_Change( p_vout, "aspect-ratio", VLC_VAR_DELCHOICE, &val, 0 );
-
- for( i = 0; p_aspect_ratio_values[i].psz_value; i++ )
+ for( size_t i = 0; i < ARRAY_SIZE(p_aspect_ratio_values); i++ )
{
val.psz_string = (char*)p_aspect_ratio_values[i].psz_value;
text.psz_string = _( p_aspect_ratio_values[i].psz_label );
}
var_AddCallback( p_vout, "aspect-ratio", AspectCallback, NULL );
- var_Get( p_vout, "aspect-ratio", &old_val );
- if( (old_val.psz_string && *old_val.psz_string) || b_force_par )
- var_TriggerCallback( p_vout, "aspect-ratio" );
- free( old_val.psz_string );
-
- /* Add variables to manage scaling video */
- var_Create( p_vout, "autoscale", VLC_VAR_BOOL | VLC_VAR_DOINHERIT
- | VLC_VAR_ISCOMMAND );
- text.psz_string = _("Autoscale video");
- var_Change( p_vout, "autoscale", VLC_VAR_SETTEXT, &text, NULL );
- var_AddCallback( p_vout, "autoscale", ScalingCallback, NULL );
- p_vout->b_autoscale = var_GetBool( p_vout, "autoscale" );
-
- var_Create( p_vout, "scale", VLC_VAR_FLOAT | VLC_VAR_DOINHERIT
- | VLC_VAR_ISCOMMAND );
- text.psz_string = _("Scale factor");
- var_Change( p_vout, "scale", VLC_VAR_SETTEXT, &text, NULL );
- var_AddCallback( p_vout, "scale", ScalingCallback, NULL );
- p_vout->i_zoom = (int)( ZOOM_FP_FACTOR * var_GetFloat( p_vout, "scale" ) );
-
- /* Initialize the dimensions of the video window */
- InitWindowSize( p_vout, &p_vout->i_window_width,
- &p_vout->i_window_height );
/* Add a variable to indicate if the window should be on top of others */
var_Create( p_vout, "video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT
| VLC_VAR_ISCOMMAND );
text.psz_string = _("Always on top");
var_Change( p_vout, "video-on-top", VLC_VAR_SETTEXT, &text, NULL );
- var_AddCallback( p_vout, "video-on-top", OnTopCallback, NULL );
+ var_AddCallback( p_vout, "video-on-top", AboveCallback, NULL );
+
+ /* Add a variable to indicate if the window should be below all others */
+ var_Create( p_vout, "video-wallpaper", VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
+ var_AddCallback( p_vout, "video-wallpaper", WallPaperCallback,
+ (void *)(uintptr_t)VOUT_WINDOW_STATE_BELOW );
/* Add a variable to indicate whether we want window decoration or not */
var_Create( p_vout, "video-deco", VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
/* Add a fullscreen variable */
- if( var_CreateGetBoolCommand( p_vout, "fullscreen" ) )
- {
- /* user requested fullscreen */
- p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
- }
+ var_Create( p_vout, "fullscreen",
+ VLC_VAR_BOOL | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
text.psz_string = _("Fullscreen");
var_Change( p_vout, "fullscreen", VLC_VAR_SETTEXT, &text, NULL );
var_AddCallback( p_vout, "fullscreen", FullscreenCallback, NULL );
var_Change( p_vout, "video-snapshot", VLC_VAR_SETTEXT, &text, NULL );
var_AddCallback( p_vout, "video-snapshot", SnapshotCallback, NULL );
+ /* Add a video-filter variable */
+ var_Create( p_vout, "video-filter",
+ VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+ var_AddCallback( p_vout, "video-filter", VideoFilterCallback, NULL );
+
+ /* Add a sub-source variable */
+ var_Create( p_vout, "sub-source",
+ VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+ var_AddCallback( p_vout, "sub-source", SubSourceCallback, NULL );
+
+ /* Add a sub-filter variable */
+ var_Create( p_vout, "sub-filter",
+ VLC_VAR_STRING | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+ var_AddCallback( p_vout, "sub-filter", SubFilterCallback, NULL );
+
+ /* Add sub-margin variable */
+ var_Create( p_vout, "sub-margin",
+ VLC_VAR_INTEGER | VLC_VAR_DOINHERIT | VLC_VAR_ISCOMMAND );
+ var_AddCallback( p_vout, "sub-margin", SubMarginCallback, NULL );
+
/* Mouse coordinates */
var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
var_Create( p_vout, "mouse-moved", VLC_VAR_COORDS );
var_Create( p_vout, "mouse-clicked", VLC_VAR_COORDS );
var_Create( p_vout, "mouse-object", VLC_VAR_BOOL );
- var_Create( p_vout, "intf-change", VLC_VAR_BOOL );
- var_SetBool( p_vout, "intf-change", true );
+ vout_IntfReinit( p_vout );
+}
+
+void vout_IntfReinit( vout_thread_t *p_vout )
+{
+ var_TriggerCallback( p_vout, "zoom" );
+ var_TriggerCallback( p_vout, "crop" );
+ var_TriggerCallback( p_vout, "aspect-ratio" );
+
+ var_TriggerCallback( p_vout, "video-on-top" );
+ var_TriggerCallback( p_vout, "video-wallpaper" );
+
+ var_TriggerCallback( p_vout, "video-filter" );
+ var_TriggerCallback( p_vout, "sub-source" );
+ var_TriggerCallback( p_vout, "sub-filter" );
+ var_TriggerCallback( p_vout, "sub-margin" );
}
/*****************************************************************************
if( !p_subpic )
return VLC_EGENERIC;
- /* FIXME DEFAULT_CHAN is not good (used by the text) but
+ /* FIXME SPU_DEFAULT_CHANNEL is not good (used by the text) but
* hardcoded 0 doesn't seem right */
p_subpic->i_channel = 0;
p_subpic->i_start = mdate();
p_subpic->i_original_picture_width *= 4;
p_subpic->i_original_picture_height *= 4;
- spu_DisplaySubpicture( vout_GetSpu( p_vout ), p_subpic );
+ vout_PutSubpicture( p_vout, p_subpic );
return VLC_SUCCESS;
}
static void VoutOsdSnapshot( vout_thread_t *p_vout, picture_t *p_pic, const char *psz_filename )
{
msg_Dbg( p_vout, "snapshot taken (%s)", psz_filename );
- vout_OSDMessage( VLC_OBJECT( p_vout ), DEFAULT_CHAN, "%s", psz_filename );
+ vout_OSDMessage( p_vout, SPU_DEFAULT_CHANNEL, "%s", psz_filename );
- if( var_GetBool( p_vout, "snapshot-preview" ) )
+ if( var_InheritBool( p_vout, "snapshot-preview" ) )
{
if( VoutSnapshotPip( p_vout, p_pic ) )
msg_Warn( p_vout, "Failed to display snapshot" );
}
}
-/* */
-int vout_GetSnapshot( vout_thread_t *p_vout,
- block_t **pp_image, picture_t **pp_picture,
- video_format_t *p_fmt,
- const char *psz_format, mtime_t i_timeout )
-{
- picture_t *p_picture = vout_snapshot_Get( &p_vout->p->snapshot, i_timeout );
- if( !p_picture )
- {
- msg_Err( p_vout, "Failed to grab a snapshot" );
- return VLC_EGENERIC;
- }
-
- if( pp_image )
- {
- vlc_fourcc_t i_format = VLC_CODEC_PNG;
- if( psz_format && image_Type2Fourcc( psz_format ) )
- i_format = image_Type2Fourcc( psz_format );
-
- const int i_override_width = var_GetInteger( p_vout, "snapshot-width" );
- const int i_override_height = var_GetInteger( p_vout, "snapshot-height" );
-
- if( picture_Export( VLC_OBJECT(p_vout), pp_image, p_fmt,
- p_picture, i_format, i_override_width, i_override_height ) )
- {
- msg_Err( p_vout, "Failed to convert image for snapshot" );
- picture_Release( p_picture );
- return VLC_EGENERIC;
- }
- }
- if( pp_picture )
- *pp_picture = p_picture;
- else
- picture_Release( p_picture );
- return VLC_SUCCESS;
-}
-
/**
* This function will handle a snapshot request
*/
static void VoutSaveSnapshot( vout_thread_t *p_vout )
{
- char *psz_path = var_GetNonEmptyString( p_vout, "snapshot-path" );
- char *psz_format = var_GetNonEmptyString( p_vout, "snapshot-format" );
- char *psz_prefix = var_GetNonEmptyString( p_vout, "snapshot-prefix" );
+ char *psz_path = var_InheritString( p_vout, "snapshot-path" );
+ char *psz_format = var_InheritString( p_vout, "snapshot-format" );
+ char *psz_prefix = var_InheritString( p_vout, "snapshot-prefix" );
/* */
picture_t *p_picture;
vout_snapshot_save_cfg_t cfg;
memset( &cfg, 0, sizeof(cfg) );
- cfg.is_sequential = var_GetBool( p_vout, "snapshot-sequential" );
+ cfg.is_sequential = var_InheritBool( p_vout, "snapshot-sequential" );
cfg.sequence = var_GetInteger( p_vout, "snapshot-num" );
cfg.path = psz_path;
cfg.format = psz_format;
char *psz_filename;
int i_sequence;
if (vout_snapshot_SaveImage( &psz_filename, &i_sequence,
- p_image, VLC_OBJECT(p_vout), &cfg ) )
+ p_image, p_vout, &cfg ) )
goto exit;
if( cfg.is_sequential )
var_SetInteger( p_vout, "snapshot-num", i_sequence + 1 );
char *psz_string;
const char *psz_filter_type;
- /* FIXME temporary hack */
- const char *psz_module_name = psz_name;
- if( !strcmp( psz_name, "magnify" ) ||
- !strcmp( psz_name, "puzzle" ) ||
- !strcmp( psz_name, "logo" ) ||
- !strcmp( psz_name, "wall" ) ||
- !strcmp( psz_name, "clone" ) )
- psz_module_name = "video_filter_wrapper";
-
- module_t *p_obj = module_find( psz_module_name );
+ module_t *p_obj = module_find( psz_name );
if( !p_obj )
{
msg_Err( p_vout, "Unable to find filter module \"%s\".", psz_name );
return;
}
- if( module_provides( p_obj, "video filter" ) )
+ if( module_provides( p_obj, "video filter2" ) )
{
- psz_filter_type = "vout-filter";
+ psz_filter_type = "video-filter";
}
- else if( module_provides( p_obj, "video filter2" ) )
+ else if( module_provides( p_obj, "sub source" ) )
{
- psz_filter_type = "video-filter";
+ psz_filter_type = "sub-source";
}
else if( module_provides( p_obj, "sub filter" ) )
{
}
else
{
- module_release( p_obj );
msg_Err( p_vout, "Unknown video filter type." );
return;
}
- module_release( p_obj );
- if( !strcmp( psz_filter_type, "sub-filter") )
- psz_string = var_GetString( vout_GetSpu( p_vout ), psz_filter_type );
- else
- psz_string = var_GetString( p_vout, psz_filter_type );
+ psz_string = var_GetString( p_vout, psz_filter_type );
/* Todo : Use some generic chain manipulation functions */
if( !psz_string ) psz_string = strdup("");
free( psz_parser );
}
else
+ {
+ free( psz_string );
return;
+ }
}
else
{
if( b_setconfig )
{
- if( !strcmp( psz_filter_type, "sub-filter") )
- config_PutPsz( vout_GetSpu( p_vout ), psz_filter_type, psz_string );
- else
- config_PutPsz( p_vout, psz_filter_type, psz_string );
+ config_PutPsz( p_vout, psz_filter_type, psz_string );
}
- if( !strcmp( psz_filter_type, "sub-filter") )
- var_SetString( vout_GetSpu( p_vout ), psz_filter_type, psz_string );
- else
- var_SetString( p_vout, psz_filter_type, psz_string );
+ var_SetString( p_vout, psz_filter_type, psz_string );
free( psz_string );
}
/*****************************************************************************
- * InitWindowSize: find the initial dimensions the video window should have.
- *****************************************************************************
- * This function will check the "width", "height" and "zoom" config options and
- * will calculate the size that the video window should have.
+ * Object variables callbacks
*****************************************************************************/
-static void InitWindowSize( vout_thread_t *p_vout, unsigned *pi_width,
- unsigned *pi_height )
+static int CropCallback( vlc_object_t *object, char const *cmd,
+ vlc_value_t oldval, vlc_value_t newval, void *data )
{
-#define FP_FACTOR 1000 /* our fixed point factor */
-
- int i_width = var_GetInteger( p_vout, "width" );
- int i_height = var_GetInteger( p_vout, "height" );
- float f_zoom = var_GetFloat( p_vout, "zoom" );
- uint64_t ll_zoom = (uint64_t)( FP_FACTOR * f_zoom );
-
- if( i_width > 0 && i_height > 0)
- {
- *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
- *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
+ vout_thread_t *vout = (vout_thread_t *)object;
+ VLC_UNUSED(cmd); VLC_UNUSED(oldval); VLC_UNUSED(data);
+ unsigned num, den;
+ unsigned y, x;
+ unsigned width, height;
+ unsigned left, top, right, bottom;
+
+ if (sscanf(newval.psz_string, "%u:%u", &num, &den) == 2) {
+ vout_ControlChangeCropRatio(vout, num, den);
+ } else if (sscanf(newval.psz_string, "%ux%u+%u+%u",
+ &width, &height, &x, &y) == 4) {
+ vout_ControlChangeCropWindow(vout, x, y, width, height);
+ } else if (sscanf(newval.psz_string, "%u+%u+%u+%u",
+ &left, &top, &right, &bottom) == 4) {
+ vout_ControlChangeCropBorder(vout, left, top, right, bottom);
+ } else if (*newval.psz_string == '\0') {
+ vout_ControlChangeCropRatio(vout, 0, 0);
+ } else {
+ msg_Err(object, "Unknown crop format (%s)", newval.psz_string);
}
- else if( i_width > 0 )
- {
- *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
- *pi_height = (int)( p_vout->fmt_in.i_visible_height * ll_zoom *
- p_vout->fmt_in.i_sar_den * i_width / p_vout->fmt_in.i_sar_num /
- FP_FACTOR / p_vout->fmt_in.i_visible_width );
- }
- else if( i_height > 0 )
- {
- *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
- *pi_width = (int)( p_vout->fmt_in.i_visible_width * ll_zoom *
- p_vout->fmt_in.i_sar_num * i_height / p_vout->fmt_in.i_sar_den /
- FP_FACTOR / p_vout->fmt_in.i_visible_height );
- }
- else if( p_vout->fmt_in.i_sar_num == 0 || p_vout->fmt_in.i_sar_den == 0 )
- {
- msg_Warn( p_vout, "aspect ratio screwed up" );
- *pi_width = (int)( p_vout->fmt_in.i_visible_width * ll_zoom / FP_FACTOR );
- *pi_height = (int)( p_vout->fmt_in.i_visible_height * ll_zoom /FP_FACTOR);
- }
- else if( p_vout->fmt_in.i_sar_num >= p_vout->fmt_in.i_sar_den )
- {
- *pi_width = (int)( p_vout->fmt_in.i_visible_width * ll_zoom *
- p_vout->fmt_in.i_sar_num / p_vout->fmt_in.i_sar_den / FP_FACTOR );
- *pi_height = (int)( p_vout->fmt_in.i_visible_height * ll_zoom
- / FP_FACTOR );
- }
- else
- {
- *pi_width = (int)( p_vout->fmt_in.i_visible_width * ll_zoom
- / FP_FACTOR );
- *pi_height = (int)( p_vout->fmt_in.i_visible_height * ll_zoom *
- p_vout->fmt_in.i_sar_den / p_vout->fmt_in.i_sar_num / FP_FACTOR );
- }
-
- msg_Dbg( p_vout, "window size: %ux%u", *pi_width, *pi_height );
-
-#undef FP_FACTOR
+ return VLC_SUCCESS;
}
-/*****************************************************************************
- * Object variables callbacks
- *****************************************************************************/
-static int ZoomCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int CropBorderCallback(vlc_object_t *object, char const *cmd,
+ vlc_value_t oldval, vlc_value_t newval, void *data)
{
- (void)psz_cmd; (void)oldval; (void)p_data;
+ char buf[4 * 21];
+
+ snprintf(buf, sizeof (buf), "%"PRIu64"+%"PRIu64"+%"PRIu64"+%"PRIu64,
+ var_GetInteger(object, "crop-left"),
+ var_GetInteger(object, "crop-top"),
+ var_GetInteger(object, "crop-right"),
+ var_GetInteger(object, "crop-bottom"));
+ var_SetString(object, "crop", buf);
- return var_SetFloat( p_this, "scale", newval.f_float );
+ VLC_UNUSED(cmd); VLC_UNUSED(oldval); VLC_UNUSED(data); VLC_UNUSED(newval);
+ return VLC_SUCCESS;
}
-static int CropCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int AspectCallback( vlc_object_t *object, char const *cmd,
+ vlc_value_t oldval, vlc_value_t newval, void *data )
{
- vout_thread_t *p_vout = (vout_thread_t *)p_this;
- int64_t i_aspect_num, i_aspect_den;
- unsigned int i_width, i_height;
-
- (void)oldval; (void)p_data;
-
- /* Restore defaults */
- p_vout->fmt_in.i_x_offset = p_vout->fmt_render.i_x_offset;
- p_vout->fmt_in.i_visible_width = p_vout->fmt_render.i_visible_width;
- p_vout->fmt_in.i_y_offset = p_vout->fmt_render.i_y_offset;
- p_vout->fmt_in.i_visible_height = p_vout->fmt_render.i_visible_height;
-
- if( !strcmp( psz_cmd, "crop" ) )
- {
- char *psz_end = NULL, *psz_parser = strchr( newval.psz_string, ':' );
- if( psz_parser )
- {
- /* We're using the 3:4 syntax */
- i_aspect_num = strtol( newval.psz_string, &psz_end, 10 );
- if( psz_end == newval.psz_string || !i_aspect_num ) goto crop_end;
-
- i_aspect_den = strtol( ++psz_parser, &psz_end, 10 );
- if( psz_end == psz_parser || !i_aspect_den ) goto crop_end;
-
- i_width = p_vout->fmt_in.i_sar_den*p_vout->fmt_render.i_visible_height *
- i_aspect_num / i_aspect_den / p_vout->fmt_in.i_sar_num;
- i_height = p_vout->fmt_render.i_visible_width*p_vout->fmt_in.i_sar_num *
- i_aspect_den / i_aspect_num / p_vout->fmt_in.i_sar_den;
-
- if( i_width < p_vout->fmt_render.i_visible_width )
- {
- p_vout->fmt_in.i_x_offset = p_vout->fmt_render.i_x_offset +
- (p_vout->fmt_render.i_visible_width - i_width) / 2;
- p_vout->fmt_in.i_visible_width = i_width;
- }
- else
- {
- p_vout->fmt_in.i_y_offset = p_vout->fmt_render.i_y_offset +
- (p_vout->fmt_render.i_visible_height - i_height) / 2;
- p_vout->fmt_in.i_visible_height = i_height;
- }
- }
- else
- {
- psz_parser = strchr( newval.psz_string, 'x' );
- if( psz_parser )
- {
- /* Maybe we're using the <width>x<height>+<left>+<top> syntax */
- unsigned int i_crop_width, i_crop_height, i_crop_top, i_crop_left;
-
- i_crop_width = strtol( newval.psz_string, &psz_end, 10 );
- if( psz_end != psz_parser ) goto crop_end;
-
- psz_parser = strchr( ++psz_end, '+' );
- i_crop_height = strtol( psz_end, &psz_end, 10 );
- if( psz_end != psz_parser ) goto crop_end;
-
- psz_parser = strchr( ++psz_end, '+' );
- i_crop_left = strtol( psz_end, &psz_end, 10 );
- if( psz_end != psz_parser ) goto crop_end;
-
- psz_end++;
- i_crop_top = strtol( psz_end, &psz_end, 10 );
- if( *psz_end != '\0' ) goto crop_end;
-
- if( i_crop_top + i_crop_height >= p_vout->fmt_render.i_visible_height ||
- i_crop_left + i_crop_width >= p_vout->fmt_render.i_visible_width )
- {
- msg_Err( p_vout, "Unable to crop over picture boundaries");
- return VLC_EGENERIC;
- }
-
- i_width = i_crop_width;
- p_vout->fmt_in.i_visible_width = i_width;
-
- i_height = i_crop_height;
- p_vout->fmt_in.i_visible_height = i_height;
-
- p_vout->fmt_in.i_x_offset = i_crop_left;
- p_vout->fmt_in.i_y_offset = i_crop_top;
- }
- else
- {
- /* Maybe we're using the <left>+<top>+<right>+<bottom> syntax */
- unsigned int i_crop_top, i_crop_left, i_crop_bottom, i_crop_right;
-
- psz_parser = strchr( newval.psz_string, '+' );
- i_crop_left = strtol( newval.psz_string, &psz_end, 10 );
- if( psz_end != psz_parser ) goto crop_end;
-
- psz_parser = strchr( ++psz_end, '+' );
- i_crop_top = strtol( psz_end, &psz_end, 10 );
- if( psz_end != psz_parser ) goto crop_end;
-
- psz_parser = strchr( ++psz_end, '+' );
- i_crop_right = strtol( psz_end, &psz_end, 10 );
- if( psz_end != psz_parser ) goto crop_end;
-
- psz_end++;
- i_crop_bottom = strtol( psz_end, &psz_end, 10 );
- if( *psz_end != '\0' ) goto crop_end;
-
- if( i_crop_top + i_crop_bottom >= p_vout->fmt_render.i_visible_height ||
- i_crop_right + i_crop_left >= p_vout->fmt_render.i_visible_width )
- {
- msg_Err( p_vout, "Unable to crop over picture boundaries" );
- return VLC_EGENERIC;
- }
-
- i_width = p_vout->fmt_render.i_visible_width
- - i_crop_left - i_crop_right;
- p_vout->fmt_in.i_visible_width = i_width;
-
- i_height = p_vout->fmt_render.i_visible_height
- - i_crop_top - i_crop_bottom;
- p_vout->fmt_in.i_visible_height = i_height;
-
- p_vout->fmt_in.i_x_offset = i_crop_left;
- p_vout->fmt_in.i_y_offset = i_crop_top;
- }
- }
- }
- else if( !strcmp( psz_cmd, "crop-top" )
- || !strcmp( psz_cmd, "crop-left" )
- || !strcmp( psz_cmd, "crop-bottom" )
- || !strcmp( psz_cmd, "crop-right" ) )
- {
- unsigned int i_crop_top, i_crop_left, i_crop_bottom, i_crop_right;
-
- i_crop_top = var_GetInteger( p_vout, "crop-top" );
- i_crop_left = var_GetInteger( p_vout, "crop-left" );
- i_crop_right = var_GetInteger( p_vout, "crop-right" );
- i_crop_bottom = var_GetInteger( p_vout, "crop-bottom" );
-
- if( i_crop_top + i_crop_bottom >= p_vout->fmt_render.i_visible_height ||
- i_crop_right + i_crop_left >= p_vout->fmt_render.i_visible_width )
- {
- msg_Err( p_vout, "Unable to crop over picture boundaries" );
- return VLC_EGENERIC;
- }
-
- i_width = p_vout->fmt_render.i_visible_width
- - i_crop_left - i_crop_right;
- p_vout->fmt_in.i_visible_width = i_width;
-
- i_height = p_vout->fmt_render.i_visible_height
- - i_crop_top - i_crop_bottom;
- p_vout->fmt_in.i_visible_height = i_height;
-
- p_vout->fmt_in.i_x_offset = i_crop_left;
- p_vout->fmt_in.i_y_offset = i_crop_top;
- }
-
- crop_end:
- InitWindowSize( p_vout, &p_vout->i_window_width,
- &p_vout->i_window_height );
-
- p_vout->i_changes |= VOUT_CROP_CHANGE;
-
- msg_Dbg( p_vout, "cropping picture %ix%i to %i,%i,%ix%i",
- p_vout->fmt_in.i_width, p_vout->fmt_in.i_height,
- p_vout->fmt_in.i_x_offset, p_vout->fmt_in.i_y_offset,
- p_vout->fmt_in.i_visible_width,
- p_vout->fmt_in.i_visible_height );
-
- var_TriggerCallback( p_vout, "crop-update" );
-
+ vout_thread_t *vout = (vout_thread_t *)object;
+ VLC_UNUSED(cmd); VLC_UNUSED(oldval); VLC_UNUSED(data);
+ unsigned num, den;
+
+ if (sscanf(newval.psz_string, "%u:%u", &num, &den) == 2 &&
+ (num > 0) == (den > 0))
+ vout_ControlChangeSampleAspectRatio(vout, num, den);
+ else if (*newval.psz_string == '\0')
+ vout_ControlChangeSampleAspectRatio(vout, 0, 0);
return VLC_SUCCESS;
}
-static int AspectCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int AutoScaleCallback( vlc_object_t *obj, char const *name,
+ vlc_value_t prev, vlc_value_t cur, void *data )
{
- vout_thread_t *p_vout = (vout_thread_t *)p_this;
- unsigned int i_aspect_num, i_aspect_den, i_sar_num, i_sar_den;
- vlc_value_t val;
-
- char *psz_end, *psz_parser = strchr( newval.psz_string, ':' );
- (void)psz_cmd; (void)oldval; (void)p_data;
-
- /* Restore defaults */
- p_vout->fmt_in.i_sar_num = p_vout->fmt_render.i_sar_num;
- p_vout->fmt_in.i_sar_den = p_vout->fmt_render.i_sar_den;
- p_vout->render.i_aspect = (int64_t)p_vout->fmt_render.i_sar_num *
- p_vout->fmt_render.i_width *
- VOUT_ASPECT_FACTOR /
- p_vout->fmt_render.i_sar_den / p_vout->fmt_render.i_height;
-
- if( !psz_parser ) goto aspect_end;
-
- i_aspect_num = strtol( newval.psz_string, &psz_end, 10 );
- if( psz_end == newval.psz_string || !i_aspect_num ) goto aspect_end;
-
- i_aspect_den = strtol( ++psz_parser, &psz_end, 10 );
- if( psz_end == psz_parser || !i_aspect_den ) goto aspect_end;
+ vout_thread_t *p_vout = (vout_thread_t *)obj;
- i_sar_num = i_aspect_num * p_vout->fmt_render.i_visible_height;
- i_sar_den = i_aspect_den * p_vout->fmt_render.i_visible_width;
- vlc_ureduce( &i_sar_num, &i_sar_den, i_sar_num, i_sar_den, 0 );
- p_vout->fmt_in.i_sar_num = i_sar_num;
- p_vout->fmt_in.i_sar_den = i_sar_den;
- p_vout->render.i_aspect = i_aspect_num * VOUT_ASPECT_FACTOR / i_aspect_den;
-
- aspect_end:
- if( p_vout->p->i_par_num && p_vout->p->i_par_den )
- {
- p_vout->fmt_in.i_sar_num *= p_vout->p->i_par_den;
- p_vout->fmt_in.i_sar_den *= p_vout->p->i_par_num;
- p_vout->render.i_aspect = (int64_t)p_vout->fmt_in.i_sar_num *
- p_vout->fmt_in.i_width *
- VOUT_ASPECT_FACTOR /
- p_vout->fmt_in.i_sar_den /
- p_vout->fmt_in.i_height;
- }
-
- p_vout->i_changes |= VOUT_ASPECT_CHANGE;
-
- msg_Dbg( p_vout, "new aspect-ratio %i:%i, sample aspect-ratio %i:%i",
- p_vout->fmt_in.i_sar_num * p_vout->fmt_in.i_width,
- p_vout->fmt_in.i_sar_den * p_vout->fmt_in.i_height,
- p_vout->fmt_in.i_sar_num, p_vout->fmt_in.i_sar_den );
+ (void) name; (void) prev; (void) data;
+ vout_ControlChangeDisplayFilled( p_vout, cur.b_bool );
+ return VLC_SUCCESS;
+}
- if( var_Get( p_vout, "crop", &val ) )
- return VLC_EGENERIC;
+static int ZoomCallback( vlc_object_t *obj, char const *name,
+ vlc_value_t prev, vlc_value_t cur, void *data )
+{
+ vout_thread_t *p_vout = (vout_thread_t *)obj;
- int i_ret = CropCallback( p_this, "crop", val, val, 0 );
- free( val.psz_string );
- return i_ret;
+ (void) name; (void) prev; (void) data;
+ vout_ControlChangeZoom( p_vout, 1000 * cur.f_float, 1000 );
+ return VLC_SUCCESS;
}
-static int ScalingCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int AboveCallback( vlc_object_t *obj, char const *name,
+ vlc_value_t prev, vlc_value_t cur, void *data )
{
- vout_thread_t *p_vout = (vout_thread_t *)p_this;
- (void)oldval; (void)newval; (void)p_data;
+ vout_ControlChangeWindowState( (vout_thread_t *)obj,
+ cur.b_bool ? VOUT_WINDOW_STATE_ABOVE : VOUT_WINDOW_STATE_NORMAL );
+ (void) name; (void) prev; (void) data;
+ return VLC_SUCCESS;
+}
- vlc_mutex_lock( &p_vout->change_lock );
+static int WallPaperCallback( vlc_object_t *obj, char const *name,
+ vlc_value_t prev, vlc_value_t cur, void *data )
+{
+ vout_thread_t *vout = (vout_thread_t *)obj;
- if( !strcmp( psz_cmd, "autoscale" ) )
+ if( cur.b_bool )
{
- p_vout->i_changes |= VOUT_SCALE_CHANGE;
+ vout_ControlChangeWindowState( vout, VOUT_WINDOW_STATE_BELOW );
+ vout_ControlChangeFullscreen( vout, true );
}
- else if( !strcmp( psz_cmd, "scale" ) )
+ else
{
- p_vout->i_changes |= VOUT_ZOOM_CHANGE;
+ var_TriggerCallback( obj, "fullscreen" );
+ var_TriggerCallback( obj, "video-on-top" );
}
-
- vlc_mutex_unlock( &p_vout->change_lock );
-
- return VLC_SUCCESS;
-}
-
-static int OnTopCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
-{
- vout_thread_t *p_vout = (vout_thread_t *)p_this;
-
- vlc_mutex_lock( &p_vout->change_lock );
- p_vout->i_changes |= VOUT_ON_TOP_CHANGE;
- p_vout->b_on_top = newval.b_bool;
- vlc_mutex_unlock( &p_vout->change_lock );
-
- (void)psz_cmd; (void)oldval; (void)p_data;
+ (void) name; (void) prev; (void) data;
return VLC_SUCCESS;
}
vlc_value_t oldval, vlc_value_t newval, void *p_data )
{
vout_thread_t *p_vout = (vout_thread_t *)p_this;
- vlc_value_t val;
(void)psz_cmd; (void)p_data;
- if( oldval.b_bool == newval.b_bool )
- return VLC_SUCCESS; /* no-op */
- p_vout->i_changes |= VOUT_FULLSCREEN_CHANGE;
-
- val.b_bool = true;
- var_Set( p_vout, "intf-change", val );
+ if( oldval.b_bool != newval.b_bool )
+ vout_ControlChangeFullscreen( p_vout, newval.b_bool );
return VLC_SUCCESS;
}
return VLC_SUCCESS;
}
-static int TitleShowCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int VideoFilterCallback( vlc_object_t *p_this, char const *psz_cmd,
+ vlc_value_t oldval, vlc_value_t newval, void *p_data)
{
- VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval);
- VLC_UNUSED(p_data);
vout_thread_t *p_vout = (vout_thread_t *)p_this;
- p_vout->p->b_title_show = newval.b_bool;
+ VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
+
+ vout_ControlChangeFilters( p_vout, newval.psz_string );
return VLC_SUCCESS;
}
-static int TitleTimeoutCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int SubSourceCallback( vlc_object_t *p_this, char const *psz_cmd,
+ vlc_value_t oldval, vlc_value_t newval, void *p_data)
{
+ vout_thread_t *p_vout = (vout_thread_t *)p_this;
VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
+
+ vout_ControlChangeSubSources( p_vout, newval.psz_string );
+ return VLC_SUCCESS;
+}
+
+static int SubFilterCallback( vlc_object_t *p_this, char const *psz_cmd,
+ vlc_value_t oldval, vlc_value_t newval, void *p_data)
+{
vout_thread_t *p_vout = (vout_thread_t *)p_this;
- p_vout->p->i_title_timeout = (mtime_t) newval.i_int;
+ VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
+
+ vout_ControlChangeSubFilters( p_vout, newval.psz_string );
return VLC_SUCCESS;
}
-static int TitlePositionCallback( vlc_object_t *p_this, char const *psz_cmd,
- vlc_value_t oldval, vlc_value_t newval, void *p_data )
+static int SubMarginCallback( vlc_object_t *p_this, char const *psz_cmd,
+ vlc_value_t oldval, vlc_value_t newval, void *p_data)
{
- VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval);
- VLC_UNUSED(p_data);
vout_thread_t *p_vout = (vout_thread_t *)p_this;
- p_vout->p->i_title_position = newval.i_int;
+ VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data);
+
+ vout_ControlChangeSubMargin( p_vout, newval.i_int );
return VLC_SUCCESS;
}
+