#include <movit/padding_effect.h>
#include <movit/resample_effect.h>
#include <movit/resize_effect.h>
+#include <movit/util.h>
#include <movit/white_balance_effect.h>
#include <movit/ycbcr.h>
#include <movit/ycbcr_input.h>
namespace {
-vector<LiveInputWrapper *> live_inputs;
+// Contains basically the same data as InputState, but does not hold on to
+// a reference to the frames. This is important so that we can release them
+// without having to wait for Lua's GC.
+struct InputStateInfo {
+ InputStateInfo(const InputState& input_state);
+
+ unsigned last_width[MAX_CARDS], last_height[MAX_CARDS];
+ bool last_interlaced[MAX_CARDS];
+ unsigned last_frame_rate_nom[MAX_CARDS], last_frame_rate_den[MAX_CARDS];
+};
+
+InputStateInfo::InputStateInfo(const InputState &input_state)
+{
+ for (unsigned signal_num = 0; signal_num < MAX_CARDS; ++signal_num) {
+ BufferedFrame frame = input_state.buffered_frames[signal_num][0];
+ if (frame.frame == nullptr) {
+ last_width[signal_num] = last_height[signal_num] = 0;
+ last_interlaced[signal_num] = false;
+ continue;
+ }
+ const PBOFrameAllocator::Userdata *userdata = (const PBOFrameAllocator::Userdata *)frame.frame->userdata;
+ last_width[signal_num] = userdata->last_width[frame.field_number];
+ last_height[signal_num] = userdata->last_height[frame.field_number];
+ last_interlaced[signal_num] = userdata->last_interlaced;
+ last_frame_rate_nom[signal_num] = userdata->last_frame_rate_nom;
+ last_frame_rate_den[signal_num] = userdata->last_frame_rate_den;
+ }
+}
class LuaRefWithDeleter {
public:
{
// Construct the C++ object and put it on the stack.
void *mem = lua_newuserdata(L, sizeof(T));
- new(mem) T(std::forward<Args>(args)...);
+ new(mem) T(forward<Args>(args)...);
+
+ // Look up the metatable named <class_name>, and set it on the new object.
+ luaL_getmetatable(L, class_name);
+ lua_setmetatable(L, -2);
+
+ return 1;
+}
+
+// Like wrap_lua_object, but the object is not owned by Lua; ie. it's not freed
+// by Lua GC. This is typically the case for Effects, which are owned by EffectChain
+// and expected to be destructed by it. The object will be of type T** instead of T*
+// when exposed to Lua.
+//
+// Note that we currently leak if you allocate an Effect in this way and never call
+// add_effect. We should see if there's a way to e.g. set __gc on it at construction time
+// and then release that once add_effect() takes ownership.
+template<class T, class... Args>
+int wrap_lua_object_nonowned(lua_State* L, const char *class_name, Args&&... args)
+{
+ // Construct the pointer ot the C++ object and put it on the stack.
+ T **obj = (T **)lua_newuserdata(L, sizeof(T *));
+ *obj = new T(forward<Args>(args)...);
// Look up the metatable named <class_name>, and set it on the new object.
luaL_getmetatable(L, class_name);
luaL_testudata(L, idx, "ResizeEffect") ||
luaL_testudata(L, idx, "MixEffect") ||
luaL_testudata(L, idx, "ImageInput")) {
- return (Effect *)lua_touserdata(L, idx);
+ return *(Effect **)lua_touserdata(L, idx);
}
luaL_error(L, "Error: Index #%d was not an Effect type\n", idx);
return nullptr;
}
+InputStateInfo *get_input_state_info(lua_State *L, int idx)
+{
+ if (luaL_testudata(L, idx, "InputStateInfo")) {
+ return (InputStateInfo *)lua_touserdata(L, idx);
+ }
+ luaL_error(L, "Error: Index #%d was not InputStateInfo\n", idx);
+ return nullptr;
+}
+
bool checkbool(lua_State* L, int idx)
{
luaL_checktype(L, idx, LUA_TBOOLEAN);
return lua_toboolean(L, idx);
}
-std::string checkstdstring(lua_State *L, int index)
+string checkstdstring(lua_State *L, int index)
{
size_t len;
const char* cstr = lua_tolstring(L, index, &len);
- return std::string(cstr, len);
+ return string(cstr, len);
}
int EffectChain_new(lua_State* L)
{
assert(lua_gettop(L) == 2);
+ Theme *theme = get_theme_updata(L);
int aspect_w = luaL_checknumber(L, 1);
int aspect_h = luaL_checknumber(L, 2);
- return wrap_lua_object<EffectChain>(L, "EffectChain", aspect_w, aspect_h);
+ return wrap_lua_object<EffectChain>(L, "EffectChain", aspect_w, aspect_h, theme->get_resource_pool());
+}
+
+int EffectChain_gc(lua_State* L)
+{
+ assert(lua_gettop(L) == 1);
+ EffectChain *chain = (EffectChain *)luaL_checkudata(L, 1, "EffectChain");
+ chain->~EffectChain();
+ return 0;
}
int EffectChain_add_live_input(lua_State* L)
{
- assert(lua_gettop(L) == 2);
+ assert(lua_gettop(L) == 3);
Theme *theme = get_theme_updata(L);
EffectChain *chain = (EffectChain *)luaL_checkudata(L, 1, "EffectChain");
bool override_bounce = checkbool(L, 2);
- return wrap_lua_object<LiveInputWrapper>(L, "LiveInputWrapper", theme, chain, override_bounce);
+ bool deinterlace = checkbool(L, 3);
+ return wrap_lua_object<LiveInputWrapper>(L, "LiveInputWrapper", theme, chain, override_bounce, deinterlace);
}
int EffectChain_add_effect(lua_State* L)
for (int idx = 3; idx <= lua_gettop(L); ++idx) {
if (luaL_testudata(L, idx, "LiveInputWrapper")) {
LiveInputWrapper *input = (LiveInputWrapper *)lua_touserdata(L, idx);
- inputs.push_back(input->get_input());
+ inputs.push_back(input->get_effect());
} else {
inputs.push_back(get_effect(L, idx));
}
int ImageInput_new(lua_State* L)
{
assert(lua_gettop(L) == 1);
- std::string filename = checkstdstring(L, 1);
- return wrap_lua_object<ImageInput>(L, "ImageInput", filename);
+ string filename = checkstdstring(L, 1);
+ return wrap_lua_object_nonowned<ImageInput>(L, "ImageInput", filename);
}
int WhiteBalanceEffect_new(lua_State* L)
{
assert(lua_gettop(L) == 0);
- return wrap_lua_object<WhiteBalanceEffect>(L, "WhiteBalanceEffect");
+ return wrap_lua_object_nonowned<WhiteBalanceEffect>(L, "WhiteBalanceEffect");
}
int ResampleEffect_new(lua_State* L)
{
assert(lua_gettop(L) == 0);
- return wrap_lua_object<ResampleEffect>(L, "ResampleEffect");
+ return wrap_lua_object_nonowned<ResampleEffect>(L, "ResampleEffect");
}
int PaddingEffect_new(lua_State* L)
{
assert(lua_gettop(L) == 0);
- return wrap_lua_object<PaddingEffect>(L, "PaddingEffect");
+ return wrap_lua_object_nonowned<PaddingEffect>(L, "PaddingEffect");
}
int IntegralPaddingEffect_new(lua_State* L)
{
assert(lua_gettop(L) == 0);
- return wrap_lua_object<IntegralPaddingEffect>(L, "IntegralPaddingEffect");
+ return wrap_lua_object_nonowned<IntegralPaddingEffect>(L, "IntegralPaddingEffect");
}
int OverlayEffect_new(lua_State* L)
{
assert(lua_gettop(L) == 0);
- return wrap_lua_object<OverlayEffect>(L, "OverlayEffect");
+ return wrap_lua_object_nonowned<OverlayEffect>(L, "OverlayEffect");
}
int ResizeEffect_new(lua_State* L)
{
assert(lua_gettop(L) == 0);
- return wrap_lua_object<ResizeEffect>(L, "ResizeEffect");
+ return wrap_lua_object_nonowned<ResizeEffect>(L, "ResizeEffect");
}
int MixEffect_new(lua_State* L)
{
assert(lua_gettop(L) == 0);
- return wrap_lua_object<MixEffect>(L, "MixEffect");
+ return wrap_lua_object_nonowned<MixEffect>(L, "MixEffect");
+}
+
+int InputStateInfo_get_width(lua_State* L)
+{
+ assert(lua_gettop(L) == 2);
+ InputStateInfo *input_state_info = get_input_state_info(L, 1);
+ Theme *theme = get_theme_updata(L);
+ int signal_num = theme->map_signal(luaL_checknumber(L, 2));
+ lua_pushnumber(L, input_state_info->last_width[signal_num]);
+ return 1;
+}
+
+int InputStateInfo_get_height(lua_State* L)
+{
+ assert(lua_gettop(L) == 2);
+ InputStateInfo *input_state_info = get_input_state_info(L, 1);
+ Theme *theme = get_theme_updata(L);
+ int signal_num = theme->map_signal(luaL_checknumber(L, 2));
+ lua_pushnumber(L, input_state_info->last_height[signal_num]);
+ return 1;
+}
+
+int InputStateInfo_get_interlaced(lua_State* L)
+{
+ assert(lua_gettop(L) == 2);
+ InputStateInfo *input_state_info = get_input_state_info(L, 1);
+ Theme *theme = get_theme_updata(L);
+ int signal_num = theme->map_signal(luaL_checknumber(L, 2));
+ lua_pushboolean(L, input_state_info->last_interlaced[signal_num]);
+ return 1;
+}
+
+int InputStateInfo_get_frame_rate_nom(lua_State* L)
+{
+ assert(lua_gettop(L) == 2);
+ InputStateInfo *input_state_info = get_input_state_info(L, 1);
+ Theme *theme = get_theme_updata(L);
+ int signal_num = theme->map_signal(luaL_checknumber(L, 2));
+ lua_pushnumber(L, input_state_info->last_frame_rate_nom[signal_num]);
+ return 1;
+}
+
+int InputStateInfo_get_frame_rate_den(lua_State* L)
+{
+ assert(lua_gettop(L) == 2);
+ InputStateInfo *input_state_info = get_input_state_info(L, 1);
+ Theme *theme = get_theme_updata(L);
+ int signal_num = theme->map_signal(luaL_checknumber(L, 2));
+ lua_pushnumber(L, input_state_info->last_frame_rate_den[signal_num]);
+ return 1;
}
int Effect_set_float(lua_State *L)
{
assert(lua_gettop(L) == 3);
Effect *effect = (Effect *)get_effect(L, 1);
- std::string key = checkstdstring(L, 2);
+ string key = checkstdstring(L, 2);
float value = luaL_checknumber(L, 3);
if (!effect->set_float(key, value)) {
luaL_error(L, "Effect refused set_float(\"%s\", %d) (invalid key?)", key.c_str(), int(value));
{
assert(lua_gettop(L) == 3);
Effect *effect = (Effect *)get_effect(L, 1);
- std::string key = checkstdstring(L, 2);
+ string key = checkstdstring(L, 2);
float value = luaL_checknumber(L, 3);
if (!effect->set_int(key, value)) {
luaL_error(L, "Effect refused set_int(\"%s\", %d) (invalid key?)", key.c_str(), int(value));
{
assert(lua_gettop(L) == 5);
Effect *effect = (Effect *)get_effect(L, 1);
- std::string key = checkstdstring(L, 2);
+ string key = checkstdstring(L, 2);
float v[3];
v[0] = luaL_checknumber(L, 3);
v[1] = luaL_checknumber(L, 4);
{
assert(lua_gettop(L) == 6);
Effect *effect = (Effect *)get_effect(L, 1);
- std::string key = checkstdstring(L, 2);
+ string key = checkstdstring(L, 2);
float v[4];
v[0] = luaL_checknumber(L, 3);
v[1] = luaL_checknumber(L, 4);
const luaL_Reg EffectChain_funcs[] = {
{ "new", EffectChain_new },
+ { "__gc", EffectChain_gc },
{ "add_live_input", EffectChain_add_live_input },
{ "add_effect", EffectChain_add_effect },
{ "finalize", EffectChain_finalize },
{ NULL, NULL }
};
+const luaL_Reg InputStateInfo_funcs[] = {
+ { "get_width", InputStateInfo_get_width },
+ { "get_height", InputStateInfo_get_height },
+ { "get_interlaced", InputStateInfo_get_interlaced },
+ { "get_frame_rate_nom", InputStateInfo_get_frame_rate_nom },
+ { "get_frame_rate_den", InputStateInfo_get_frame_rate_den },
+ { NULL, NULL }
+};
+
} // namespace
-LiveInputWrapper::LiveInputWrapper(Theme *theme, EffectChain *chain, bool override_bounce)
- : theme(theme)
+LiveInputWrapper::LiveInputWrapper(Theme *theme, EffectChain *chain, bool override_bounce, bool deinterlace)
+ : theme(theme),
+ deinterlace(deinterlace)
{
ImageFormat inout_format;
inout_format.color_space = COLORSPACE_sRGB;
input_ycbcr_format.luma_coefficients = YCBCR_REC_709;
input_ycbcr_format.full_range = false;
- if (override_bounce) {
- input = new NonBouncingYCbCrInput(inout_format, input_ycbcr_format, WIDTH, HEIGHT, YCBCR_INPUT_SPLIT_Y_AND_CBCR);
+ unsigned num_inputs;
+ if (deinterlace) {
+ deinterlace_effect = new movit::DeinterlaceEffect();
+
+ // As per the comments in deinterlace_effect.h, we turn this off.
+ // The most likely interlaced input for us is either a camera
+ // (where it's fine to turn it off) or a laptop (where it _should_
+ // be turned off).
+ CHECK(deinterlace_effect->set_int("enable_spatial_interlacing_check", 0));
+
+ num_inputs = deinterlace_effect->num_inputs();
+ assert(num_inputs == FRAME_HISTORY_LENGTH);
} else {
- input = new YCbCrInput(inout_format, input_ycbcr_format, WIDTH, HEIGHT, YCBCR_INPUT_SPLIT_Y_AND_CBCR);
+ num_inputs = 1;
+ }
+ for (unsigned i = 0; i < num_inputs; ++i) {
+ if (override_bounce) {
+ inputs.push_back(new NonBouncingYCbCrInput(inout_format, input_ycbcr_format, WIDTH, HEIGHT, YCBCR_INPUT_SPLIT_Y_AND_CBCR));
+ } else {
+ inputs.push_back(new YCbCrInput(inout_format, input_ycbcr_format, WIDTH, HEIGHT, YCBCR_INPUT_SPLIT_Y_AND_CBCR));
+ }
+ chain->add_input(inputs.back());
+ }
+
+ if (deinterlace) {
+ vector<Effect *> reverse_inputs(inputs.rbegin(), inputs.rend());
+ chain->add_effect(deinterlace_effect, reverse_inputs);
}
- chain->add_input(input);
}
void LiveInputWrapper::connect_signal(int signal_num)
{
if (global_mixer == nullptr) {
+ // No data yet.
return;
}
signal_num = theme->map_signal(signal_num);
- Mixer::BufferedFrame frame = global_mixer->get_buffered_frame(signal_num, 0);
- const PBOFrameAllocator::Userdata *userdata = (const PBOFrameAllocator::Userdata *)frame.frame->userdata;
+ BufferedFrame first_frame = theme->input_state->buffered_frames[signal_num][0];
+ if (first_frame.frame == nullptr) {
+ // No data yet.
+ return;
+ }
+ unsigned width, height;
+ {
+ const PBOFrameAllocator::Userdata *userdata = (const PBOFrameAllocator::Userdata *)first_frame.frame->userdata;
+ width = userdata->last_width[first_frame.field_number];
+ height = userdata->last_height[first_frame.field_number];
+ }
- input->set_texture_num(0, userdata->tex_y[frame.field_number]);
- input->set_texture_num(1, userdata->tex_cbcr[frame.field_number]);
- input->set_width(userdata->last_width[frame.field_number]);
- input->set_height(userdata->last_height[frame.field_number]);
+ BufferedFrame last_good_frame = first_frame;
+ for (unsigned i = 0; i < inputs.size(); ++i) {
+ BufferedFrame frame = theme->input_state->buffered_frames[signal_num][i];
+ if (frame.frame == nullptr) {
+ // Not enough data; reuse last frame (well, field).
+ // This is suboptimal, but we have nothing better.
+ frame = last_good_frame;
+ }
+ const PBOFrameAllocator::Userdata *userdata = (const PBOFrameAllocator::Userdata *)frame.frame->userdata;
+
+ if (userdata->last_width[frame.field_number] != width ||
+ userdata->last_height[frame.field_number] != height) {
+ // Resolution changed; reuse last frame/field.
+ frame = last_good_frame;
+ userdata = (const PBOFrameAllocator::Userdata *)frame.frame->userdata;
+ }
- // Hold on to the refcount so that we don't release the input frame
- // until we're done rendering from it.
- if (theme->used_input_frames_collector != nullptr) {
- theme->used_input_frames_collector->push_back(frame.frame);
+ inputs[i]->set_texture_num(0, userdata->tex_y[frame.field_number]);
+ inputs[i]->set_texture_num(1, userdata->tex_cbcr[frame.field_number]);
+ inputs[i]->set_width(userdata->last_width[frame.field_number]);
+ inputs[i]->set_height(userdata->last_height[frame.field_number]);
+
+ last_good_frame = frame;
+ }
+
+ if (deinterlace) {
+ BufferedFrame frame = theme->input_state->buffered_frames[signal_num][0];
+ CHECK(deinterlace_effect->set_int("current_field_position", frame.field_number));
}
}
register_class("OverlayEffect", OverlayEffect_funcs);
register_class("ResizeEffect", ResizeEffect_funcs);
register_class("MixEffect", MixEffect_funcs);
+ register_class("InputStateInfo", InputStateInfo_funcs);
// Run script.
lua_settop(L, 0);
assert(lua_gettop(L) == 0);
}
+Theme::~Theme()
+{
+ lua_close(L);
+}
+
void Theme::register_class(const char *class_name, const luaL_Reg *funcs)
{
assert(lua_gettop(L) == 0);
- luaL_newmetatable(L, class_name);
+ luaL_newmetatable(L, class_name); // mt = {}
lua_pushlightuserdata(L, this);
- luaL_setfuncs(L, funcs, 1);
+ luaL_setfuncs(L, funcs, 1); // for (name,f in funcs) { mt[name] = f, with upvalue {theme} }
lua_pushvalue(L, -1);
- lua_setfield(L, -2, "__index");
- lua_setglobal(L, class_name);
+ lua_setfield(L, -2, "__index"); // mt.__index = mt
+ lua_setglobal(L, class_name); // ClassName = mt
assert(lua_gettop(L) == 0);
}
-Theme::Chain Theme::get_chain(unsigned num, float t, unsigned width, unsigned height)
+Theme::Chain Theme::get_chain(unsigned num, float t, unsigned width, unsigned height, InputState input_state)
{
Chain chain;
lua_pushnumber(L, t);
lua_pushnumber(L, width);
lua_pushnumber(L, height);
+ wrap_lua_object<InputStateInfo>(L, "InputStateInfo", input_state);
- this->used_input_frames_collector = &chain.input_frames;
- if (lua_pcall(L, 4, 2, 0) != 0) {
+ if (lua_pcall(L, 5, 2, 0) != 0) {
fprintf(stderr, "error running function `get_chain': %s\n", lua_tostring(L, -1));
exit(1);
}
- this->used_input_frames_collector = nullptr;
chain.chain = (EffectChain *)luaL_checkudata(L, -2, "EffectChain");
if (!lua_isfunction(L, -1)) {
lua_pop(L, 2);
assert(lua_gettop(L) == 0);
- chain.setup_chain = [this, funcref]{
+ chain.setup_chain = [this, funcref, input_state]{
unique_lock<mutex> lock(m);
+ this->input_state = &input_state;
+
// Set up state, including connecting signals.
lua_rawgeti(L, LUA_REGISTRYINDEX, funcref->get());
if (lua_pcall(L, 0, 0, 0) != 0) {
assert(lua_gettop(L) == 0);
};
+ // TODO: Can we do better, e.g. by running setup_chain() and seeing what it references?
+ // Actually, setup_chain does maybe hold all the references we need now anyway?
+ for (unsigned card_index = 0; card_index < num_cards; ++card_index) {
+ for (unsigned frame_num = 0; frame_num < FRAME_HISTORY_LENGTH; ++frame_num) {
+ chain.input_frames.push_back(input_state.buffered_frames[card_index][frame_num].frame);
+ }
+ }
+
return chain;
}
-std::string Theme::get_channel_name(unsigned channel)
+string Theme::get_channel_name(unsigned channel)
{
unique_lock<mutex> lock(m);
lua_getglobal(L, "channel_name");
lua_pushnumber(L, channel);
if (lua_pcall(L, 1, 1, 0) != 0) {
- fprintf(stderr, "error running function `channel_nam': %s\n", lua_tostring(L, -1));
+ fprintf(stderr, "error running function `channel_name': %s\n", lua_tostring(L, -1));
exit(1);
}
- std::string ret = lua_tostring(L, -1);
+ string ret = lua_tostring(L, -1);
lua_pop(L, 1);
assert(lua_gettop(L) == 0);
return ret;
assert(lua_gettop(L) == 0);
}
-std::vector<std::string> Theme::get_transition_names(float t)
+vector<string> Theme::get_transition_names(float t)
{
unique_lock<mutex> lock(m);
lua_getglobal(L, "get_transitions");
exit(1);
}
- std::vector<std::string> ret;
+ vector<string> ret;
lua_pushnil(L);
while (lua_next(L, -2) != 0) {
ret.push_back(lua_tostring(L, -1));