]> git.sesse.net Git - ffmpeg/commit
fate/cover-art: Add test for writing id3v2 tags and apic with AIFF/MP3
authorAndreas Rheinhardt <andreas.rheinhardt@outlook.com>
Sat, 10 Apr 2021 19:20:00 +0000 (21:20 +0200)
committerAndreas Rheinhardt <andreas.rheinhardt@outlook.com>
Sun, 18 Apr 2021 00:18:22 +0000 (02:18 +0200)
commit2f4ef9cbdfad716bcf1b4d4c99161e23b7cf24f0
tree72ed2169976ec5f0de443dc30a6476a09e79f3cb
parent3d76d4bf7f83aff9403825f6b2b7816e5e9675ce
fate/cover-art: Add test for writing id3v2 tags and apic with AIFF/MP3

Notice that the order of the APIC tracks is currently wrong. This is
a superposition of two bugs: (i) Both muxers write the attached
pictures in the order they arrive in the muxer and not in the
stream_index order, leading to attached pictures that are copied being
written earlier because their timestamp is AV_NOPTS_VALUE, whereas the
timestamp of the encoded pictures is 0. (ii) A bug in the id3v2 parsing
code reverses the order of the parsed pictures.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
tests/fate/cover-art.mak
tests/ref/fate/cover-art-aiff-id3v2-remux [new file with mode: 0644]
tests/ref/fate/cover-art-mp3-id3v2-remux [new file with mode: 0644]