]> git.sesse.net Git - vlc/commit
Fixed by decrementing the i_refcount variable in the correct manner -
authorPhil Roffe and David Grellscheid <philip.roffe@durham.ac.uk>
Tue, 14 Apr 2009 18:43:12 +0000 (20:43 +0200)
committerAntoine Cellerier <dionoea@videolan.org>
Tue, 14 Apr 2009 18:43:37 +0000 (20:43 +0200)
commit6cab63a2e5e4a53e135ee455244b89b1601f4e2a
treee5d21a962e69213037f8957ad5f5d062e458dcdc
parentf7a5c96acdcb1b6adb1126f7533b480ca4265540
Fixed by decrementing the i_refcount variable in the correct manner -
and therefore freeing the memory only when the i_refcount successfully
went to 0.

The problem was that i_refcount is an unsigned variable, and was being
decremented twice, once erroneously by mosaic_bridge, and then again in
the picture's original pf_release function. If i_refcount started at 1,
it wrapped to the maximum unsigned value rather than -1, failing the
refcount tests in the pf_release function.

Patch Authors: Phil Roffe and David Grellscheid

Signed-off-by: Antoine Cellerier <dionoea@videolan.org>
modules/stream_out/mosaic_bridge.c