]> git.sesse.net Git - vlc/commit
Qt4: fix race in requestVideo and simplify
authorRémi Denis-Courmont <remi@remlab.net>
Wed, 12 Aug 2009 16:40:50 +0000 (19:40 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Wed, 12 Aug 2009 16:50:00 +0000 (19:50 +0300)
commit7c6ef80c3e80d00e7c2000733b1feee0b537267e
tree1460da93f935e8801fab838eac0c1c364c7f9ef9
parent26d7acaff875412533279c36347be4d9be2ec316
Qt4: fix race in requestVideo and simplify

We were accessing some main interface variables from random threads
without serialization. This simply moves the blocking connection signal
from sole size setting to the whole video widget request call. In the
process, we can remove two signals. We still need a blocking connection
signal. It does not add any new deadlock case, since there was already
blocking connection signal in the same call and in the same direction.
modules/gui/qt4/main_interface.cpp
modules/gui/qt4/main_interface.hpp
modules/gui/qt4/qt4.cpp