]> git.sesse.net Git - vlc/commit
wx/playlist: never store the pointer to p_item when the playlist lock isn't
authorSigmund Augdal Helberg <sigmunau@videolan.org>
Sat, 9 Apr 2005 14:57:23 +0000 (14:57 +0000)
committerSigmund Augdal Helberg <sigmunau@videolan.org>
Sat, 9 Apr 2005 14:57:23 +0000 (14:57 +0000)
commitdfdc690c83787b550bd5a532df772dbd8b896779
treeb7b79ea7169966cd4f35b4a263ab7774c400af26
parent5c6d8629e59cc6e707fc1a875f9b226c1ef7ea24
wx/playlist: never store the pointer to p_item when the playlist lock isn't
held. store p_playlist in wxvlc::Playlist since the class can't work without
p_playlist anyway. Strictly lock playlist when needed.

adds a lot of playlist_ItemGetById, and removes a lot of vlc_object_find
VLC_OBJECT_PLAYLIST).

This should fix a lot of potential deadlocks and crashes, including a few I
could reproduce
modules/gui/wxwindows/playlist.cpp
modules/gui/wxwindows/wxwindows.h