Some people should have read some documentation about threading before
they did 1000+ commits. Yes, I am obviously annoyed. I have been fixing
VLC for 18 months because of these "great former developers".
var_Get( p_vout->p_libvlc, "drawable", &val );
if( val.i_int ) return (void *)(intptr_t)val.i_int;
var_Get( p_vout->p_libvlc, "drawable", &val );
if( val.i_int ) return (void *)(intptr_t)val.i_int;
+#if 0
+ /* FIXME:
+ * This code is utter crap w.r.t. threading. And it has always been.
+ * First, one cannot invoke callbacks from another thread's object.
+ * Not without a well-defined locking convention.
+ *
+ * Second, this would need to "wait" for the interface to be ready.
+ * Otherwise, the availability of the embded window would become
+ * time-dependent.
+ *
+ * In the past, this kind of things worked by accident. This time is over.
+ * -- Courmisch, 12 Jun 2008
+ */
/* Find if the main interface supports embedding */
p_list = vlc_list_find( p_vout, VLC_OBJECT_INTF, FIND_ANYWHERE );
if( !p_list ) return NULL;
/* Find if the main interface supports embedding */
p_list = vlc_list_find( p_vout, VLC_OBJECT_INTF, FIND_ANYWHERE );
if( !p_list ) return NULL;
else p_vout->p_parent_intf = p_intf;
return p_window;
else p_vout->p_parent_intf = p_intf;
return p_window;
+#else
+ return NULL;
+#endif
}
void vout_ReleaseWindow( vout_thread_t *p_vout, void *p_window )
}
void vout_ReleaseWindow( vout_thread_t *p_vout, void *p_window )