Consistency between Spatializer and Compressor
-Equalizer::~Equalizer()
-{
-}
-
-void Equalizer::clean()
-{
- enable();
-}
/* Write down initial values */
void Equalizer::updateUIFromCore()
{
/* Write down initial values */
void Equalizer::updateUIFromCore()
{
if( psz_bands && strlen( psz_bands ) > 1 )
{
if( psz_bands && strlen( psz_bands ) > 1 )
{
- char *psz_bands_orig = psz_bands;
+ char *psz_bands_orig = psz_bands;
for( int i = 0; i < BANDS; i++ )
{
const float f = us_strtod(psz_bands, &psz_bands );
for( int i = 0; i < BANDS; i++ )
{
const float f = us_strtod(psz_bands, &psz_bands );
const float f_resolution; // resolution
} comp_controls_t;
const float f_resolution; // resolution
} comp_controls_t;
-static const comp_controls_t controls[] =
+static const comp_controls_t comp_controls[] =
{
{ "compressor-rms-peak", _("RMS/peak"), "", 0.0f, 1.0f, 0.00f, 0.001f },
{ "compressor-attack", _("Attack"), _(" ms"), 1.5f, 400.0f, 25.00f, 0.100f },
{
{ "compressor-rms-peak", _("RMS/peak"), "", 0.0f, 1.0f, 0.00f, 0.001f },
{ "compressor-attack", _("Attack"), _(" ms"), 1.5f, 400.0f, 25.00f, 0.100f },
{ "compressor-makeup-gain", _("Makeup\ngain"), _(" dB"), 0.0f, 24.0f, 7.00f, 0.010f },
};
{ "compressor-makeup-gain", _("Makeup\ngain"), _(" dB"), 0.0f, 24.0f, 7.00f, 0.010f },
};
-Compressor::Compressor( intf_thread_t *_p_intf, QWidget *_parent ) :
- QWidget( _parent ) , p_intf( _p_intf )
+Compressor::Compressor( intf_thread_t *_p_intf, QWidget *_parent )
+ : QWidget( _parent ) , p_intf( _p_intf )
- QFont smallFont = QApplication::font( static_cast<QWidget*>( 0 ) );
+ QFont smallFont = QApplication::font();
smallFont.setPointSize( smallFont.pointSize() - 3 );
QGridLayout *layout = new QGridLayout( this );
smallFont.setPointSize( smallFont.pointSize() - 3 );
QGridLayout *layout = new QGridLayout( this );
for( int i = 0 ; i < NUM_CP_CTRL ; i++ )
{
for( int i = 0 ; i < NUM_CP_CTRL ; i++ )
{
- compCtrl[i] = new QSlider( Qt::Vertical );
-
- const int i_min = (int)( controls[i].f_min
- / controls[i].f_resolution );
- const int i_max = (int)( controls[i].f_max
- / controls[i].f_resolution );
- const int i_val = (int)( controls[i].f_value
- / controls[i].f_resolution );
+ const int i_min = (int)( comp_controls[i].f_min
+ / comp_controls[i].f_resolution );
+ const int i_max = (int)( comp_controls[i].f_max
+ / comp_controls[i].f_resolution );
+ const int i_val = (int)( comp_controls[i].f_value
+ / comp_controls[i].f_resolution );
+ compCtrl[i] = new QSlider( Qt::Vertical );
compCtrl[i]->setMinimum( i_min );
compCtrl[i]->setMaximum( i_max );
compCtrl[i]->setValue( i_val );
compCtrl[i]->setMinimum( i_min );
compCtrl[i]->setMaximum( i_max );
compCtrl[i]->setValue( i_val );
- oldControlVars[i] = controls[i].f_value;
+
+ oldControlVars[i] = comp_controls[i].f_value;
+
CONNECT( compCtrl[i], valueChanged( int ), this, setInitValues() );
CONNECT( compCtrl[i], valueChanged( int ), this, setInitValues() );
- ctrl_texts[i] = new QLabel( qtr( controls[i].psz_descs )
- + qtr( "\n" ) );
+
+ ctrl_texts[i] = new QLabel( qtr( comp_controls[i].psz_descs ) + "\n" );
ctrl_texts[i]->setFont( smallFont );
ctrl_texts[i]->setAlignment( Qt::AlignHCenter );
ctrl_texts[i]->setFont( smallFont );
ctrl_texts[i]->setAlignment( Qt::AlignHCenter );
- ctrl_readout[i] = new QLabel( qtr( "" ) );
+
+ ctrl_readout[i] = new QLabel;
ctrl_readout[i]->setFont( smallFont );
ctrl_readout[i]->setAlignment( Qt::AlignHCenter );
ctrl_readout[i]->setFont( smallFont );
ctrl_readout[i]->setAlignment( Qt::AlignHCenter );
- layout->addWidget( compCtrl[i], 1, i, Qt::AlignHCenter );
+
+ layout->addWidget( compCtrl[i], 1, i, Qt::AlignHCenter );
layout->addWidget( ctrl_readout[i], 2, i, Qt::AlignHCenter );
layout->addWidget( ctrl_readout[i], 2, i, Qt::AlignHCenter );
- layout->addWidget( ctrl_texts[i], 3, i, Qt::AlignHCenter );
+ layout->addWidget( ctrl_texts[i], 3, i, Qt::AlignHCenter );
}
BUTTONACT( enableCheck, enable() );
}
BUTTONACT( enableCheck, enable() );
for( int i = 0; i < NUM_CP_CTRL; i++ )
{
controlVars[i] = var_GetFloat( p_aout,
for( int i = 0; i < NUM_CP_CTRL; i++ )
{
controlVars[i] = var_GetFloat( p_aout,
- controls[i].psz_name );
+ comp_controls[i].psz_name );
}
vlc_object_release( p_aout );
}
}
vlc_object_release( p_aout );
}
for( int i = 0; i < NUM_CP_CTRL; i++ )
{
controlVars[i] = config_GetFloat( p_intf,
for( int i = 0; i < NUM_CP_CTRL; i++ )
{
controlVars[i] = config_GetFloat( p_intf,
- controls[i].psz_name );
+ comp_controls[i].psz_name );
}
}
if( psz_af && strstr( psz_af, "compressor" ) != NULL )
}
}
if( psz_af && strstr( psz_af, "compressor" ) != NULL )
{
if( oldControlVars[i] != controlVars[i] )
{
{
if( oldControlVars[i] != controlVars[i] )
{
- const int i_val = (int)( controlVars[i]
- / controls[i].f_resolution );
- compCtrl[i]->setValue( i_val );
+ compCtrl[i]->setValue(
+ (int)( controlVars[i] / comp_controls[i].f_resolution ) );
for( int i = 0 ; i < NUM_CP_CTRL ; i++ )
{
for( int i = 0 ; i < NUM_CP_CTRL ; i++ )
{
- float f = (float)( compCtrl[i]->value() )
- * ( controls[i].f_resolution );
+ float f = (float)( compCtrl[i]->value() ) * ( comp_controls[i].f_resolution );
ctrl_readout[i]->setText( QString::number( f, 'f', 1 )
ctrl_readout[i]->setText( QString::number( f, 'f', 1 )
- + qtr( controls[i].psz_units ) );
+ + qtr( comp_controls[i].psz_units ) );
if( oldControlVars[i] != f )
{
if( p_aout )
{
if( oldControlVars[i] != f )
{
if( p_aout )
{
- var_SetFloat( p_aout, controls[i].psz_name, f );
+ var_SetFloat( p_aout, comp_controls[i].psz_name, f );
- config_PutFloat( p_intf, controls[i].psz_name, f );
+ config_PutFloat( p_intf, comp_controls[i].psz_name, f );
oldControlVars[i] = f;
}
}
oldControlVars[i] = f;
}
}
/**********************************************************************
* Spatializer
**********************************************************************/
/**********************************************************************
* Spatializer
**********************************************************************/
-static const char *psz_control_names[] =
+typedef struct
+{
+ const char *psz_name;
+ const char *psz_desc;
+} spat_controls_t;
+
+static const spat_controls_t spat_controls[] =
- "spatializer-roomsize", "spatializer-width",
- "spatializer-wet", "spatializer-dry", "spatializer-damp"
+ { "spatializer-roomsize", _("Size") },
+ { "spatializer-width", _("Width") },
+ { "spatializer-wet", _("Wet") },
+ { "spatializer-dry", _("Dry") },
+ { "spatializer-damp", _("Damp") },
-Spatializer::Spatializer( intf_thread_t *_p_intf, QWidget *_parent ) :
- QWidget( _parent ) , p_intf( _p_intf )
+Spatializer::Spatializer( intf_thread_t *_p_intf, QWidget *_parent )
+ : QWidget( _parent ) , p_intf( _p_intf )
{
QFont smallFont = QApplication::font();
smallFont.setPointSize( smallFont.pointSize() - 3 );
{
QFont smallFont = QApplication::font();
smallFont.setPointSize( smallFont.pointSize() - 3 );
spatCtrl[i]->setValue( 0 );
spatCtrl[i]->setMinimum( -10 );
}
spatCtrl[i]->setValue( 0 );
spatCtrl[i]->setMinimum( -10 );
}
oldControlVars[i] = spatCtrl[i]->value();
oldControlVars[i] = spatCtrl[i]->value();
CONNECT( spatCtrl[i], valueChanged( int ), this, setInitValues() );
CONNECT( spatCtrl[i], valueChanged( int ), this, setInitValues() );
- ctrl_texts[i] = new QLabel( qfu( psz_control_names[i] ) + "\n" );
+
+ ctrl_texts[i] = new QLabel( qtr( spat_controls[i].psz_desc ) + "\n" );
ctrl_texts[i]->setFont( smallFont );
ctrl_texts[i]->setFont( smallFont );
- ctrl_readout[i] = new QLabel( "" );
+
+ ctrl_readout[i] = new QLabel;
ctrl_readout[i]->setFont( smallFont );
ctrl_readout[i]->setFont( smallFont );
- layout->addWidget( spatCtrl[i], 1, i );
- layout->addWidget( ctrl_readout[i], 2, i );
- layout->addWidget( ctrl_texts[i], 3, i );
+
+ layout->addWidget( spatCtrl[i], 1, i, Qt::AlignHCenter );
+ layout->addWidget( ctrl_readout[i], 2, i, Qt::AlignHCenter );
+ layout->addWidget( ctrl_texts[i], 3, i, Qt::AlignHCenter );
}
BUTTONACT( enableCheck, enable() );
}
BUTTONACT( enableCheck, enable() );
psz_af = var_GetNonEmptyString( p_aout, "audio-filter" );
for( int i = 0; i < NUM_SP_CTRL ; i++ )
{
psz_af = var_GetNonEmptyString( p_aout, "audio-filter" );
for( int i = 0; i < NUM_SP_CTRL ; i++ )
{
- controlVars[i] = var_GetFloat( p_aout, psz_control_names[i] );
+ controlVars[i] = var_GetFloat( p_aout, spat_controls[i].psz_name );
}
vlc_object_release( p_aout );
}
}
vlc_object_release( p_aout );
}
psz_af = config_GetPsz( p_intf, "audio-filter" );
for( int i = 0; i < NUM_SP_CTRL ; i++ )
{
psz_af = config_GetPsz( p_intf, "audio-filter" );
for( int i = 0; i < NUM_SP_CTRL ; i++ )
{
- controlVars[i] = config_GetFloat( p_intf, psz_control_names[i] );
+ controlVars[i] = config_GetFloat( p_intf, spat_controls[i].psz_name );
}
}
if( psz_af && strstr( psz_af, "spatializer" ) != NULL )
}
}
if( psz_af && strstr( psz_af, "spatializer" ) != NULL )
setValues( controlVars );
}
setValues( controlVars );
}
-Spatializer::~Spatializer()
-{
-}
-
void Spatializer::enable()
{
bool en = enableCheck->isChecked();
void Spatializer::enable()
{
bool en = enableCheck->isChecked();
{
if( oldControlVars[i] != spatCtrl[i]->value() )
{
{
if( oldControlVars[i] != spatCtrl[i]->value() )
{
- var_SetFloat( p_aout, psz_control_names[i],
+ var_SetFloat( p_aout, spat_controls[i].psz_name,
( float )spatCtrl[i]->value() );
( float )spatCtrl[i]->value() );
- config_PutFloat( p_intf, psz_control_names[i],
+ config_PutFloat( p_intf, spat_controls[i].psz_name,
( float ) spatCtrl[i]->value() );
oldControlVars[i] = ( float ) spatCtrl[i]->value();
}
( float ) spatCtrl[i]->value() );
oldControlVars[i] = ( float ) spatCtrl[i]->value();
}
friend class ExtendedDialog;
public:
Equalizer( intf_thread_t *, QWidget * );
friend class ExtendedDialog;
public:
Equalizer( intf_thread_t *, QWidget * );
QComboBox *presetsComboBox;
char * createValuesFromPreset( int i_preset );
QComboBox *presetsComboBox;
char * createValuesFromPreset( int i_preset );
void addCallbacks( aout_instance_t * );
intf_thread_t *p_intf;
void addCallbacks( aout_instance_t * );
intf_thread_t *p_intf;
+ void clean() { enable(); }
private slots:
void enable(bool);
void enable();
private slots:
void enable(bool);
void enable();
+ intf_thread_t *p_intf;
+
void delCallbacks( aout_instance_t * );
void addCallbacks( aout_instance_t * );
void delCallbacks( aout_instance_t * );
void addCallbacks( aout_instance_t * );
+
+ void updateSliders(float *);
+ void setValues(float *);
+
private slots:
void enable(bool);
void enable();
private slots:
void enable(bool);
void enable();
- void updateSliders(float *);
- void setValues(float *);
Q_OBJECT
public:
Spatializer( intf_thread_t *, QWidget * );
Q_OBJECT
public:
Spatializer( intf_thread_t *, QWidget * );
- virtual ~Spatializer();
private:
QSlider *spatCtrl[NUM_SP_CTRL];
private:
QSlider *spatCtrl[NUM_SP_CTRL];
void delCallbacks( aout_instance_t * );
void addCallbacks( aout_instance_t * );
intf_thread_t *p_intf;
void delCallbacks( aout_instance_t * );
void addCallbacks( aout_instance_t * );
intf_thread_t *p_intf;
+
+ void setValues(float *);
+
private slots:
void enable(bool);
void enable();
private slots:
void enable(bool);
void enable();
- void setValues(float *);