summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
490f530)
ABI break. Reported by Dan Dennedy.
output_color_rgba(false),
output_color_ycbcr(false),
dither_effect(NULL),
output_color_rgba(false),
output_color_ycbcr(false),
dither_effect(NULL),
+ ycbcr_conversion_effect_node(NULL),
intermediate_format(GL_RGBA16F),
intermediate_transformation(NO_FRAMEBUFFER_TRANSFORMATION),
num_dither_bits(0),
intermediate_format(GL_RGBA16F),
intermediate_transformation(NO_FRAMEBUFFER_TRANSFORMATION),
num_dither_bits(0),
output_ycbcr_format = ycbcr_format;
if (finalized) {
output_ycbcr_format = ycbcr_format;
if (finalized) {
- // Find the YCbCrConversionEffect node. We don't store it to avoid
- // an unneeded ABI break (this can be fixed on next break).
- for (Node *node : nodes) {
- if (node->effect->effect_type_id() == "YCbCrConversionEffect") {
- YCbCrConversionEffect *effect = (YCbCrConversionEffect *)(node->effect);
- effect->change_output_format(ycbcr_format);
- }
- }
+ YCbCrConversionEffect *effect = (YCbCrConversionEffect *)(ycbcr_conversion_effect_node->effect);
+ effect->change_output_format(ycbcr_format);
return;
}
Node *output = find_output_node();
return;
}
Node *output = find_output_node();
- Node *ycbcr = add_node(new YCbCrConversionEffect(output_ycbcr_format));
- connect_nodes(output, ycbcr);
+ ycbcr_conversion_effect_node = add_node(new YCbCrConversionEffect(output_ycbcr_format));
+ connect_nodes(output, ycbcr_conversion_effect_node);
}
// If the user has requested dither, add a DitherEffect right at the end
}
// If the user has requested dither, add a DitherEffect right at the end
std::vector<Node *> nodes;
std::map<Effect *, Node *> node_map;
Effect *dither_effect;
std::vector<Node *> nodes;
std::map<Effect *, Node *> node_map;
Effect *dither_effect;
+ Node *ycbcr_conversion_effect_node;
std::vector<Input *> inputs; // Also contained in nodes.
std::vector<Phase *> phases;
std::vector<Input *> inputs; // Also contained in nodes.
std::vector<Phase *> phases;