if (p_vout == NULL)
return -1;
- /* FIXME: This is not atomic. Someone else could change the values,
- * at least in theory. */
+ /* FIXME: This is not atomic. All parameters should be passed at once
+ * (obviously _not_ with var_*()). Also, the libvlc object should not be
+ * used for the callbacks: that breaks badly if there are concurrent
+ * media players in the instance. */
+ var_Create( p_vout, "snapshot-width", VLC_VAR_INTEGER );
var_SetInteger( p_vout, "snapshot-width", i_width);
+ var_Create( p_vout, "snapshot-height", VLC_VAR_INTEGER );
var_SetInteger( p_vout, "snapshot-height", i_height );
+ var_Create( p_vout, "snapshot-path", VLC_VAR_STRING );
var_SetString( p_vout, "snapshot-path", psz_filepath );
+ var_Create( p_vout, "snapshot-format", VLC_VAR_STRING );
var_SetString( p_vout, "snapshot-format", "png" );
var_TriggerCallback( p_vout, "video-snapshot" );
vlc_object_release( p_vout );
if (type && image_Type2Fourcc(type))
codec = image_Type2Fourcc(type);
- const int override_width = var_GetInteger(vout, "snapshot-width");
- const int override_height = var_GetInteger(vout, "snapshot-height");
+ const int override_width = var_InheritInteger(vout, "snapshot-width");
+ const int override_height = var_InheritInteger(vout, "snapshot-height");
if (picture_Export(VLC_OBJECT(vout), image_dst, fmt,
picture, codec, override_width, override_height)) {
char *psz_buf;
/* Create a few object variables we'll need later on */
- var_Create( p_vout, "snapshot-path", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-prefix", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-format", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-preview", VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-sequential",
- VLC_VAR_BOOL | VLC_VAR_DOINHERIT );
var_Create( p_vout, "snapshot-num", VLC_VAR_INTEGER );
var_SetInteger( p_vout, "snapshot-num", 1 );
- var_Create( p_vout, "snapshot-width", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
- var_Create( p_vout, "snapshot-height", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
var_Create( p_vout, "width", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
var_Create( p_vout, "height", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
msg_Dbg( p_vout, "snapshot taken (%s)", psz_filename );
vout_OSDMessage( p_vout, SPU_DEFAULT_CHANNEL, "%s", psz_filename );
- if( var_GetBool( p_vout, "snapshot-preview" ) )
+ if( var_InheritBool( p_vout, "snapshot-preview" ) )
{
if( VoutSnapshotPip( p_vout, p_pic ) )
msg_Warn( p_vout, "Failed to display snapshot" );
*/
static void VoutSaveSnapshot( vout_thread_t *p_vout )
{
- char *psz_path = var_GetNonEmptyString( p_vout, "snapshot-path" );
- char *psz_format = var_GetNonEmptyString( p_vout, "snapshot-format" );
- char *psz_prefix = var_GetNonEmptyString( p_vout, "snapshot-prefix" );
+ char *psz_path = var_InheritString( p_vout, "snapshot-path" );
+ char *psz_format = var_InheritString( p_vout, "snapshot-format" );
+ char *psz_prefix = var_InheritString( p_vout, "snapshot-prefix" );
/* */
picture_t *p_picture;
vout_snapshot_save_cfg_t cfg;
memset( &cfg, 0, sizeof(cfg) );
- cfg.is_sequential = var_GetBool( p_vout, "snapshot-sequential" );
+ cfg.is_sequential = var_InheritBool( p_vout, "snapshot-sequential" );
cfg.sequence = var_GetInteger( p_vout, "snapshot-num" );
cfg.path = psz_path;
cfg.format = psz_format;