Remove stupid test and error message.

diff --git a/modules/visualization/visual/effects.c b/modules/visualization/visual/effects.c
index 2b83cc8c655c09d656a6a6aedc0344e59d07298a..6566f4f024d256f5efe92f2491b3c205b7abdc43 100644 (file)
--- a/modules/visualization/visual/effects.c
+++ b/modules/visualization/visual/effects.c
@@ -315,8 +315,6 @@ int spectrum_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
     fft_close( p_state );
 
     free( p_s16_buff );
-    p_s16_buff = NULL;
-
     free( height );
 
     return 0;

diff --git a/modules/visualization/visual/visual.c b/modules/visualization/visual/visual.c
index 2f1351af68ec8f23194df310508eb5e445899901..73a71a67217e56fcee4d674c003569e2c05f309e 100644 (file)
--- a/modules/visualization/visual/visual.c
+++ b/modules/visualization/visual/visual.c
@@ -203,10 +203,7 @@ static int Open( vlc_object_t *p_this )
 
     p_sys = p_filter->p_sys = malloc( sizeof( aout_filter_sys_t ) );
     if( p_sys == NULL )
-    {
-        msg_Err( p_filter, "out of memory" );
         return VLC_EGENERIC;
-    }
 
     p_sys->i_height = config_GetInt( p_filter , "effect-height");
     p_sys->i_width  = config_GetInt( p_filter , "effect-width");
@@ -296,10 +293,7 @@ static int Open( vlc_object_t *p_this )
         }
     }
 
-    if( psz_effects )
-    {
-        free( psz_effects );
-    }
+    free( psz_effects );
 
     if( !p_sys->i_effect )
     {