Revert "Simplify - CID 6"

This reverts commit 9ca4d5423b158b41090e9c0a621b5916fc040133 which
introduces a segfault.

diff --git a/modules/access/smb.c b/modules/access/smb.c
index 83fcd0739a444317eea3275d637ccdea7065fc1d..4072071684bb5a182814701625dcab3c23f8fe55 100644 (file)
--- a/modules/access/smb.c
+++ b/modules/access/smb.c
@@ -189,11 +189,11 @@ static int Open( vlc_object_t *p_this )
      * smb://[[[domain;]user[:password@]]server[/share[/path[/file]]]] */
 
     if( !psz_user ) psz_user = var_CreateGetString( p_access, "smb-user" );
-    if( !*psz_user ) { free( psz_user ); psz_user = 0; }
+    if( psz_user && !*psz_user ) { free( psz_user ); psz_user = 0; }
     if( !psz_pwd ) psz_pwd = var_CreateGetString( p_access, "smb-pwd" );
-    if( !*psz_pwd ) { free( psz_pwd ); psz_pwd = 0; }
+    if( psz_pwd && !*psz_pwd ) { free( psz_pwd ); psz_pwd = 0; }
     if( !psz_domain ) psz_domain = var_CreateGetString( p_access, "smb-domain" );
-    if( !*psz_domain ) { free( psz_domain ); psz_domain = 0; }
+    if( psz_domain && !*psz_domain ) { free( psz_domain ); psz_domain = 0; }
 
 #ifdef WIN32
     if( psz_user )