]> git.sesse.net Git - ffmpeg/commitdiff
libxvid: Make codec use the init-cleanup flag and mark it as init-thread-safe
authorVittorio Giovara <vittorio.giovara@gmail.com>
Mon, 6 Apr 2015 23:47:18 +0000 (01:47 +0200)
committerVittorio Giovara <vittorio.giovara@gmail.com>
Fri, 24 Apr 2015 13:55:11 +0000 (14:55 +0100)
This takes care of memory leaks on init error.

libavcodec/libxvid.c

index 6486ad185568fd941c8b7cffbbfc51c74a7fc39d..46da773052e14a49d09357eea651b06a570eaf90 100644 (file)
@@ -33,6 +33,7 @@
 #include "libavutil/mathematics.h"
 
 #include "avcodec.h"
+#include "internal.h"
 #include "libxvid.h"
 #include "mpegvideo.h"
 
@@ -778,8 +779,12 @@ static av_cold int xvid_encode_close(AVCodecContext *avctx)
 {
     struct xvid_context *x = avctx->priv_data;
 
-    xvid_encore(x->encoder_handle, XVID_ENC_DESTROY, NULL, NULL);
+    if (x->encoder_handle) {
+        xvid_encore(x->encoder_handle, XVID_ENC_DESTROY, NULL, NULL);
+        x->encoder_handle = NULL;
+    }
 
+    av_frame_free(&avctx->coded_frame);
     av_freep(&avctx->extradata);
     if (x->twopassbuffer) {
         av_free(x->twopassbuffer);
@@ -824,4 +829,6 @@ AVCodec ff_libxvid_encoder = {
     .close          = xvid_encode_close,
     .pix_fmts       = (const enum AVPixelFormat[]) { AV_PIX_FMT_YUV420P, AV_PIX_FMT_NONE },
     .priv_class     = &xvid_class,
+    .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE |
+                      FF_CODEC_CAP_INIT_CLEANUP,
 };