* Fix a couple of const, static and other warnings

diff --git a/src/audio_output/input.c b/src/audio_output/input.c
index 192ac9443acf7c38bda14c4c3943e9afbe1f882b..47d341755604b912fa41b9537e414e776f8cd7bc 100644 (file)
--- a/src/audio_output/input.c
+++ b/src/audio_output/input.c
@@ -650,8 +650,8 @@ static void inputFailure( aout_instance_t * p_aout, aout_input_t * p_input,
     p_input->b_error = 1;
 }
 
-static int ChangeFiltersString( aout_instance_t * p_aout, char* psz_variable,
-                                 char *psz_name, vlc_bool_t b_add )
+static int ChangeFiltersString( aout_instance_t * p_aout, const char* psz_variable,
+                                 const char *psz_name, vlc_bool_t b_add )
 {
     vlc_value_t val;
     char *psz_parser;

diff --git a/src/misc/image.c b/src/misc/image.c
index e5b3266e8061e24958edb7603d7b87c876193d24..a751a8d37c06c2a96231b80c2113b3a18ff49cb2 100644 (file)
--- a/src/misc/image.c
+++ b/src/misc/image.c
@@ -242,7 +242,7 @@ static picture_t *ImageReadUrl( image_handler_t *p_image, const char *psz_url,
  *
  */
 
-void PicRelease( picture_t *p_pic ){};
+static void PicRelease( picture_t *p_pic ){};
 
 static block_t *ImageWrite( image_handler_t *p_image, picture_t *p_pic,
                             video_format_t *p_fmt_in,
@@ -500,7 +500,7 @@ static picture_t *ImageFilter( image_handler_t *p_image, picture_t *p_pic,
 static struct
 {
     vlc_fourcc_t i_codec;
-    char *psz_ext;
+    const char *psz_ext;
 
 } ext_table[] =
 {

diff --git a/src/misc/threads.c b/src/misc/threads.c
index c2c8ef9788dd95c0f4418e7b878d5e8169a7aa0f..da17ec9dda560cbf89752fd2f19d7e12a7fcb58c 100644 (file)
--- a/src/misc/threads.c
+++ b/src/misc/threads.c
@@ -332,7 +332,7 @@ int __vlc_mutex_destroy( const char * psz_file, int i_line, vlc_mutex_t *p_mutex
     i_result = pthread_mutex_destroy( &p_mutex->mutex );
     if( i_result )
     {
-        i_thread = (int)pthread_self();
+        i_thread = CAST_PTHREAD_TO_INT(pthread_self());
         psz_error = strerror(i_result);
     }
 
@@ -482,7 +482,7 @@ int __vlc_cond_destroy( const char * psz_file, int i_line, vlc_cond_t *p_condvar
     i_result = pthread_cond_destroy( &p_condvar->cond );
     if( i_result )
     {
-        i_thread = (int)pthread_self();
+        i_thread = CAST_PTHREAD_TO_INT(pthread_self());
         psz_error = strerror(i_result);
     }
 

diff --git a/src/stream_output/profiles.c b/src/stream_output/profiles.c
index 7dc344eae9818b1cd1fb636b488619d3a02e82b6..9a1a32b2a89171fed347bbfb2578e47ae37c2e25 100644 (file)
--- a/src/stream_output/profiles.c
+++ b/src/stream_output/profiles.c
@@ -441,7 +441,8 @@ static char * ChainToPsz( sout_chain_t *p_chain, vlc_bool_t b_root )
     char psz_output[MAX_CHAIN];
     char psz_temp[MAX_CHAIN];
     if( b_root ) sprintf( psz_output, "#" );
-    else sprintf( psz_output, "" );
+    else psz_output[0] = '\0';
+
     for( i = 0 ; i< p_chain->i_modules; i++ )
     {
         sout_module_t *p_module = p_chain->pp_modules[i];

diff --git a/src/stream_output/stream_output.c b/src/stream_output/stream_output.c
index ed37472fb824fa31d0b3821d6846cb546517c512..adbb23d8fd122b68d010be81ecce40540a67c33e 100644 (file)
--- a/src/stream_output/stream_output.c
+++ b/src/stream_output/stream_output.c
@@ -62,7 +62,7 @@ typedef struct
 } mrl_t;
 
 /* mrl_Parse: parse psz_mrl and fill p_mrl */
-static int  mrl_Parse( mrl_t *p_mrl, char *psz_mrl );
+static int  mrl_Parse( mrl_t *p_mrl, const char *psz_mrl );
 /* mrl_Clean: clean p_mrl  after a call to mrl_Parse */
 static void mrl_Clean( mrl_t *p_mrl );
 
@@ -605,13 +605,13 @@ void sout_MuxSendBuffer( sout_mux_t *p_mux, sout_input_t *p_input,
 /*****************************************************************************
  *
  *****************************************************************************/
-static int mrl_Parse( mrl_t *p_mrl, char *psz_mrl )
+static int mrl_Parse( mrl_t *p_mrl, const char *psz_mrl )
 {
     char * psz_dup = strdup( psz_mrl );
     char * psz_parser = psz_dup;
-    char * psz_access = "";
-    char * psz_way = "";
-    char * psz_name = "";
+    char * psz_access;
+    char * psz_way;
+    char * psz_name;
 
     /* *** first parse psz_dest */
     while( *psz_parser && *psz_parser != ':' )

diff --git a/src/text/charset.c b/src/text/charset.c
index 5d1191158ab13d5bf5208f92686374e500e6bcfc..8f0a4ac99ef877f98e7aadac340f529ad74d5de3 100644 (file)
--- a/src/text/charset.c
+++ b/src/text/charset.c
@@ -365,9 +365,8 @@ char *vlc_fix_readdir( const char *psz_string )
         *psz_out = '\0';
         return psz_utf8;
     }
-#else
-    return strdup( psz_string );
 #endif
+    return strdup( psz_string );
 }