]> git.sesse.net Git - vlc/commitdiff
Don't try to lock locked mutexes under valgrind
authorRémi Denis-Courmont <remi@remlab.net>
Mon, 13 Apr 2009 20:40:22 +0000 (23:40 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Mon, 13 Apr 2009 20:40:22 +0000 (23:40 +0300)
This removes a lot of false true positives.

src/misc/threads.c

index 2b13262bf9097293d909adf63b051974dfb2a35f..c0bf8fdcd21dd17d312c307c95be6b65b8292951 100644 (file)
@@ -357,8 +357,16 @@ void vlc_mutex_destroy (vlc_mutex_t *p_mutex)
 }
 
 #if defined(LIBVLC_USE_PTHREAD) && !defined(NDEBUG)
+# ifdef HAVE_VALGRIND_VALGRIND_H
+#  include <valgrind/valgrind.h>
+# else
+#  define RUNNING_ON_VALGRIND (0)
+# endif
+
 void vlc_assert_locked (vlc_mutex_t *p_mutex)
 {
+    if (RUNNING_ON_VALGRIND > 0)
+        return;
     assert (pthread_mutex_lock (p_mutex) == EDEADLK);
 }
 #endif