]> git.sesse.net Git - kdenlive/commitdiff
For effects with no parameters: show the "full"(=effectstack)-comment by default
authorTill Theato <root@ttill.de>
Sun, 9 Jan 2011 13:56:49 +0000 (13:56 +0000)
committerTill Theato <root@ttill.de>
Sun, 9 Jan 2011 13:56:49 +0000 (13:56 +0000)
svn path=/trunk/kdenlive/; revision=5315

src/effectstackview.cpp

index 1c2fe12ce9a8f75a7c1afbfe524c2dd76ea47ac5..0908fea54ef122ac898cf82343183872f0a68f34 100644 (file)
@@ -313,8 +313,9 @@ void EffectStackView::slotItemSelectionChanged(bool update)
     int activeRow = m_ui.effectlist->currentRow();
     bool isChecked = false;
     if (hasItem && m_ui.effectlist->currentItem()->checkState() == Qt::Checked) isChecked = true;
+    QDomElement eff;
     if (hasItem && m_ui.effectlist->currentItem()->isSelected()) {
-        QDomElement eff = m_currentEffectList.at(activeRow);
+        eff = m_currentEffectList.at(activeRow);
         if (m_trackMode) {
             // showing track effects
             m_effectedit->transferParamDesc(eff, 0, 0, m_trackInfo.duration);
@@ -335,7 +336,7 @@ void EffectStackView::slotItemSelectionChanged(bool update)
     m_ui.buttonShowComments->setEnabled(hasItem);
 
     emit showComments(m_ui.buttonShowComments->isChecked());
-    m_ui.labelComment->setHidden(!m_ui.buttonShowComments->isChecked() || !m_ui.labelComment->text().count() || !hasItem);
+    m_ui.labelComment->setVisible(hasItem && m_ui.labelComment->text().count() && (m_ui.buttonShowComments->isChecked() || !eff.elementsByTagName("parameter").count()));
 }
 
 void EffectStackView::slotItemUp()