]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/mjpegdec: Restore non bayer checks in ljpeg_decode_rgb_scan()
authorMichael Niedermayer <michael@niedermayer.cc>
Thu, 12 Sep 2019 19:13:11 +0000 (21:13 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Fri, 13 Sep 2019 19:53:27 +0000 (21:53 +0200)
Fixes: out of array write
Fixes: 17088/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEGLS_fuzzer-5654877765632000
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/mjpegdec.c

index 5a80b7d289ee69db1373265242a5140d18984bb6..f095afaed8fdf491fd52623420813669a1fef6be 100644 (file)
@@ -1071,6 +1071,10 @@ static int ljpeg_decode_rgb_scan(MJpegDecodeContext *s, int nb_components, int p
     int resync_mb_x = 0;
     int vpred[6];
 
+    if (!s->bayer && s->nb_components < 3)
+        return AVERROR_INVALIDDATA;
+    if (s->bayer && s->nb_components > 2)
+        return AVERROR_INVALIDDATA;
     if (s->nb_components <= 0 || s->nb_components > 4)
         return AVERROR_INVALIDDATA;
     if (s->v_max != 1 || s->h_max != 1 || !s->lossless)