Small cleanup for insert_event().

diff --git a/main.cpp b/main.cpp
index a89e4785acd17404f8c0825a640c50759248d5dd..fc44d5cea0b9a11fa0afcf3d5e73a2f95d9f7f59 100644 (file)
--- a/main.cpp
+++ b/main.cpp
@@ -91,13 +91,13 @@ MainWindow::MainWindow(EventsModel *events, PlayersModel *players) : events(even
                ui->play_pause->setShortcut(QCoreApplication::translate("MainWindow", "Space", nullptr));
        });
 
-       connect(ui->player_1, &QPushButton::clicked, [this]() { insert_event(1); });
-       connect(ui->player_2, &QPushButton::clicked, [this]() { insert_event(2); });
-       connect(ui->player_3, &QPushButton::clicked, [this]() { insert_event(3); });
-       connect(ui->player_4, &QPushButton::clicked, [this]() { insert_event(4); });
-       connect(ui->player_5, &QPushButton::clicked, [this]() { insert_event(5); });
-       connect(ui->player_6, &QPushButton::clicked, [this]() { insert_event(6); });
-       connect(ui->player_7, &QPushButton::clicked, [this]() { insert_event(7); });
+       connect(ui->player_1, &QPushButton::clicked, [this]() { insert_player_event(0); });
+       connect(ui->player_2, &QPushButton::clicked, [this]() { insert_player_event(1); });
+       connect(ui->player_3, &QPushButton::clicked, [this]() { insert_player_event(2); });
+       connect(ui->player_4, &QPushButton::clicked, [this]() { insert_player_event(3); });
+       connect(ui->player_5, &QPushButton::clicked, [this]() { insert_player_event(4); });
+       connect(ui->player_6, &QPushButton::clicked, [this]() { insert_player_event(5); });
+       connect(ui->player_7, &QPushButton::clicked, [this]() { insert_player_event(6); });
 
        // Offensive events
        connect(ui->offense_label, &ClickableLabel::clicked, [this]() { insert_noplayer_event("set_offense"); });
@@ -182,14 +182,14 @@ void MainWindow::seek(int64_t delta_ms)
        }
 }
 
-void MainWindow::insert_event(int button_id)
+void MainWindow::insert_player_event(int button_id)
 {
        uint64_t t = video->position();
        vector<int> team = events->sort_team(events->get_team_at(t));
-       if (button_id > team.size()) {
+       if (button_id >= team.size()) {
                return;
        }
-       int player_id = team[button_id - 1];
+       int player_id = team[button_id];
 
        EventsModel::Status s = events->get_status_at(t);
 

diff --git a/mainwindow.h b/mainwindow.h
index 805fb125f6c2dc7a056889488cf3c9d2f7777b42..2d702c75a4d8544b2d861ec25368e71547d6b607 100644 (file)
--- a/mainwindow.h
+++ b/mainwindow.h
@@ -18,7 +18,7 @@ public:
 private:
        void position_changed(uint64_t pos);
        void seek(int64_t delta_ms);
-       void insert_event(int button_id);
+       void insert_player_event(int button_id);
        void insert_noplayer_event(const std::string &type);
        void set_current_event_type(const std::string &type);
        void delete_current_event();