]> git.sesse.net Git - ffmpeg/commitdiff
indeo3: fix motion vector validation
authorHendrik Leppkes <h.leppkes@gmail.com>
Wed, 25 Jan 2012 16:37:26 +0000 (17:37 +0100)
committerMichael Niedermayer <michaelni@gmx.at>
Wed, 25 Jan 2012 17:55:32 +0000 (18:55 +0100)
The index of the motion vector has to be checked before being
multiplied by 2 for the array index.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavcodec/indeo3.c

index ce84d72f8b5b60f491be1c5a92707ba0ae71f1f8..fc38f5e9cbd095ddf4bc1c667890e38d8745c9c6 100644 (file)
@@ -772,13 +772,12 @@ static int parse_bintree(Indeo3DecodeContext *ctx, AVCodecContext *avctx,
                 /* get motion vector index and setup the pointer to the mv set */
                 if (!ctx->need_resync)
                     ctx->next_cell_data = &ctx->gb.buffer[(get_bits_count(&ctx->gb) + 7) >> 3];
-                if(ctx->mc_vectors)
-                    mv_idx = *(ctx->next_cell_data++) << 1;
+                mv_idx = *(ctx->next_cell_data++);
                 if (mv_idx >= ctx->num_vectors) {
                     av_log(avctx, AV_LOG_ERROR, "motion vector index out of range\n");
                     return AVERROR_INVALIDDATA;
                 }
-                curr_cell.mv_ptr = &ctx->mc_vectors[mv_idx];
+                curr_cell.mv_ptr = &ctx->mc_vectors[mv_idx << 1];
                 curr_cell.tree   = 1; /* enter the VQ tree */
                 UPDATE_BITPOS(8);
             } else { /* VQ tree DATA code */