]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/truespeech: Fix integer overflow in truespeech_synth()
authorMichael Niedermayer <michael@niedermayer.cc>
Mon, 7 Oct 2019 16:13:26 +0000 (18:13 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Thu, 24 Oct 2019 22:22:33 +0000 (00:22 +0200)
Fixes: signed integer overflow: -1801695444 + -830224908 cannot be represented in type 'int'
Fixes: 17995/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUESPEECH_fuzzer-5648084880588800
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/truespeech.c

index 799cef0945fbecc2369474b9ed894851606e6cac..d7c2d535e21870e0f61255aee440eee28ffdca9f 100644 (file)
@@ -254,7 +254,7 @@ static void truespeech_synth(TSContext *dec, int16_t *out, int quart)
     for(i = 0; i < 60; i++){
         int sum = 0;
         for(k = 0; k < 8; k++)
-            sum += ptr0[k] * ptr1[k];
+            sum += ptr0[k] * (unsigned)ptr1[k];
         sum = out[i] + ((sum + 0x800) >> 12);
         out[i] = av_clip(sum, -0x7FFE, 0x7FFE);
         for(k = 7; k > 0; k--)