]> git.sesse.net Git - kdenlive/commitdiff
projectsettings.cpp: return if open() fails
authorMikko Rapeli <mikko.rapeli@iki.fi>
Fri, 10 Aug 2012 12:17:14 +0000 (14:17 +0200)
committerJean-Baptiste Mardelle <jb@kdenlive.org>
Sun, 2 Sep 2012 09:40:49 +0000 (11:40 +0200)
Fixes Coverity CID 709281: Unchecked return value (CHECKED_RETURN)
Calling function "QFile::open(QFlags<QIODevice::OpenModeFlag>)" without checking return value (as is done elsewhere 45 out of 47 times).
No check of the return value of "xmlf.open(QIODevice::OpenMode(_ZN9QIODevice9WriteOnlyE))".
552    xmlf.open(QIODevice::WriteOnly);

src/projectsettings.cpp

index ba8aebfe66a3b12f97eb2625f0023007f47df5d0..9289e18e0875a4099d61f08fae83573a104eb684 100644 (file)
@@ -549,7 +549,8 @@ void ProjectSettings::slotExportToText()
         return;
     }
     QFile xmlf(tmpfile.fileName());
-    xmlf.open(QIODevice::WriteOnly);
+    if (!xmlf.open(QIODevice::WriteOnly))
+        return;
     xmlf.write(data.toUtf8());
     if (xmlf.error() != QFile::NoError) {
         xmlf.close();