]> git.sesse.net Git - vlc/commitdiff
Revert "variables: Inherit path is now parent->libvlc->saved config"
authorDerk-Jan Hartman <hartman@videolan.org>
Fri, 19 Sep 2008 21:53:52 +0000 (23:53 +0200)
committerDerk-Jan Hartman <hartman@videolan.org>
Fri, 19 Sep 2008 21:54:43 +0000 (23:54 +0200)
Deadlocks libvlc, and atm. I do not know how to fix this.
This reverts commit 45e43037a961531a28444d969f903c18929b06b9.

src/misc/variables.c

index c97d8cdef451c75baf24d4c433ad3f56275a28ec..b51c65aca9057733b5215ce05094ff8f1589ff09 100644 (file)
@@ -1453,12 +1453,11 @@ static int InheritValue( vlc_object_t *p_this, const char *psz_name,
 {
     int i_var;
     variable_t *p_var;
-    vlc_object_internals_t *p_priv;
 
     /* No need to take the structure lock,
      * we are only looking for our parents */
 
-    if( !p_this->p_parent && !p_this->p_libvlc )
+    if( !p_this->p_parent )
     {
         switch( i_type & VLC_VAR_CLASS )
         {
@@ -1512,10 +1511,7 @@ static int InheritValue( vlc_object_t *p_this, const char *psz_name,
         return VLC_SUCCESS;
     }
 
-    if( !p_this->p_parent )
-        p_priv = vlc_internals( p_this->p_libvlc );
-    else
-        p_priv = vlc_internals( p_this->p_parent );
+    vlc_object_internals_t *p_priv = vlc_internals( p_this->p_parent );
 
     /* Look for the variable */
     vlc_mutex_lock( &p_priv->var_lock );