]> git.sesse.net Git - ffmpeg/commitdiff
tests/fate-run.sh: Don't overlook errors from md5 tests
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Fri, 4 Dec 2020 22:42:55 +0000 (23:42 +0100)
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Tue, 16 Feb 2021 21:50:36 +0000 (22:50 +0100)
The md5 test up until now ignored errors from ffmpeg (the cli) and just
md5'ed whatever ffmpeg has output; while testing scenarios in which
ffmpeg fails has its merits, errors should not be overlooked by default;
doing so also reduces the effectiveness of sanitizers as errors from
them are ignored. This has happened with a memleak in the AV1 decoder.

Reviewed-by: Anton Khirnov <anton@khirnov.net>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
tests/fate-run.sh

index 58d5fdbb6017609939c9b4cce4d950855fbc4364..b69176f7c3bd20f9f0460c3c6fc0fcdc94fce9da 100755 (executable)
@@ -158,7 +158,7 @@ md5pipe(){
 md5(){
     encfile="${outdir}/${test}.out"
     cleanfiles="$cleanfiles $encfile"
-    ffmpeg -y "$@" $(target_path $encfile)
+    ffmpeg -y "$@" $(target_path $encfile) || return
     do_md5sum $encfile | awk '{print $1}'
 }