]> git.sesse.net Git - ffmpeg/commitdiff
Merge commit '9d599e3f6e61438772d8cddd6c9b7c495251f51e'
authorMichael Niedermayer <michaelni@gmx.at>
Wed, 2 Apr 2014 16:01:48 +0000 (18:01 +0200)
committerMichael Niedermayer <michaelni@gmx.at>
Wed, 2 Apr 2014 16:03:02 +0000 (18:03 +0200)
* commit '9d599e3f6e61438772d8cddd6c9b7c495251f51e':
  avi: Improve non-interleaved detection

Conflicts:
libavformat/avidec.c

See: 8df774be88c347c40f1b2411ed9e391dfec0ebb7 and others
Merged-by: Michael Niedermayer <michaelni@gmx.at>
1  2 
libavformat/avidec.c

diff --combined libavformat/avidec.c
index 52d0425507101d9b620ff9b6028a07c8fb48c2fc,c24a6c495dcf7ad10f6541596d72e549a3c46b5a..9a2424f7bdf77dfba1d38469540782b0e0cb4323
@@@ -2,29 -2,27 +2,29 @@@
   * AVI demuxer
   * Copyright (c) 2001 Fabrice Bellard
   *
 - * This file is part of Libav.
 + * This file is part of FFmpeg.
   *
 - * Libav is free software; you can redistribute it and/or
 + * FFmpeg is free software; you can redistribute it and/or
   * modify it under the terms of the GNU Lesser General Public
   * License as published by the Free Software Foundation; either
   * version 2.1 of the License, or (at your option) any later version.
   *
 - * Libav is distributed in the hope that it will be useful,
 + * FFmpeg is distributed in the hope that it will be useful,
   * but WITHOUT ANY WARRANTY; without even the implied warranty of
   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
   * Lesser General Public License for more details.
   *
   * You should have received a copy of the GNU Lesser General Public
 - * License along with Libav; if not, write to the Free Software
 + * License along with FFmpeg; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
   */
  
  #include <inttypes.h>
  
 +#include "libavutil/avassert.h"
  #include "libavutil/avstring.h"
  #include "libavutil/bswap.h"
 +#include "libavutil/opt.h"
  #include "libavutil/dict.h"
  #include "libavutil/internal.h"
  #include "libavutil/intreadwrite.h"
@@@ -35,6 -33,9 +35,6 @@@
  #include "internal.h"
  #include "riff.h"
  
 -#undef NDEBUG
 -#include <assert.h>
 -
  typedef struct AVIStream {
      int64_t frame_offset;   /* current frame (video) or byte (audio) counter
                               * (used to compute the pts) */
      AVFormatContext *sub_ctx;
      AVPacket sub_pkt;
      uint8_t *sub_buffer;
 +
 +    int64_t seek_pos;
  } AVIStream;
  
  typedef struct {
 +    const AVClass *class;
      int64_t riff_end;
      int64_t movi_end;
      int64_t fsize;
 +    int64_t io_fsize;
      int64_t movi_list;
      int64_t last_pkt_pos;
      int index_loaded;
      int stream_index;
      DVDemuxContext *dv_demux;
      int odml_depth;
 +    int use_odml;
  #define MAX_ODML_DEPTH 1000
 +    int64_t dts_max;
  } AVIContext;
  
 +
 +static const AVOption options[] = {
 +    { "use_odml", "use odml index", offsetof(AVIContext, use_odml), AV_OPT_TYPE_INT, {.i64 = 1}, -1, 1, AV_OPT_FLAG_DECODING_PARAM},
 +    { NULL },
 +};
 +
 +static const AVClass demuxer_class = {
 +    .class_name = "avi",
 +    .item_name  = av_default_item_name,
 +    .option     = options,
 +    .version    = LIBAVUTIL_VERSION_INT,
 +    .category   = AV_CLASS_CATEGORY_DEMUXER,
 +};
 +
 +
  static const char avi_headers[][8] = {
      { 'R', 'I', 'F', 'F', 'A', 'V', 'I', ' '  },
      { 'R', 'I', 'F', 'F', 'A', 'V', 'I', 'X'  },
@@@ -113,8 -93,8 +113,8 @@@ static int avi_load_index(AVFormatConte
  static int guess_ni_flag(AVFormatContext *s);
  
  #define print_tag(str, tag, size)                        \
 -    av_dlog(NULL, "%s: tag=%c%c%c%c size=0x%x\n",        \
 -            str, tag & 0xff,                             \
 +    av_dlog(NULL, "pos:%"PRIX64" %s: tag=%c%c%c%c size=0x%x\n", \
 +            avio_tell(pb), str, tag & 0xff,              \
              (tag >> 8) & 0xff,                           \
              (tag >> 16) & 0xff,                          \
              (tag >> 24) & 0xff,                          \
@@@ -171,7 -151,7 +171,7 @@@ static int read_braindead_odml_indx(AVF
      AVIStream *ast;
      int i;
      int64_t last_pos = -1;
 -    int64_t filesize = avio_size(s->pb);
 +    int64_t filesize = avi->fsize;
  
      av_dlog(s,
              "longs_pre_entry:%d index_type:%d entries_in_use:%d "
              int key     = len >= 0;
              len &= 0x7FFFFFFF;
  
 -            av_dlog(s, "pos:%"PRId64", len:%X\n", pos, len);
 -
 -            if (pb->eof_reached)
 +#ifdef DEBUG_SEEK
 +            av_log(s, AV_LOG_ERROR, "pos:%"PRId64", len:%X\n", pos, len);
 +#endif
 +            if (url_feof(pb))
                  return AVERROR_INVALIDDATA;
  
              if (last_pos == pos || pos == base - 8)
              avio_rl32(pb);       /* size */
              duration = avio_rl32(pb);
  
 -            if (pb->eof_reached)
 +            if (url_feof(pb))
                  return AVERROR_INVALIDDATA;
  
              pos = avio_tell(pb);
                  return AVERROR_INVALIDDATA;
              }
  
 -            avio_seek(pb, offset + 8, SEEK_SET);
 +            if (avio_seek(pb, offset + 8, SEEK_SET) < 0)
 +                return -1;
              avi->odml_depth++;
              read_braindead_odml_indx(s, frame_num);
              avi->odml_depth--;
              frame_num += duration;
  
 -            avio_seek(pb, pos, SEEK_SET);
 +            if (avio_seek(pb, pos, SEEK_SET) < 0) {
 +                av_log(s, AV_LOG_ERROR, "Failed to restore position after reading index\n");
 +                return -1;
 +            }
 +
          }
      }
 -    avi->index_loaded = 1;
 +    avi->index_loaded = 2;
      return 0;
  }
  
@@@ -350,7 -324,6 +350,7 @@@ static void avi_read_nikon(AVFormatCont
                  uint16_t size    = avio_rl16(s->pb);
                  const char *name = NULL;
                  char buffer[64]  = { 0 };
 +                size = FFMIN(size, tag_end - avio_tell(s->pb));
                  size -= avio_read(s->pb, buffer,
                                    FFMIN(size, sizeof(buffer) - 1));
                  switch (tag) {
      }
  }
  
 +static int calculate_bitrate(AVFormatContext *s)
 +{
 +    AVIContext *avi = s->priv_data;
 +    int i, j;
 +    int64_t lensum = 0;
 +    int64_t maxpos = 0;
 +
 +    for (i = 0; i<s->nb_streams; i++) {
 +        int64_t len = 0;
 +        AVStream *st = s->streams[i];
 +
 +        if (!st->nb_index_entries)
 +            continue;
 +
 +        for (j = 0; j < st->nb_index_entries; j++)
 +            len += st->index_entries[j].size;
 +        maxpos = FFMAX(maxpos, st->index_entries[j-1].pos);
 +        lensum += len;
 +    }
 +    if (maxpos < avi->io_fsize*9/10) // index doesnt cover the whole file
 +        return 0;
 +    if (lensum*9/10 > maxpos || lensum < maxpos*9/10) // frame sum and filesize mismatch
 +        return 0;
 +
 +    for (i = 0; i<s->nb_streams; i++) {
 +        int64_t len = 0;
 +        AVStream *st = s->streams[i];
 +        int64_t duration;
 +
 +        for (j = 0; j < st->nb_index_entries; j++)
 +            len += st->index_entries[j].size;
 +
 +        if (st->nb_index_entries < 2 || st->codec->bit_rate > 0)
 +            continue;
 +        duration = st->index_entries[j-1].timestamp - st->index_entries[0].timestamp;
 +        st->codec->bit_rate = av_rescale(8*len, st->time_base.den, duration * st->time_base.num);
 +    }
 +    return 1;
 +}
 +
  static int avi_read_header(AVFormatContext *s)
  {
      AVIContext *avi = s->priv_data;
      int amv_file_format = 0;
      uint64_t list_end   = 0;
      int ret;
 +    AVDictionaryEntry *dict_entry;
  
      avi->stream_index = -1;
  
      if (ret < 0)
          return ret;
  
 -    avi->fsize = avio_size(pb);
 -    if (avi->fsize <= 0)
 +    av_log(avi, AV_LOG_DEBUG, "use odml:%d\n", avi->use_odml);
 +
 +    avi->io_fsize = avi->fsize = avio_size(pb);
 +    if (avi->fsize <= 0 || avi->fsize < avi->riff_end)
          avi->fsize = avi->riff_end == 8 ? INT64_MAX : avi->riff_end;
  
      /* first list tag */
      codec_type   = -1;
      frame_period = 0;
      for (;;) {
 -        if (pb->eof_reached)
 +        if (url_feof(pb))
              goto fail;
          tag  = avio_rl32(pb);
          size = avio_rl32(pb);
                  if (size)
                      avi->movi_end = avi->movi_list + size + (size & 1);
                  else
 -                    avi->movi_end = avio_size(pb);
 +                    avi->movi_end = avi->fsize;
                  av_dlog(NULL, "movi end=%"PRIx64"\n", avi->movi_end);
                  goto end_of_header;
              } else if (tag1 == MKTAG('I', 'N', 'F', 'O'))
              /* AVI header */
              /* using frame_period is bad idea */
              frame_period = avio_rl32(pb);
 -            avio_skip(pb, 4);
 +            avio_rl32(pb); /* max. bytes per second */
              avio_rl32(pb);
              avi->non_interleaved |= avio_rl32(pb) & AVIF_MUSTUSEINDEX;
  
                  ast = s->streams[0]->priv_data;
                  av_freep(&s->streams[0]->codec->extradata);
                  av_freep(&s->streams[0]->codec);
 +                if (s->streams[0]->info)
 +                    av_freep(&s->streams[0]->info->duration_error);
                  av_freep(&s->streams[0]->info);
                  av_freep(&s->streams[0]);
                  s->nb_streams = 0;
                  break;
              }
  
 -            assert(stream_index < s->nb_streams);
 +            av_assert0(stream_index < s->nb_streams);
              st->codec->stream_codec_tag = handler;
  
              avio_rl32(pb); /* flags */
              st->start_time = 0;
              avio_rl32(pb); /* buffer size */
              avio_rl32(pb); /* quality */
 +            if (ast->cum_len*ast->scale/ast->rate > 3600) {
 +                av_log(s, AV_LOG_ERROR, "crazy start time, iam scared, giving up\n");
 +                return AVERROR_INVALIDDATA;
 +            }
              ast->sample_size = avio_rl32(pb); /* sample ssize */
              ast->cum_len    *= FFMAX(1, ast->sample_size);
              av_dlog(s, "%"PRIu32" %"PRIu32" %d\n",
                  codec_type = AVMEDIA_TYPE_DATA;
                  break;
              default:
 -                av_log(s, AV_LOG_ERROR, "unknown stream type %X\n", tag1);
 -                goto fail;
 +                av_log(s, AV_LOG_INFO, "unknown stream type %X\n", tag1);
              }
 -            if (ast->sample_size == 0)
 +            if (ast->sample_size == 0) {
                  st->duration = st->nb_frames;
 +                if (st->duration > 0 && avi->io_fsize > 0 && avi->riff_end > avi->io_fsize) {
 +                    av_log(s, AV_LOG_DEBUG, "File is truncated adjusting duration\n");
 +                    st->duration = av_rescale(st->duration, avi->io_fsize, avi->riff_end);
 +                }
 +            }
              ast->frame_offset = ast->cum_len;
              avio_skip(pb, size - 12 * 4);
              break;
          case MKTAG('s', 't', 'r', 'f'):
              /* stream header */
 +            if (!size)
 +                break;
              if (stream_index >= (unsigned)s->nb_streams || avi->dv_demux) {
                  avio_skip(pb, size);
              } else {
                  uint64_t cur_pos = avio_tell(pb);
 +                unsigned esize;
                  if (cur_pos < list_end)
                      size = FFMIN(size, list_end - cur_pos);
                  st = s->streams[stream_index];
 +                if (st->codec->codec_type != AVMEDIA_TYPE_UNKNOWN) {
 +                    avio_skip(pb, size);
 +                    break;
 +                }
                  switch (codec_type) {
                  case AVMEDIA_TYPE_VIDEO:
                      if (amv_file_format) {
                          avio_skip(pb, size);
                          break;
                      }
 -                    tag1 = ff_get_bmp_header(pb, st);
 +                    tag1 = ff_get_bmp_header(pb, st, &esize);
  
                      if (tag1 == MKTAG('D', 'X', 'S', 'B') ||
                          tag1 == MKTAG('D', 'X', 'S', 'A')) {
                          break;
                      }
  
 -                    if (size > 10 * 4 && size < (1 << 30)) {
 -                        st->codec->extradata_size = size - 10 * 4;
 -                        st->codec->extradata      = av_malloc(st->codec->extradata_size +
 -                                                              FF_INPUT_BUFFER_PADDING_SIZE);
 -                        if (!st->codec->extradata) {
 -                            st->codec->extradata_size = 0;
 +                    if (size > 10 * 4 && size < (1 << 30) && size < avi->fsize) {
 +                        if (esize == size-1 && (esize&1)) {
 +                            st->codec->extradata_size = esize - 10 * 4;
 +                        } else
 +                            st->codec->extradata_size =  size - 10 * 4;
 +                        if (ff_get_extradata(st->codec, pb, st->codec->extradata_size) < 0)
                              return AVERROR(ENOMEM);
 -                        }
 -                        avio_read(pb,
 -                                  st->codec->extradata,
 -                                  st->codec->extradata_size);
                      }
  
                      // FIXME: check if the encoder really did this correctly
                      /* Extract palette from extradata if bpp <= 8.
                       * This code assumes that extradata contains only palette.
                       * This is true for all paletted codecs implemented in
 -                     * Libav. */
 +                     * FFmpeg. */
                      if (st->codec->extradata_size &&
                          (st->codec->bits_per_coded_sample <= 8)) {
                          int pal_size = (1 << st->codec->bits_per_coded_sample) << 2;
                          pal_size = FFMIN(pal_size, st->codec->extradata_size);
                          pal_src  = st->codec->extradata +
                                     st->codec->extradata_size - pal_size;
 -#if HAVE_BIGENDIAN
                          for (i = 0; i < pal_size / 4; i++)
 -                            ast->pal[i] = av_bswap32(((uint32_t *)pal_src)[i]);
 -#else
 -                        memcpy(ast->pal, pal_src, pal_size);
 -#endif
 +                            ast->pal[i] = 0xFFU<<24 | AV_RL32(pal_src+4*i);
                          ast->has_pal = 1;
                      }
  
                      /* This is needed to get the pict type which is necessary
                       * for generating correct pts. */
                      st->need_parsing = AVSTREAM_PARSE_HEADERS;
 -                    // Support "Resolution 1:1" for Avid AVI Codec
 -                    if (tag1 == MKTAG('A', 'V', 'R', 'n') &&
 -                        st->codec->extradata_size >= 31   &&
 -                        !memcmp(&st->codec->extradata[28], "1:1", 3))
 -                        st->codec->codec_id = AV_CODEC_ID_RAWVIDEO;
 +                    if (st->codec->codec_tag == MKTAG('V', 'S', 'S', 'H'))
 +                        st->need_parsing = AVSTREAM_PARSE_FULL;
  
                      if (st->codec->codec_tag == 0 && st->codec->height > 0 &&
                          st->codec->extradata_size < 1U << 30) {
                      if (st->codec->stream_codec_tag == AV_RL32("Axan")) {
                          st->codec->codec_id  = AV_CODEC_ID_XAN_DPCM;
                          st->codec->codec_tag = 0;
 +                        ast->dshow_block_align = 0;
                      }
                      if (amv_file_format) {
                          st->codec->codec_id    = AV_CODEC_ID_ADPCM_IMA_AMV;
                          ast->dshow_block_align = 0;
                      }
 +                    if (st->codec->codec_id == AV_CODEC_ID_AAC && ast->dshow_block_align <= 4 && ast->dshow_block_align) {
 +                        av_log(s, AV_LOG_DEBUG, "overriding invalid dshow_block_align of %d\n", ast->dshow_block_align);
 +                        ast->dshow_block_align = 0;
 +                    }
 +                    if (st->codec->codec_id == AV_CODEC_ID_AAC && ast->dshow_block_align == 1024 && ast->sample_size == 1024 ||
 +                       st->codec->codec_id == AV_CODEC_ID_AAC && ast->dshow_block_align == 4096 && ast->sample_size == 4096 ||
 +                       st->codec->codec_id == AV_CODEC_ID_MP3 && ast->dshow_block_align == 1152 && ast->sample_size == 1152) {
 +                        av_log(s, AV_LOG_DEBUG, "overriding sample_size\n");
 +                        ast->sample_size = 0;
 +                    }
                      break;
                  case AVMEDIA_TYPE_SUBTITLE:
                      st->codec->codec_type = AVMEDIA_TYPE_SUBTITLE;
 -                    st->codec->codec_id   = AV_CODEC_ID_PROBE;
 +                    st->request_probe= 1;
 +                    avio_skip(pb, size);
                      break;
                  default:
                      st->codec->codec_type = AVMEDIA_TYPE_DATA;
                  }
              }
              break;
 +        case MKTAG('s', 't', 'r', 'd'):
 +            if (stream_index >= (unsigned)s->nb_streams
 +                || s->streams[stream_index]->codec->extradata_size
 +                || s->streams[stream_index]->codec->codec_tag == MKTAG('H','2','6','4')) {
 +                avio_skip(pb, size);
 +            } else {
 +                uint64_t cur_pos = avio_tell(pb);
 +                if (cur_pos < list_end)
 +                    size = FFMIN(size, list_end - cur_pos);
 +                st = s->streams[stream_index];
 +
 +                if (size<(1<<30)) {
 +                    if (ff_get_extradata(st->codec, pb, size) < 0)
 +                        return AVERROR(ENOMEM);
 +                }
 +
 +                if (st->codec->extradata_size & 1) //FIXME check if the encoder really did this correctly
 +                    avio_r8(pb);
 +            }
 +            break;
          case MKTAG('i', 'n', 'd', 'x'):
              i = avio_tell(pb);
              if (pb->seekable && !(s->flags & AVFMT_FLAG_IGNIDX) &&
 +                avi->use_odml &&
                  read_braindead_odml_indx(s, 0) < 0 &&
                  (s->error_recognition & AV_EF_EXPLODE))
                  goto fail;
                  if (s->error_recognition & AV_EF_EXPLODE)
                      goto fail;
                  avi->movi_list = avio_tell(pb) - 4;
 -                avi->movi_end  = avio_size(pb);
 +                avi->movi_end  = avi->fsize;
                  goto end_of_header;
              }
              /* skip tag */
@@@ -903,28 -794,17 +903,32 @@@ fail
  
      if (!avi->index_loaded && pb->seekable)
          avi_load_index(s);
 -    avi->index_loaded     = 1;
 +    calculate_bitrate(s);
 +    avi->index_loaded    |= 1;
-     avi->non_interleaved |= guess_ni_flag(s) | (s->flags & AVFMT_FLAG_SORT_DTS);
+     if ((ret = guess_ni_flag(s)) < 0)
+         return ret;
 -    avi->non_interleaved |= ret;
++    avi->non_interleaved |= ret | (s->flags & AVFMT_FLAG_SORT_DTS);
 +
 +    dict_entry = av_dict_get(s->metadata, "ISFT", NULL, 0);
 +    if (dict_entry && !strcmp(dict_entry->value, "PotEncoder"))
 +        for (i = 0; i < s->nb_streams; i++) {
 +            AVStream *st = s->streams[i];
 +            if (   st->codec->codec_id == AV_CODEC_ID_MPEG1VIDEO
 +                || st->codec->codec_id == AV_CODEC_ID_MPEG2VIDEO)
 +                st->need_parsing = AVSTREAM_PARSE_FULL;
 +        }
 +
      for (i = 0; i < s->nb_streams; i++) {
          AVStream *st = s->streams[i];
          if (st->nb_index_entries)
              break;
      }
 +    // DV-in-AVI cannot be non-interleaved, if set this must be
 +    // a mis-detection.
 +    if (avi->dv_demux)
 +        avi->non_interleaved = 0;
      if (i == s->nb_streams && avi->non_interleaved) {
          av_log(s, AV_LOG_WARNING,
                 "Non-interleaved AVI without index, switching to interleaved\n");
  static int read_gab2_sub(AVStream *st, AVPacket *pkt)
  {
      if (pkt->size >= 7 &&
 +        pkt->size < INT_MAX - AVPROBE_PADDING_SIZE &&
          !strcmp(pkt->data, "GAB2") && AV_RL16(pkt->data + 5) == 2) {
          uint8_t desc[256];
          int score      = AVPROBE_SCORE_EXTENSION, ret;
          AVIStream *ast = st->priv_data;
          AVInputFormat *sub_demuxer;
          AVRational time_base;
 +        int size;
          AVIOContext *pb = avio_alloc_context(pkt->data + 7,
                                               pkt->size - 7,
                                               0, NULL, NULL, NULL, NULL);
          avio_rl16(pb);   /* flags? */
          avio_rl32(pb);   /* data size */
  
 -        pd = (AVProbeData) { .buf      = pb->buf_ptr,
 -                             .buf_size = pb->buf_end - pb->buf_ptr };
 -        if (!(sub_demuxer = av_probe_input_format2(&pd, 1, &score)))
 +        size = pb->buf_end - pb->buf_ptr;
 +        pd = (AVProbeData) { .buf      = av_mallocz(size + AVPROBE_PADDING_SIZE),
 +                             .buf_size = size };
 +        if (!pd.buf)
 +            goto error;
 +        memcpy(pd.buf, pb->buf_ptr, size);
 +        sub_demuxer = av_probe_input_format2(&pd, 1, &score);
 +        av_freep(&pd.buf);
 +        if (!sub_demuxer)
              goto error;
  
          if (!(ast->sub_ctx = avformat_alloc_context()))
@@@ -1036,7 -908,7 +1040,7 @@@ static AVStream *get_subtitle_pkt(AVFor
      return sub_st;
  }
  
 -static int get_stream_idx(int *d)
 +static int get_stream_idx(unsigned *d)
  {
      if (d[0] >= '0' && d[0] <= '9' &&
          d[1] >= '0' && d[1] <= '9') {
      }
  }
  
 +/**
 + *
 + * @param exit_early set to 1 to just gather packet position without making the changes needed to actually read & return the packet
 + */
  static int avi_sync(AVFormatContext *s, int exit_early)
  {
      AVIContext *avi = s->priv_data;
  
  start_sync:
      memset(d, -1, sizeof(d));
 -    for (i = sync = avio_tell(pb); !pb->eof_reached; i++) {
 +    for (i = sync = avio_tell(pb); !url_feof(pb); i++) {
          int j;
  
          for (j = 0; j < 7; j++)
          n = get_stream_idx(d + 2);
          av_dlog(s, "%X %X %X %X %X %X %X %X %"PRId64" %u %d\n",
                  d[0], d[1], d[2], d[3], d[4], d[5], d[6], d[7], i, size, n);
 -        if (i + (uint64_t)size > avi->fsize || d[0] > 127)
 +        if (i*(avi->io_fsize>0) + (uint64_t)size > avi->fsize || d[0] > 127)
              continue;
  
          // parse ix##
              st  = s->streams[n];
              ast = st->priv_data;
  
 +            if (!ast) {
 +                av_log(s, AV_LOG_WARNING, "Skiping foreign stream %d packet\n", n);
 +                continue;
 +            }
 +
              if (s->nb_streams >= 2) {
                  AVStream *st1   = s->streams[1];
                  AVIStream *ast1 = st1->priv_data;
                  // workaround for broken small-file-bug402.avi
 -                if (d[2] == 'w' && d[3] == 'b' && n == 0 &&
 -                    st->codec->codec_type  == AVMEDIA_TYPE_VIDEO &&
 -                    st1->codec->codec_type == AVMEDIA_TYPE_AUDIO &&
 -                    ast->prefix == 'd' * 256 + 'c' &&
 -                    (d[2] * 256 + d[3] == ast1->prefix ||
 -                     !ast1->prefix_count)) {
 +                if (   d[2] == 'w' && d[3] == 'b'
 +                   && n == 0
 +                   && st ->codec->codec_type == AVMEDIA_TYPE_VIDEO
 +                   && st1->codec->codec_type == AVMEDIA_TYPE_AUDIO
 +                   && ast->prefix == 'd'*256+'c'
 +                   && (d[2]*256+d[3] == ast1->prefix || !ast1->prefix_count)
 +                  ) {
                      n   = 1;
                      st  = st1;
                      ast = ast1;
                  || st->discard >= AVDISCARD_ALL)) {
                  if (!exit_early) {
                      ast->frame_offset += get_duration(ast, size);
 +                    avio_skip(pb, size);
 +                    goto start_sync;
                  }
 -                avio_skip(pb, size);
 -                goto start_sync;
              }
  
              if (d[2] == 'p' && d[3] == 'c' && size <= 4 * 256 + 4) {
  
                  // b + (g << 8) + (r << 16);
                  for (; k <= last; k++)
 -                    ast->pal[k] = avio_rb32(pb) >> 8;
 +                    ast->pal[k] = 0xFFU<<24 | avio_rb32(pb)>>8;
  
                  ast->has_pal = 1;
                  goto start_sync;
          }
      }
  
 +    if (pb->error)
 +        return pb->error;
      return AVERROR_EOF;
  }
  
@@@ -1248,7 -1108,10 +1252,7 @@@ static int avi_read_packet(AVFormatCont
              return AVERROR_EOF;
  
          best_ast = best_st->priv_data;
 -        best_ts  = av_rescale_q(best_ts,
 -                                (AVRational) { FFMAX(1, best_ast->sample_size),
 -                                               AV_TIME_BASE },
 -                                best_st->time_base);
 +        best_ts  = best_ast->frame_offset;
          if (best_ast->remaining) {
              i = av_index_search_timestamp(best_st,
                                            best_ts,
          if (i >= 0) {
              int64_t pos = best_st->index_entries[i].pos;
              pos += best_ast->packet_size - best_ast->remaining;
 -            avio_seek(s->pb, pos + 8, SEEK_SET);
 +            if (avio_seek(s->pb, pos + 8, SEEK_SET) < 0)
 +              return AVERROR_EOF;
  
 -            assert(best_ast->remaining <= best_ast->packet_size);
 +            av_assert0(best_ast->remaining <= best_ast->packet_size);
  
              avi->stream_index = best_stream_index;
              if (!best_ast->remaining)
                  best_ast->packet_size =
                  best_ast->remaining   = best_st->index_entries[i].size;
          }
 +        else
 +          return AVERROR_EOF;
      }
  
  resync:
          err               = av_get_packet(pb, pkt, size);
          if (err < 0)
              return err;
 +        size = err;
  
 -        if (ast->has_pal && pkt->data && pkt->size < (unsigned)INT_MAX / 2) {
 +        if (ast->has_pal && pkt->size < (unsigned)INT_MAX / 2) {
              uint8_t *pal;
              pal = av_packet_new_side_data(pkt,
                                            AV_PKT_DATA_PALETTE,
@@@ -1325,7 -1184,7 +1329,7 @@@ FF_DISABLE_DEPRECATION_WARNING
  FF_ENABLE_DEPRECATION_WARNINGS
  #endif
              size = avpriv_dv_produce_packet(avi->dv_demux, pkt,
 -                                            pkt->data, pkt->size);
 +                                            pkt->data, pkt->size, pkt->pos);
  #if FF_API_DESTRUCT_PACKET
  FF_DISABLE_DEPRECATION_WARNINGS
              pkt->destruct = dstr;
@@@ -1360,34 -1219,17 +1364,34 @@@ FF_ENABLE_DEPRECATION_WARNING
                      size);
              pkt->stream_index = avi->stream_index;
  
 -            if (st->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
 +            if (st->codec->codec_type == AVMEDIA_TYPE_VIDEO && st->index_entries) {
                  AVIndexEntry *e;
                  int index;
 -                assert(st->index_entries);
  
                  index = av_index_search_timestamp(st, ast->frame_offset, 0);
                  e     = &st->index_entries[index];
  
 -                if (index >= 0 && e->timestamp == ast->frame_offset)
 +                if (index >= 0 && e->timestamp == ast->frame_offset) {
 +                    if (index == st->nb_index_entries-1) {
 +                        int key=1;
 +                        int i;
 +                        uint32_t state=-1;
 +                        for (i=0; i<FFMIN(size,256); i++) {
 +                            if (st->codec->codec_id == AV_CODEC_ID_MPEG4) {
 +                                if (state == 0x1B6) {
 +                                    key= !(pkt->data[i]&0xC0);
 +                                    break;
 +                                }
 +                            }else
 +                                break;
 +                            state= (state<<8) + pkt->data[i];
 +                        }
 +                        if (!key)
 +                            e->flags &= ~AVINDEX_KEYFRAME;
 +                    }
                      if (e->flags & AVINDEX_KEYFRAME)
                          pkt->flags |= AV_PKT_FLAG_KEY;
 +                }
              } else {
                  pkt->flags |= AV_PKT_FLAG_KEY;
              }
              ast->packet_size  = 0;
          }
  
 +        if (!avi->non_interleaved && pkt->pos >= 0 && ast->seek_pos > pkt->pos) {
 +            av_free_packet(pkt);
 +            goto resync;
 +        }
 +        ast->seek_pos= 0;
 +
 +        if (!avi->non_interleaved && st->nb_index_entries>1 && avi->index_loaded>1) {
 +            int64_t dts= av_rescale_q(pkt->dts, st->time_base, AV_TIME_BASE_Q);
 +
 +            if (avi->dts_max - dts > 2*AV_TIME_BASE) {
 +                avi->non_interleaved= 1;
 +                av_log(s, AV_LOG_INFO, "Switching to NI mode, due to poor interleaving\n");
 +            }else if (avi->dts_max < dts)
 +                avi->dts_max = dts;
 +        }
 +
          return 0;
      }
  
@@@ -1434,9 -1260,7 +1438,9 @@@ static int avi_read_idx1(AVFormatContex
      AVIStream *ast;
      unsigned int index, tag, flags, pos, len, first_packet = 1;
      unsigned last_pos = -1;
 +    unsigned last_idx = -1;
      int64_t idx1_pos, first_packet_pos = 0, data_offset = 0;
 +    int anykey = 0;
  
      nb_index_entries = size / 16;
      if (nb_index_entries <= 0)
      avi->stream_index = -1;
      avio_seek(pb, idx1_pos, SEEK_SET);
  
 +    if (s->nb_streams == 1 && s->streams[0]->codec->codec_tag == AV_RL32("MMES")) {
 +        first_packet_pos = 0;
 +        data_offset = avi->movi_list;
 +    }
 +
      /* Read the entries and sort them in each stream component. */
      for (i = 0; i < nb_index_entries; i++) {
 +        if (url_feof(pb))
 +            return -1;
 +
          tag   = avio_rl32(pb);
          flags = avio_rl32(pb);
          pos   = avio_rl32(pb);
          st  = s->streams[index];
          ast = st->priv_data;
  
 -        if (first_packet && first_packet_pos && len) {
 +        if (first_packet && first_packet_pos) {
              data_offset  = first_packet_pos - pos;
              first_packet = 0;
          }
  
          av_dlog(s, "%d cum_len=%"PRId64"\n", len, ast->cum_len);
  
 -        if (pb->eof_reached)
 -            return AVERROR_INVALIDDATA;
 -
 +        // even if we have only a single stream, we should
 +        // switch to non-interleaved to get correct timestamps
          if (last_pos == pos)
              avi->non_interleaved = 1;
 -        else if (len || !ast->sample_size)
 +        if (last_idx != pos && len) {
              av_add_index_entry(st, pos, ast->cum_len, len, 0,
                                 (flags & AVIIF_INDEX) ? AVINDEX_KEYFRAME : 0);
 +            last_idx= pos;
 +        }
          ast->cum_len += get_duration(ast, len);
          last_pos      = pos;
 +        anykey       |= flags&AVIIF_INDEX;
 +    }
 +    if (!anykey) {
 +        for (index = 0; index < s->nb_streams; index++) {
 +            st = s->streams[index];
 +            if (st->nb_index_entries)
 +                st->index_entries[0].flags |= AVINDEX_KEYFRAME;
 +        }
      }
      return 0;
  }
  
 -
+ /* Scan the index and consider any file with streams more than
+  * 2 seconds or 64MB apart non-interleaved. */
+ static int check_stream_max_drift(AVFormatContext *s)
+ {
+     int64_t min_pos, pos;
+     int i;
+     int *idx = av_mallocz_array(s->nb_streams, sizeof(*idx));
+     if (!idx)
+         return AVERROR(ENOMEM);
+     for (min_pos = pos = 0; min_pos != INT64_MAX; pos = min_pos + 1LU) {
+         int64_t max_dts = INT64_MIN / 2;
+         int64_t min_dts = INT64_MAX / 2;
+         int64_t max_buffer = 0;
+         min_pos = INT64_MAX;
+         for (i = 0; i < s->nb_streams; i++) {
+             AVStream *st = s->streams[i];
+             AVIStream *ast = st->priv_data;
+             int n = st->nb_index_entries;
+             while (idx[i] < n && st->index_entries[idx[i]].pos < pos)
+                 idx[i]++;
+             if (idx[i] < n) {
+                 int64_t dts;
+                 dts = av_rescale_q(st->index_entries[idx[i]].timestamp /
+                                    FFMAX(ast->sample_size, 1),
+                                    st->time_base, AV_TIME_BASE_Q);
+                 min_dts = FFMIN(min_dts, dts);
+                 min_pos = FFMIN(min_pos, st->index_entries[idx[i]].pos);
+             }
+         }
+         for (i = 0; i < s->nb_streams; i++) {
+             AVStream *st = s->streams[i];
+             AVIStream *ast = st->priv_data;
+             if (idx[i] && min_dts != INT64_MAX / 2) {
+                 int64_t dts;
+                 dts = av_rescale_q(st->index_entries[idx[i] - 1].timestamp /
+                                    FFMAX(ast->sample_size, 1),
+                                    st->time_base, AV_TIME_BASE_Q);
+                 max_dts = FFMAX(max_dts, dts);
+                 max_buffer = FFMAX(max_buffer,
+                                    av_rescale(dts - min_dts,
+                                               st->codec->bit_rate,
+                                               AV_TIME_BASE));
+             }
+         }
+         if (max_dts - min_dts > 2 * AV_TIME_BASE ||
+             max_buffer > 1024 * 1024 * 8 * 8) {
+             av_free(idx);
+             return 1;
+         }
+     }
+     av_free(idx);
+     return 0;
+ }
  static int guess_ni_flag(AVFormatContext *s)
  {
      int i;
      int64_t last_start = 0;
      int64_t first_end  = INT64_MAX;
      int64_t oldpos     = avio_tell(s->pb);
-     int *idx;
 +    int64_t min_pos, pos;
  
      for (i = 0; i < s->nb_streams; i++) {
          AVStream *st = s->streams[i];
              first_end = st->index_entries[n - 1].pos;
      }
      avio_seek(s->pb, oldpos, SEEK_SET);
      if (last_start > first_end)
          return 1;
-     idx= av_calloc(s->nb_streams, sizeof(*idx));
-     if (!idx)
-         return 0;
-     for (min_pos=pos=0; min_pos!=INT64_MAX; pos= min_pos+1LU) {
-         int64_t max_dts = INT64_MIN/2, min_dts= INT64_MAX/2;
-         int64_t max_buffer = 0;
-         min_pos = INT64_MAX;
  
-         for (i=0; i<s->nb_streams; i++) {
-             AVStream *st = s->streams[i];
-             AVIStream *ast = st->priv_data;
-             int n= st->nb_index_entries;
-             while (idx[i]<n && st->index_entries[idx[i]].pos < pos)
-                 idx[i]++;
-             if (idx[i] < n) {
-                 min_dts = FFMIN(min_dts, av_rescale_q(st->index_entries[idx[i]].timestamp/FFMAX(ast->sample_size, 1), st->time_base, AV_TIME_BASE_Q));
-                 min_pos = FFMIN(min_pos, st->index_entries[idx[i]].pos);
-             }
-         }
-         for (i=0; i<s->nb_streams; i++) {
-             AVStream *st = s->streams[i];
-             AVIStream *ast = st->priv_data;
-             if (idx[i] && min_dts != INT64_MAX/2) {
-                 int64_t dts = av_rescale_q(st->index_entries[idx[i]-1].timestamp/FFMAX(ast->sample_size, 1), st->time_base, AV_TIME_BASE_Q);
-                 max_dts = FFMAX(max_dts, dts);
-                 max_buffer = FFMAX(max_buffer, av_rescale(dts - min_dts, st->codec->bit_rate, AV_TIME_BASE));
-             }
-         }
-         if (max_dts - min_dts > 2*AV_TIME_BASE ||
-             max_buffer > 1024 * 1024 * 8 *8
-         ) {
-             av_free(idx);
-             return 1;
-         }
-     }
-     av_free(idx);
-     return 0;
+     return check_stream_max_drift(s);
  }
  
  static int avi_load_index(AVFormatContext *s)
      AVIOContext *pb = s->pb;
      uint32_t tag, size;
      int64_t pos = avio_tell(pb);
 +    int64_t next;
      int ret     = -1;
  
      if (avio_seek(pb, avi->movi_end, SEEK_SET) < 0)
          goto the_end; // maybe truncated file
      av_dlog(s, "movi_end=0x%"PRIx64"\n", avi->movi_end);
      for (;;) {
 -        if (pb->eof_reached)
 -            break;
          tag  = avio_rl32(pb);
          size = avio_rl32(pb);
 +        if (url_feof(pb))
 +            break;
 +        next = avio_tell(pb) + size + (size & 1);
 +
          av_dlog(s, "tag=%c%c%c%c size=0x%x\n",
                   tag        & 0xff,
                  (tag >>  8) & 0xff,
  
          if (tag == MKTAG('i', 'd', 'x', '1') &&
              avi_read_idx1(s, size) >= 0) {
 +            avi->index_loaded=2;
              ret = 0;
 +        }else if (tag == MKTAG('L', 'I', 'S', 'T')) {
 +            uint32_t tag1 = avio_rl32(pb);
 +
 +            if (tag1 == MKTAG('I', 'N', 'F', 'O'))
 +                ff_read_riff_info(s, size - 4);
 +        }else if (!ret)
              break;
 -        }
  
 -        size += (size & 1);
 -        if (avio_skip(pb, size) < 0)
 +        if (avio_seek(pb, next, SEEK_SET) < 0)
              break; // something is wrong here
      }
  
@@@ -1640,7 -1460,7 +1665,7 @@@ static int avi_read_seek(AVFormatContex
      AVIContext *avi = s->priv_data;
      AVStream *st;
      int i, index;
 -    int64_t pos;
 +    int64_t pos, pos_min;
      AVIStream *ast;
  
      /* Does not matter which stream is requested dv in avi has the
      if (!avi->index_loaded) {
          /* we only load the index on demand */
          avi_load_index(s);
 -        avi->index_loaded = 1;
 +        avi->index_loaded |= 1;
      }
 +    av_assert0(stream_index >= 0);
  
      st    = s->streams[stream_index];
      ast   = st->priv_data;
      index = av_index_search_timestamp(st,
                                        timestamp * FFMAX(ast->sample_size, 1),
                                        flags);
 -    if (index < 0)
 +    if (index < 0) {
 +        if (st->nb_index_entries > 0)
 +            av_log(s, AV_LOG_DEBUG, "Failed to find timestamp %"PRId64 " in index %"PRId64 " .. %"PRId64 "\n",
 +                   timestamp * FFMAX(ast->sample_size, 1),
 +                   st->index_entries[0].timestamp,
 +                   st->index_entries[st->nb_index_entries - 1].timestamp);
          return AVERROR_INVALIDDATA;
 +    }
  
      /* find the position */
      pos       = st->index_entries[index].pos;
          /* offsets. Calling with other stream indexes should have failed */
          /* the av_index_search_timestamp call above.                     */
  
 +        if (avio_seek(s->pb, pos, SEEK_SET) < 0)
 +            return -1;
 +
          /* Feed the DV video stream version of the timestamp to the */
          /* DV demux so it can synthesize correct timestamps.        */
          ff_dv_offset_reset(avi->dv_demux, timestamp);
  
 -        avio_seek(s->pb, pos, SEEK_SET);
          avi->stream_index = -1;
          return 0;
      }
  
 +    pos_min = pos;
      for (i = 0; i < s->nb_streams; i++) {
          AVStream *st2   = s->streams[i];
          AVIStream *ast2 = st2->priv_data;
          if (st2->nb_index_entries <= 0)
              continue;
  
 -//        assert(st2->codec->block_align);
 -        assert((int64_t)st2->time_base.num * ast2->rate ==
 -               (int64_t)st2->time_base.den * ast2->scale);
 +//        av_assert1(st2->codec->block_align);
 +        av_assert0((int64_t)st2->time_base.num * ast2->rate ==
 +                   (int64_t)st2->time_base.den * ast2->scale);
          index = av_index_search_timestamp(st2,
                                            av_rescale_q(timestamp,
                                                         st->time_base,
                                                         st2->time_base) *
                                            FFMAX(ast2->sample_size, 1),
 -                                          flags | AVSEEK_FLAG_BACKWARD);
 +                                          flags |
 +                                          AVSEEK_FLAG_BACKWARD |
 +                                          (st2->codec->codec_type != AVMEDIA_TYPE_VIDEO ? AVSEEK_FLAG_ANY : 0));
          if (index < 0)
              index = 0;
 +        ast2->seek_pos = st2->index_entries[index].pos;
 +        pos_min = FFMIN(pos_min,ast2->seek_pos);
 +    }
 +    for (i = 0; i < s->nb_streams; i++) {
 +        AVStream *st2 = s->streams[i];
 +        AVIStream *ast2 = st2->priv_data;
  
 -        if (!avi->non_interleaved) {
 -            while (index > 0 && st2->index_entries[index].pos > pos)
 -                index--;
 -            while (index + 1 < st2->nb_index_entries &&
 -                   st2->index_entries[index].pos < pos)
 -                index++;
 -        }
 +        if (ast2->sub_ctx || st2->nb_index_entries <= 0)
 +            continue;
  
 -        av_dlog(s, "%"PRId64" %d %"PRId64"\n",
 -                timestamp, index, st2->index_entries[index].timestamp);
 -        /* extract the current frame number */
 +        index = av_index_search_timestamp(
 +                st2,
 +                av_rescale_q(timestamp, st->time_base, st2->time_base) * FFMAX(ast2->sample_size, 1),
 +                flags | AVSEEK_FLAG_BACKWARD | (st2->codec->codec_type != AVMEDIA_TYPE_VIDEO ? AVSEEK_FLAG_ANY : 0));
 +        if (index < 0)
 +            index = 0;
 +        while (!avi->non_interleaved && index>0 && st2->index_entries[index-1].pos >= pos_min)
 +            index--;
          ast2->frame_offset = st2->index_entries[index].timestamp;
      }
  
      /* do the seek */
 -    avio_seek(s->pb, pos, SEEK_SET);
 +    if (avio_seek(s->pb, pos_min, SEEK_SET) < 0) {
 +        av_log(s, AV_LOG_ERROR, "Seek failed\n");
 +        return -1;
 +    }
      avi->stream_index = -1;
 +    avi->dts_max      = INT_MIN;
      return 0;
  }
  
@@@ -1799,5 -1597,4 +1824,5 @@@ AVInputFormat ff_avi_demuxer = 
      .read_packet    = avi_read_packet,
      .read_close     = avi_read_close,
      .read_seek      = avi_read_seek,
 +    .priv_class = &demuxer_class,
  };