Use AVOnce as a static variable consistently

Using AVOnce as a stack variable makes no sense as the state is lost
when the function exits.

This fixes repeated calls to av(filter/device)_register_all

diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c
index 280a260bd39b1687778f51e11e8aa35c7c05f369..a8ed53ae5deb3273cc6f5b1d525a66f94144f37f 100644 (file)
--- a/libavdevice/alldevices.c
+++ b/libavdevice/alldevices.c
@@ -73,7 +73,7 @@ static void register_all(void)
 
 void avdevice_register_all(void)
 {
-    AVOnce control = AV_ONCE_INIT;
+    static AVOnce control = AV_ONCE_INIT;
 
     ff_thread_once(&control, register_all);
 }

diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c
index 2bcfce77bef055ad0e5d993e5cb3ddd9da7f62c3..f8cd193dbebc6fd3de0b7bfe41095b28f59b4122 100644 (file)
--- a/libavfilter/allfilters.c
+++ b/libavfilter/allfilters.c
@@ -390,7 +390,7 @@ static void register_all(void)
 
 void avfilter_register_all(void)
 {
-    AVOnce control = AV_ONCE_INIT;
+    static AVOnce control = AV_ONCE_INIT;
 
     ff_thread_once(&control, register_all);
 }

diff --git a/libavformat/allformats.c b/libavformat/allformats.c
index 62661d14a44d6e011a3f08207c127309535e4595..b3ffe0f2b68c39287f26f4f7b5e876421b8fd646 100644 (file)
--- a/libavformat/allformats.c
+++ b/libavformat/allformats.c
@@ -385,7 +385,7 @@ static void register_all(void)
 
 void av_register_all(void)
 {
-    AVOnce control = AV_ONCE_INIT;
+    static AVOnce control = AV_ONCE_INIT;
 
     ff_thread_once(&control, register_all);
 }