]> git.sesse.net Git - ffmpeg/commitdiff
avformat/utils: Don't trigger errors for multiple id3 tags.
authorDale Curtis <dalecurtis@chromium.org>
Fri, 21 Feb 2020 20:53:30 +0000 (12:53 -0800)
committerMichael Niedermayer <michael@niedermayer.cc>
Sat, 22 Feb 2020 19:52:32 +0000 (20:52 +0100)
Such errors may make sense for specific formats, but general parsing
logic shouldn't be treating these as errors regardless of the error
recognition mode.

Fixes loading of the following wave when using -err_detect explode:
https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/webaudio/resources/4ch-440.wav

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavformat/utils.c

index 123d67800bfa037e529829be705da73941ede109..cb15f6a4b37c8ac176bcaf0c7640bfd3fad1d3f7 100644 (file)
@@ -635,15 +635,8 @@ FF_ENABLE_DEPRECATION_WARNINGS
         s->metadata = s->internal->id3v2_meta;
         s->internal->id3v2_meta = NULL;
     } else if (s->internal->id3v2_meta) {
-        int level = AV_LOG_WARNING;
-        if (s->error_recognition & AV_EF_COMPLIANT)
-            level = AV_LOG_ERROR;
-        av_log(s, level, "Discarding ID3 tags because more suitable tags were found.\n");
+        av_log(s, AV_LOG_WARNING, "Discarding ID3 tags because more suitable tags were found.\n");
         av_dict_free(&s->internal->id3v2_meta);
-        if (s->error_recognition & AV_EF_EXPLODE) {
-            ret = AVERROR_INVALIDDATA;
-            goto close;
-        }
     }
 
     if (id3v2_extra_meta) {