]> git.sesse.net Git - ffmpeg/commitdiff
avformat/smacker: fix memleak when avformat_new_stream failed
authorSteven Liu <lq@chinaffmpeg.org>
Thu, 10 Oct 2019 02:07:54 +0000 (10:07 +0800)
committerSteven Liu <lq@chinaffmpeg.org>
Mon, 28 Oct 2019 06:26:16 +0000 (14:26 +0800)
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
libavformat/smacker.c

index b5c858aa9b1fcf6eafee8069bfd34bef388425d1..239894dad0ae1ff33eae629b522207c15b9a431c 100644 (file)
@@ -172,8 +172,11 @@ static int smacker_read_header(AVFormatContext *s)
 
     /* init video codec */
     st = avformat_new_stream(s, NULL);
-    if (!st)
+    if (!st) {
+        av_freep(&smk->frm_size);
+        av_freep(&smk->frm_flags);
         return AVERROR(ENOMEM);
+    }
     smk->videoindex = st->index;
     st->codecpar->width = smk->width;
     st->codecpar->height = smk->height;
@@ -195,8 +198,11 @@ static int smacker_read_header(AVFormatContext *s)
         smk->indexes[i] = -1;
         if (smk->rates[i]) {
             ast[i] = avformat_new_stream(s, NULL);
-            if (!ast[i])
+            if (!ast[i]) {
+                av_freep(&smk->frm_size);
+                av_freep(&smk->frm_flags);
                 return AVERROR(ENOMEM);
+            }
             smk->indexes[i] = ast[i]->index;
             ast[i]->codecpar->codec_type = AVMEDIA_TYPE_AUDIO;
             if (smk->aflags[i] & SMK_AUD_BINKAUD) {