]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/hevc_mp4toannexb_bsf: check that nalu size doesnt overflow
authorMichael Niedermayer <michael@niedermayer.cc>
Thu, 12 Dec 2019 23:50:21 +0000 (00:50 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Sat, 18 Jan 2020 17:35:57 +0000 (18:35 +0100)
Fixes: Out of array access
Fixes: 19299/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_MP4TOANNEXB_fuzzer-5169193398042624
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/hevc_mp4toannexb_bsf.c

index d0f1b94f0e7bb690a21eb997fe706e822e4bdc3d..baa93628ed205a6b613330fd189d775c5c10754d 100644 (file)
@@ -152,8 +152,7 @@ static int hevc_mp4toannexb_filter(AVBSFContext *ctx, AVPacket *out)
         extra_size    = add_extradata * ctx->par_out->extradata_size;
         got_irap     |= is_irap;
 
-        if (SIZE_MAX - nalu_size < 4 ||
-            SIZE_MAX - 4 - nalu_size < extra_size) {
+        if (FFMIN(INT_MAX, SIZE_MAX) < 4ULL + nalu_size + extra_size) {
             ret = AVERROR_INVALIDDATA;
             goto fail;
         }