]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/vp3: Check that theora is theora
authorMichael Niedermayer <michael@niedermayer.cc>
Sun, 21 Jul 2019 22:41:06 +0000 (00:41 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Fri, 2 Aug 2019 19:13:41 +0000 (21:13 +0200)
Theora is forced to be non zero if it is zero and a sample
is asked for, as suggested by reimar

Fixes: Timeout (2min -> 600ms)
Fixes: 15366/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5737849938247680
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/vp3.c

index a6f759ebf5b5e6e1090451412fd8d2efcecf9768..6ce901eda9fb357757ee3cffe65cb58ff343fa2a 100644 (file)
@@ -2957,6 +2957,10 @@ static int theora_decode_header(AVCodecContext *avctx, GetBitContext *gb)
     s->theora_header = 0;
     s->theora = get_bits_long(gb, 24);
     av_log(avctx, AV_LOG_DEBUG, "Theora bitstream version %X\n", s->theora);
+    if (!s->theora) {
+        s->theora = 1;
+        avpriv_request_sample(s->avctx, "theora 0");
+    }
 
     /* 3.2.0 aka alpha3 has the same frame orientation as original vp3
      * but previous versions have the image flipped relative to vp3 */