]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/wmalosslessdec: Fix integer overflow with sliding in padding bits
authorMichael Niedermayer <michael@niedermayer.cc>
Sat, 18 Jan 2020 18:55:23 +0000 (19:55 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Sun, 9 Feb 2020 22:33:18 +0000 (23:33 +0100)
Fixes: signed integer overflow: -53716100 * 256 cannot be represented in type 'int'
Fixes: 20143/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5716604000403456
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/wmalosslessdec.c

index d841ec256a421ab2b9611e99885e624a41f02818..88854879808379c09f6179f301e58efb47933c4b 100644 (file)
@@ -992,7 +992,7 @@ static int decode_subframe(WmallDecodeCtx *s)
             if (s->bits_per_sample == 16) {
                 *s->samples_16[c]++ = (int16_t) s->channel_residues[c][j] * (1 << padding_zeroes);
             } else {
-                *s->samples_32[c]++ = s->channel_residues[c][j] * (256 << padding_zeroes);
+                *s->samples_32[c]++ = s->channel_residues[c][j] * (256U << padding_zeroes);
             }
         }
     }