]> git.sesse.net Git - ffmpeg/commitdiff
avformat/flvdec: Check for avio_read() failure in amf_get_string()
authorMichael Niedermayer <michael@niedermayer.cc>
Tue, 26 Jan 2021 16:41:28 +0000 (17:41 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Tue, 26 Jan 2021 17:37:12 +0000 (18:37 +0100)
Suggested-by: Anton Khirnov <anton@khirnov.net>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavformat/flvdec.c

index 8571a626ae5e613c90534eb381d7248784feb558..c1f02125bc40de47458f532051fcc365ae53137a 100644 (file)
@@ -384,13 +384,18 @@ static int flv_set_video_codec(AVFormatContext *s, AVStream *vstream,
 
 static int amf_get_string(AVIOContext *ioc, char *buffer, int buffsize)
 {
+    int ret;
     int length = avio_rb16(ioc);
     if (length >= buffsize) {
         avio_skip(ioc, length);
         return -1;
     }
 
-    avio_read(ioc, buffer, length);
+    ret = avio_read(ioc, buffer, length);
+    if (ret < 0)
+        return ret;
+    if (ret < length)
+        return AVERROR_INVALIDDATA;
 
     buffer[length] = '\0';