]> git.sesse.net Git - kdenlive/commitdiff
Fix Coverity #980677
authorJean-Baptiste Mardelle <jb@kdenlive.org>
Tue, 12 Feb 2013 00:22:09 +0000 (01:22 +0100)
committerJean-Baptiste Mardelle <jb@kdenlive.org>
Tue, 12 Feb 2013 00:22:09 +0000 (01:22 +0100)
src/titledocument.cpp

index 8774ac8fe5ef3835085e164ec94a27b1c74bc49d..1c67206c8dbe1a38a8415254474f8e35807fb7b5 100644 (file)
@@ -231,7 +231,8 @@ QDomDocument TitleDocument::xml(QGraphicsRectItem* startv, QGraphicsRectItem* en
             if (blur) {
                 effect.setAttribute("type", "blur");
                 effect.setAttribute("blurradius", blur->blurRadius());
-            } else {
+            } /*else {
+               //WARNING:those effects are anyways broken because they use QPixmaps which are not safe for MLT's threaded workflow
                 QGraphicsDropShadowEffect *shadow = static_cast <QGraphicsDropShadowEffect *>(eff);
                 if (shadow) {
                     effect.setAttribute("type", "shadow");
@@ -239,7 +240,7 @@ QDomDocument TitleDocument::xml(QGraphicsRectItem* startv, QGraphicsRectItem* en
                     effect.setAttribute("xoffset", shadow->xOffset());
                     effect.setAttribute("yoffset", shadow->yOffset());
                 }
-            }
+            }*/
             e.appendChild(effect);
         }
 #endif