]> git.sesse.net Git - vlc/commitdiff
Qt4: passing pointers over thread signals is not allowed...
authorRémi Denis-Courmont <remi@remlab.net>
Sun, 28 Feb 2010 19:35:45 +0000 (21:35 +0200)
committerRémi Denis-Courmont <remi@remlab.net>
Sun, 28 Feb 2010 19:38:17 +0000 (21:38 +0200)
...unless proper reference counting si involved,
or the signal is blocking queued (but that is deadlock-prone).

Ref: LP#528285

modules/gui/qt4/components/info_panels.cpp

index c10caddd20fefbd275c1ecf8ec3bad9346ca1334..a0fbb5936929e733beee998dda47e62becfef49c 100644 (file)
@@ -162,6 +162,8 @@ MetaPanel::MetaPanel( QWidget *parent,
  **/
 void MetaPanel::update( input_item_t *p_item )
 {
+#warning This is wrong.
+#if 0
     if( !p_item )
     {
         clear();
@@ -243,7 +245,7 @@ void MetaPanel::update( input_item_t *p_item )
     }
 
     art_cover->showArtUpdate( file );
-
+#endif
 }
 
 /**