]> git.sesse.net Git - ffmpeg/commitdiff
swscale/output: Fix integer overflow in yuv2rgb_write_full() with out of range input
authorMichael Niedermayer <michael@niedermayer.cc>
Sun, 16 Feb 2020 19:11:52 +0000 (20:11 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Sat, 4 Apr 2020 20:09:46 +0000 (22:09 +0200)
Fixes: signed integer overflow: 1169365504 + 981452800 cannot be represented in type 'int'
Fixes: ticket8293
Found-by: Suhwan
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libswscale/output.c

index 9df6ba44c854a86fa88cf761cb7022c20b13876a..68f43ffba3952f84eb4dd790ae24f6a840d4108d 100644 (file)
@@ -1850,9 +1850,9 @@ static av_always_inline void yuv2rgb_write_full(SwsContext *c,
     Y -= c->yuv2rgb_y_offset;
     Y *= c->yuv2rgb_y_coeff;
     Y += 1 << 21;
-    R = Y + V*c->yuv2rgb_v2r_coeff;
-    G = Y + V*c->yuv2rgb_v2g_coeff + U*c->yuv2rgb_u2g_coeff;
-    B = Y +                          U*c->yuv2rgb_u2b_coeff;
+    R = (unsigned)Y + V*c->yuv2rgb_v2r_coeff;
+    G = (unsigned)Y + V*c->yuv2rgb_v2g_coeff + U*c->yuv2rgb_u2g_coeff;
+    B = (unsigned)Y +                          U*c->yuv2rgb_u2b_coeff;
     if ((R | G | B) & 0xC0000000) {
         R = av_clip_uintp2(R, 30);
         G = av_clip_uintp2(G, 30);