]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/wmv2dec: Check input bits vs. coded MBs
authorMichael Niedermayer <michael@niedermayer.cc>
Tue, 30 Apr 2019 22:40:03 +0000 (00:40 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Sun, 12 May 2019 14:31:39 +0000 (16:31 +0200)
Fixes: Timeout (94sec ->8sec)
Fixes: 14387/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV2_fuzzer-5723546887651328
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/wmv2dec.c

index 124dfdb7e0068a58999bb7b171e286b67ff0839d..afa65478e3450dbecf3289e8c6fb3d3d2b8b29c2 100644 (file)
@@ -33,6 +33,7 @@
 static int parse_mb_skip(Wmv2Context *w)
 {
     int mb_x, mb_y;
+    int coded_mb_count = 0;
     MpegEncContext *const s = &w->s;
     uint32_t *const mb_type = s->current_picture_ptr->mb_type;
 
@@ -83,6 +84,14 @@ static int parse_mb_skip(Wmv2Context *w)
         }
         break;
     }
+
+    for (mb_y = 0; mb_y < s->mb_height; mb_y++)
+        for (mb_x = 0; mb_x < s->mb_width; mb_x++)
+            coded_mb_count += !IS_SKIP(mb_type[mb_y * s->mb_stride + mb_x]);
+
+    if (coded_mb_count > get_bits_left(&s->gb))
+        return AVERROR_INVALIDDATA;
+
     return 0;
 }