]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/videotoolbox: make FFmpeg-to-VT mapping error more informative
authorJan Ekström <jeebjp@gmail.com>
Sat, 2 Jan 2021 12:30:36 +0000 (14:30 +0200)
committerJan Ekström <jeebjp@gmail.com>
Sat, 2 Jan 2021 12:36:22 +0000 (14:36 +0200)
Now logs the actual failed-to-map pixel format as well as range.

libavcodec/videotoolbox.c

index 8773de33930572ead9d3a0fdf92647be14301033..49e726a75fcd9ae679dd613806ccee5acdc5dfa2 100644 (file)
@@ -1088,7 +1088,13 @@ static int videotoolbox_common_init(AVCodecContext *avctx)
     vtctx->vt_ctx->cv_pix_fmt_type =
         av_map_videotoolbox_format_from_pixfmt2(hw_frames->sw_format, full_range);
     if (!vtctx->vt_ctx->cv_pix_fmt_type) {
-        av_log(avctx, AV_LOG_ERROR, "Unknown sw_format.\n");
+        const AVPixFmtDescriptor *attempted_format =
+            av_pix_fmt_desc_get(hw_frames->sw_format);
+        av_log(avctx, AV_LOG_ERROR,
+               "Failed to map underlying FFmpeg pixel format %s (%s range) to "
+               "a VideoToolbox format!\n",
+               attempted_format ? attempted_format->name : "<unknown>",
+               av_color_range_name(avctx->color_range));
         err = AVERROR(EINVAL);
         goto fail;
     }