Actually, the patch corrects three problems (2 pertaining to qt4 as a

dialog provider for skins and 1 as the regular qt4). The problems for
skins are real (lead to crashes when using menus). The one for regular
qt4 was obviously a typo, but sometimes even removing a typo may have
side effects. If so, please find attached a patch that reverts this part
of the previous patch.

Erwan10

Signed-off-by: Ilkka Ollakka <ileoo@videolan.org>

diff --git a/modules/gui/qt4/input_manager.cpp b/modules/gui/qt4/input_manager.cpp
index 13149bd6a744b487db83b95342a6b9588ff2498b..312dce101a950b3442f5159ae5cc9a51358ea29f 100644 (file)
--- a/modules/gui/qt4/input_manager.cpp
+++ b/modules/gui/qt4/input_manager.cpp
@@ -942,7 +942,7 @@ void MainInputManager::customEvent( QEvent *event )
         vlc_mutex_lock( &p_intf->change_lock );
         if( p_input && ( p_input->b_dead || !vlc_object_alive (p_input) ) )
         {
-            emit inputChanged( NULL );
+            emit inputChanged( p_input );
             var_DelCallback( p_input, "state", PLItemChanged, this );
             vlc_object_release( p_input );
             p_input = NULL;