]> git.sesse.net Git - vlc/commitdiff
Qt4: avoid integer overflow on V4L2 slider min and max
authorRémi Denis-Courmont <remi@remlab.net>
Sat, 1 Oct 2011 19:38:12 +0000 (22:38 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Sat, 1 Oct 2011 19:38:12 +0000 (22:38 +0300)
Ideally, we should subclass QAbstractSpinBox to support 64-bits values.
But in the mean time, lets at least support the int32_t range.

modules/gui/qt4/components/extended_panels.cpp

index b83dac6ab6f1ab3ab5e96e5f66bc8bc90e05ce80..de2efe1350581ead2afc9ce14d06795b21d3ebb9 100644 (file)
@@ -765,15 +765,18 @@ void ExtV4l2::Refresh( void )
                         vlc_value_t val2;
                         var_Change( p_obj, psz_var, VLC_VAR_GETMIN,
                                     &val2, NULL );
+                        if( val2.i_int < INT_MIN )
+                            val2.i_int = INT_MIN; /* FIXME */
                         slider->setMinimum( val2.i_int );
                         var_Change( p_obj, psz_var, VLC_VAR_GETMAX,
                                     &val2, NULL );
+                        if( val2.i_int > INT_MAX )
+                            val2.i_int = INT_MAX; /* FIXME */
                         slider->setMaximum( val2.i_int );
                         if( !var_Change( p_obj, psz_var, VLC_VAR_GETSTEP,
                                          &val2, NULL ) )
                             slider->setSingleStep( val2.i_int );
                         slider->setValue( i_val );
-
                         CONNECT( slider, valueChanged( int ), this,
                                  ValueChange( int ) );
                         hlayout->addWidget( slider );